Skip to content
  • NeilBrown's avatar
    md: change bitmap_unplug and others to void functions · 4ad13663
    NeilBrown authored
    
    
    bitmap_unplug only ever returns 0, so it may as well be void.  Two callers try
    to print a message if it returns non-zero, but that message is already printed
    by bitmap_file_kick.
    
    write_page returns an error which is not consistently checked.  It always
    causes BITMAP_WRITE_ERROR to be set on an error, and that can more
    conveniently be checked.
    
    When the return of write_page is checked, an error causes bitmap_file_kick to
    be called - so move that call into write_page - and protect against recursive
    calls into bitmap_file_kick.
    
    bitmap_update_sb returns an error that is never checked.
    
    So make these 'void' and be consistent about checking the bit.
    
    Signed-off-by: default avatarNeil Brown <neilb@suse.de>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    4ad13663