Skip to content
  • Ian Abbott's avatar
    staging: comedi: amplc_pc236: fix possible NULL deref during detach · 2db012bd
    Ian Abbott authored
    
    
    `pc236_detach()` is called by the comedi core to clean up if either
    `pc236_attach()` or `pc236_attach_pci()` returns an error.  It sets
    `thisboard` to the return value of `comedi_board(dev)` and assumes it is
    non-null.  This is a valid assumption if `pc236_attach()` fails, but not
    if `pc236_attach_pci()` fails, leading to a possible NULL pointer
    dereference.
    
    Check `thisboard` at the top of `pc236_detach()` and return early if it
    is `NULL`.  This is okay because the only other thing that could have
    been allocated is `dev->private` and that is freed by the comedi core,
    not by this function.
    
    Cc: <stable@vger.kernel.org> # 3.6.x
    Signed-off-by: default avatarIan Abbott <abbotti@mev.co.uk>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    2db012bd