Skip to content
  • Arnd Bergmann's avatar
    serial: 8250/mediatek: fix building with SERIAL_8250=m · 3f5921a6
    Arnd Bergmann authored
    
    
    The Mediatek 8250 driver has a 'bool' Kconfig symbol, but that
    breaks when SERIAL_8250 is a loadable module:
    
    drivers/tty/built-in.o: In function `mtk8250_set_termios':
    :(.text+0x1bee8): undefined reference to `serial8250_do_set_termios'
    :(.text+0x1bf10): undefined reference to `uart_get_baud_rate'
    :(.text+0x1c09c): undefined reference to `uart_get_divisor'
    drivers/tty/built-in.o: In function `mtk8250_do_pm':
    :(.text+0x1c0d0): undefined reference to `serial8250_do_pm'
    drivers/tty/built-in.o: In function `mtk8250_probe':
    :(.text+0x1c2e4): undefined reference to `serial8250_register_8250_port'
    serial/8250/8250_mtk.c:287:242: error: data definition has no type or storage class [-Werror]
    serial/8250/8250_mtk.c:287:122: error: 'mtk8250_platform_driver_init' defined but not used [-Werror=unused-function]
    
    This changes the symbol to a 'tristate', so the dependency on
    SERIAL_8250 also works when that is set to 'm'.
    To actually build the driver, we also need to include <linux/module.h>.
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: default avatarMatthias Brugger <matthias.bgg@gmail.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    3f5921a6