• David S. Miller's avatar
    [NIU]: Fix potentially stuck TCP socket send queues. · 3ebebccf
    David S. Miller authored
    It is possible for the TX ring to have packets sit in it for unbounded
    amounts of time.
    The only way to defer TX interrupts in the chip is to periodically set
    "mark" bits, when processing of a TX descriptor with the mark bit set
    is complete it triggers the interrupt for the TX queue's LDG.
    A consequence of this kind of scheme is that if packet flow suddenly
    stops, the remaining TX packets will just sit there.
    If this happens, since those packets could be charged to TCP socket
    send queues, such sockets could get stuck.
    The simplest solution is to divorce the socket ownership of the packet
    once the device takes the SKB, by using skb_orphan() in
    In hindsight, it would have been much nicer if the chip provided two
    interrupt sources for TX (like basically every other ethernet chip
    does).  Namely, keep the "mark" bit, but also signal the LDG when the
    TX queue becomes completely empty.  That way there is no need to have
    a deadlock breaker like this.
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>