Skip to content
  • John W. Linville's avatar
    netdevice zd1201: Convert directly reference of netdev->priv to netdev_priv() · 3d29b0c3
    John W. Linville authored
    
    
    We have some reasons to kill netdev->priv:
    1. netdev->priv is equal to netdev_priv().
    2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
       netdev_priv() is more flexible than netdev->priv.
    But we cann't kill netdev->priv, because so many drivers reference to it
    directly.
    
    OK, becasue Dave S. Miller said, "every direct netdev->priv usage is a bug",
    and I want to kill netdev->priv later, I decided to convert all the direct
    reference of netdev->priv first.
    
    (Original patch posted by Wang Chen <wangchen@cn.fujitsu.com> w/ above
    changelog but using dev->ml_priv.  That doesn't seem appropriate
    to me for this driver, so I've revamped it to use netdev_priv()
    instead. -- JWL)
    
    Reviewed-by: default avatarWang Chen <wangchen@cn.fujitsu.com>
    Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
    3d29b0c3