Skip to content
  • Milton Miller's avatar
    powerpc/irq: Check desc in handle_one_irq and expand generic_handle_irq · 2e455257
    Milton Miller authored
    Look up the descriptor and check that it is found in handle_one_irq
    before checking if we are on the irq stack, and call the handler
    directly using the descriptor if we are on the stack.
    
    We need check irq_to_desc finds the descriptor to avoid a NULL
    pointer dereference.  It could have failed because the number from
    ppc_md.get_irq was above NR_IRQS, or various exceptional conditions
    with sparse irqs (eg race conditions while freeing an irq if its was
    not shutdown in the controller).
    
    fe12bc2c
    
     (genirq: Uninline and sanity check generic_handle_irq())
    moved generic_handle_irq out of line to allow its use by interrupt
    controllers in modules.  However, handle_one_irq is core arch code.
    It already knows the details of struct irq_desc and handling irqs in
    the nested irq case.  This will avoid the extra stack frame to return
    the value we don't check.
    
    Signed-off-by: default avatarMilton Miller <miltonm@bga.com>
    Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
    2e455257