• Bartlomiej Zolnierkiewicz's avatar
    hpt366: fix build for CONFIG_HOTPLUG=n · 282037f1
    Bartlomiej Zolnierkiewicz authored
    On Saturday 20 October 2007, Avuton Olrich wrote:
    > My randconfig script the attached config caught an error on:
    > drivers/ide/pci/cy82c693.c:439: error: primary causes a section type conflict
    > My git tree: c00046c2
    > Bisected to:
    > 85620436 is first bad commit
    > commit 85620436
    > Author: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    > Date:   Sat Oct 20 00:32:34 2007 +0200
    >     ide: constify struct ide_port_info
    >     Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    It turns out that const and __{dev}initdata cannot be mixed currently
    and that hpt366 host driver is also affected by the same issue:
    > drivers/ide/pci/hpt366.c:1428: error: hpt366_chipsets causes a section type
    > conflict
    This patch workarounds the problem by making static struct hpt_info instances
    const.  Now all __devinitdata data in hpt366 host driver are read-only so it
    builds again (driver's .init.data section gets marked as READONLY).
    While at it:
    * Bump driver version.
    Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
    Cc: "Avuton Olrich" <avuton@gmail.com>
    Cc: Randy Dunlap <randy.dunlap@oracle.com>
    Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
hpt366.c 43.5 KB