Skip to content
  • Eric Dumazet's avatar
    net: sk_free_datagram() should use sk_mem_reclaim_partial() · 270acefa
    Eric Dumazet authored
    I noticed a contention on udp_memory_allocated on regular UDP applications.
    
    While tcp_memory_allocated is seldom used, it appears each incoming UDP frame
    is currently touching udp_memory_allocated when queued, and when received by
    application.
    
    One possible solution is to use sk_mem_reclaim_partial() instead of
    sk_mem_reclaim(), so that we keep a small reserve (less than one page)
    of memory for each UDP socket.
    
    We did something very similar on TCP side in commit
    9993e7d3
    
    
    ([TCP]: Do not purge sk_forward_alloc entirely in tcp_delack_timer())
    
    A more complex solution would need to convert prot->memory_allocated to
    use a percpu_counter with batches of 64 or 128 pages.
    
    Signed-off-by: default avatarEric Dumazet <dada1@cosmosbay.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    270acefa