Skip to content
  • Steven Whitehouse's avatar
    GFS2: Remove gfs2_refresh_inode from inode creation path · 28fb3027
    Steven Whitehouse authored
    
    
    The original method for creating inodes used in GFS2 was to fill
    out a buffer, with all the information, and then to read that
    buffer into the in-core inode, using gfs2_refresh_inode()
    
    The problem with this approach is that all the inode's fields
    need to be calculated ahead of time, and were stored in various
    variables making the code rather complicated.
    
    The new approach is simply to allocate the in-core inode earlier
    and fill in as many fields as possible ahead of time. These can
    then be used to initilise the on disk representation. The
    code has been working towards the point where it is possible
    to remove gfs2_refresh_inode() because all the fields are
    correctly initialised ahead of time. We've now reached that
    milestone, and have reversed the order of setting up the in
    core and on disk inodes.
    
    Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
    28fb3027