Skip to content
  • Denis V. Lunev's avatar
    [NET]: rtnl_unlock cleanups · 1536cc0d
    Denis V. Lunev authored
    
    
    There is no need to process outstanding netlink user->kernel packets
    during rtnl_unlock now. There is no rtnl_trylock in the rtnetlink_rcv
    anymore.
    
    Normal code path is the following:
    netlink_sendmsg
       netlink_unicast
           netlink_sendskb
               skb_queue_tail
               netlink_data_ready
                   rtnetlink_rcv
                       mutex_lock(&rtnl_mutex);
                       netlink_run_queue(sk, qlen, &rtnetlink_rcv_msg);
                       mutex_unlock(&rtnl_mutex);
    
    So, it is possible, that packets can be present in the rtnl->sk_receive_queue
    during rtnl_unlock, but there is no need to process them at that moment as
    rtnetlink_rcv for that packet is pending.
    
    Signed-off-by: default avatarDenis V. Lunev <den@openvz.org>
    Acked-by: default avatarAlexey Kuznetsov <kuznet@ms2.inr.ac.ru>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    1536cc0d