Skip to content
  • David Brownell's avatar
    USB: cdc-acm: signedness fix · c6dbf554
    David Brownell authored
    
    
    Fix bogus assignment of "unsigned char *" to "char *":  preserve
    unsignedness.  These values are used directly as descriptor lengths
    when iterating through the buffer, so this *could* cause oddness
    that potentially includes oopsing.  (IMO not likely, except as
    part of a malicious device...)
    
    Fix the bogus warning in CDC ACM which highlighted this problem
    (by showing a negative descriptor type).  It uses the undesirable
    legacy err() for something that's not even an error; switch to
    use dev_dbg, and show descriptor types in hex notation to match
    the convention for such codes.
    
    Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
    Acked-by: default avatarOliver Neukum <oneukum@suse.de>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    c6dbf554