Skip to content
  • Gleb Natapov's avatar
    x86, setup: Fix EDD3.0 data verification. · 0c612270
    Gleb Natapov authored
    
    
    Check for nonzero path in edd_has_edd30() has no sense. First, it looks
    at the wrong memory. Device path starts at offset 30 of the info->params
    structure which is at offset 8 from the beginning of info structure,
    but code looks at info + 4 instead. This was correct when code was
    introduced, but around v2.6.4 three more fields were added to edd_info
    structure (commit 66b61a5c in history.git). Second, even if it will check
    correct memory it will always succeed since at offset 30 (params->key)
    there will be non-zero values otherwise previous check would fail.
    
    The patch replaces this bogus check with one that verifies checksum.
    
    Signed-off-by: default avatarGleb Natapov <gleb@redhat.com>
    Link: http://lkml.kernel.org/r/20110426082132.GG2265@redhat.com
    
    
    Signed-off-by: default avatarH. Peter Anvin <hpa@linux.intel.com>
    0c612270