All new accounts created on Gitlab now require administrator approval. If you invite any collaborators, please let Flux staff know so they can approve the accounts.

  • Bartlomiej Zolnierkiewicz's avatar
    it821x: RAID mode fixes · 0380dad4
    Bartlomiej Zolnierkiewicz authored
    The DMA support for RAID mode broke after:
    	commit 71ef51cc
    	Author: Jens Axboe <>
    	Date:   Fri Jul 28 09:02:17 2006 +0200
    	    [PATCH] it821x: fix ide dma setup bug
    	    Only enable dma for a valid speed setting.
    	    Signed-off-by: Jens Axboe <>
    	commit 0a8348d0
    	Author: Jens Axboe <>
    	Date:   Fri Jul 28 08:58:26 2006 +0200
    	    [PATCH] ide: if the id fields looks screwy, disable DMA
    	    It's the safer choice. Originally due to a bug in itx821x, but a
    	    generally sound thing to do.
    	    Signed-off-by: Jens Axboe <>
    However it worked by pure luck before Jens' fixes: bogus ide_dma_enable()
    usage in it821x driver combined with loosy check in ide_dma_verbose() allowed
    the hardware to operate in DMA mode.  When these problems were fixed the DMA
    support broke...
    The source root for the regression turned out to be that the it821x.c code
    was clearing too much of id->field_valid.  The IDE core code was using the
    original value of id->field_valid to do the tuning but later DMA got disabled
    in ide_dma_verbose() because of the incorrect id->field_valid fixup.  Fix it.
    While at it:
    * Do fixup() after probing the drives but before tuning them (which is also
      OK w.r.t. ide_undecoded_slave() fixup).  This change fixes device IDENTIFY
      data to be consistent before/after the tuning and allows us to remove extra
      re-tuning of drives from it821x_fixups().
    * Fake MWDMA0 enabled/supported bits in IDENTIFY data if the device has
      DMA capable bit set (this is just to tell the IDE core that DMA is
      supported since it821x firmware takes care of DMA mode programming).
    * Don't touch timing registers and don't program transfer modes on devices
      et all when in RAID mode - depend solely on firmware to do the tuning
      (as suggested by Alan Cox and done in libata pata_it821x driver).
    Thanks for testing the patch goes out to Thomas Kuther.
    Cc: Thomas Kuther <>
    Cc: Alan Cox <>
    Cc: Jens Axboe <>
    Signed-off-by: default avatarBartlomiej Zolnierkiewicz <>
ide-probe.c 37 KB