• Michal Nazarewicz's avatar
    usb: gadget: f_fs: fix NULL pointer dereference when there are no strings · f0688c8b
    Michal Nazarewicz authored
    If the descriptors do not need any strings and user space sends empty
    set of strings, the ffs->stringtabs field remains NULL.  Thus
    *ffs->stringtabs in functionfs_bind leads to a NULL pointer
    The bug was introduced by commit [fd7c9a00: “use usb_string_ids_n()”].
    While at it, remove double initialisation of lang local variable in
    that function.
    ffs->strings_count does not need to be checked in any way since in
    the above scenario it will remain zero and usb_string_ids_n() is
    a no-operation when colled with 0 argument.
    Cc: <stable@vger.kernel.org>  # v2.6.36+
    Signed-off-by: default avatarMichal Nazarewicz <mina86@mina86.com>
    Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
f_fs.c 66.2 KB