1. 11 May, 2012 1 commit
  2. 10 May, 2012 5 commits
    • Ian Jackson's avatar
      blktap2: Fix another uninitialised value error · 7aae1999
      Ian Jackson authored
      gcc  -O1 -fno-omit-frame-pointer -m32 -march=i686 -g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement   -D__XEN_TOOLS__ -MMD -MF .block-remus.o.d -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls -mno-tls-direct-seg-refs -Werror -g -Wno-unused -fno-strict-aliasing -I../include -I../drivers -I/home/osstest/build.12828.build-i386/xen-unstable/tools/blktap2/drivers/../../../tools/libxc -I/home/osstest/build.12828.build-i386/xen-unstable/tools/blktap2/drivers/../../../tools/include -D_GNU_SOURCE -DUSE_NFS_LOCKS  -c -o block-remus.o block-remus.c
      
      block-remus.c: In function 'ramdisk_flush':
      block-remus.c:508: error: 'buf' may be used uninitialized in this function
      make[5]: *** [block-remus.o] Error 1
      
      This is because gcc can see that merge_requests doesn't always set
      *mergedbuf but gcc isn't able to prove that it always does so if
      merge_requests returns 0 and that in that case the value of
      ramdisk_flush::buf isn't used.
      
      This is too useful a warning to disable, despite the occasional false
      positive of this form.  The conventional approach is to suppress the
      warning by explicitly initialising the variable to 0.
      
      This has just come to light because 25275:27d63b9f111a reenabled
      optimisation for this area of code, and gcc's data flow analysis
      (which is required to trigger the uninitialised variable warning) only
      occurs when optimisation is turned on.
      Signed-off-by: default avatarIan Jackson <ian.jackson@eu.citrix.com>
      7aae1999
    • Keir Fraser's avatar
      blktap2: Do not build with -O0 · 96d3d677
      Keir Fraser authored
      Signed-off-by: default avatarKeir Fraser <keir@xen.org>
      96d3d677
    • Keir Fraser's avatar
      blktap2: Fix uninitialised value error. · 3cc561bf
      Keir Fraser authored
      Signed-off-by: default avatarKeir Fraser <keir@xen.org>
      3cc561bf
    • Olaf Hering's avatar
      tools/blktap2: fix out of bounds access in block-log.c · 42c238f8
      Olaf Hering authored
      block-log.c: In function 'ctl_close_sock':
      block-log.c:363:23: warning: array subscript is above array bounds
      [-Warray-bounds]
      
      Adjust loop condition in ctl_close_sock() to fix warning.
      Adjust array acccess in ctl_close() to actually access the array
      member.
      Signed-off-by: default avatarOlaf Hering <olaf@aepfle.de>
      Acked-by: default avatarIan Jackson <ian.jackson@eu.citrix.com>
      Committed-by: default avatarKeir Fraser <keir@xen.org>
      42c238f8
    • Olaf Hering's avatar
      tools/blktap2: fix build errors caused by Werror in · 40f2ead7
      Olaf Hering authored
      vhd_journal_write_entry
      
      -O2 -Wall -Werror triggers these warnings:
      
      libvhd-journal.c: In function 'vhd_journal_write_entry':
      libvhd-journal.c:335: warning: statement with no effect
      
      Really return the error from vhd_journal_write() to caller.
      
      v2:
       - simplify the patch by just adding the missing return statement
      Signed-off-by: default avatarOlaf Hering <olaf@aepfle.de>
      Committed-by: default avatarKeir Fraser <keir@xen.org>
      40f2ead7
  3. 05 Apr, 2012 1 commit
  4. 14 Mar, 2012 2 commits
  5. 13 Feb, 2012 1 commit
  6. 26 Jan, 2012 1 commit
    • Andres Lagar-Cavilla's avatar
      Update memshr API and tools · 5c6dede9
      Andres Lagar-Cavilla authored
      This patch is the folded version of API updates, along with the associated tool
      changes to ensure that the build is always consistent.
      
      API updates:
      - The source domain in the sharing calls is no longer assumed to be dom0.
      - Previously, the mem sharing code would return an opaque handle to index
        shared pages (and nominees) in its global hash table.  By removing the hash
        table, the handle becomes a version, to avoid sharing a stale version of a
        page. Thus, libxc wrappers and tools need to be updated to recall the share
        functions with the information needed to fetch the page (which they readily
        have).
      
      Tool updates:
      The only (in-tree, that we know of) consumer of the mem sharing API is the
      memshr tool. This is updated to use the new API.
      Signed-off-by: default avatarAndres Lagar-Cavilla <andres@lagarcavilla.org>
      Signed-off-by: default avatarAdin Scannell <adin@scannell.ca>
      Acked-by: default avatarIan Campbell <ian.campbell@citrix.com>
      Committed-by: default avatarTim Deegan <tim@xen.org>
      5c6dede9
  7. 20 Dec, 2011 2 commits
  8. 10 Jan, 2012 1 commit
  9. 28 Nov, 2011 1 commit
  10. 22 Nov, 2011 1 commit
    • Ian Campbell's avatar
      tools: use system installed libaio by default. · 46c2d550
      Ian Campbell authored
      I could have sworn I did this years ago.
      
      IIRC the need for our own copy was due to the use of io_set_eventfd which is
      not present in version 0.3.106. However it is in 0.3.107 the first version of
      which was uploaded to Debian in June 2008 (I can't find a better reference for
      the release date).
      
      The necessary version is available in Debian Lenny onwards and is in at least
      RHEL 6, Fedora 13 and OpenSuSE 11.3. The necessary version appears to not be
      available in RHEL 5 or SLES 11 which is why I haven't simply nuked the in tree
      version.
      
      This is based on tools-system-libaio.diff from the Debian packaging although I
      have made it optional (but default on).
      Signed-off-by: default avatarIan Campbell <ian.campbell@citrix.com>
      Committed-by: default avatarIan Jackson <ian.jackson@eu.citrix.com>
      46c2d550
  11. 28 Sep, 2011 1 commit
  12. 10 Jun, 2011 1 commit
    • Olaf Hering's avatar
      tools: merge several bitop functions into xc_bitops.h · 8066ac41
      Olaf Hering authored
      Bitmaps are used in save/restore, xenpaging and blktap2.  Merge the code into a
      private xc_bitops.h file. All users are single threaded, so locking is not an
      issue. The array of bits is handled as volatile because the x86 save/restore
      code passes the bitmap to the hypervisor which in turn modifies the bitmap.
      
      blktap2 uses a private bitmap. There was a possible overflow in the
      bitmap_size() function, the remainder was not considered.
      
      ia64 save/restore uses a bitmap to send the number of vcpus to the host.
      
      x86 save/restore uses a bitmap to track dirty pages. This bitmap is shared with
      the hypervisor. An unused function count_bits() was removed and a new
      bitmap_size() function is now used.
      
      xenpaging uses 3 private bitmaps to track the gfns which are in paged-out
      state.  It had a copy of some Linux bitops.h, which is now obsolete. Also the
      BITS_PER_LONG macro was hardcoded to 64 which made it impossible to run 32bit
      tools on a 64bit host. Wether this works at all has to be tested, yet.
      Signed-off-by: default avatarOlaf Hering <olaf@aepfle.de>
      Committed-by: Ian Jackson <ian.jackson.citrix.com>
      8066ac41
  13. 21 Jun, 2011 1 commit
  14. 26 May, 2011 1 commit
  15. 31 Mar, 2011 3 commits
  16. 23 Mar, 2011 1 commit
  17. 21 Mar, 2011 2 commits
  18. 17 Mar, 2011 6 commits
  19. 07 Mar, 2011 1 commit
  20. 25 Feb, 2011 1 commit
  21. 01 Feb, 2011 1 commit
  22. 17 Jan, 2011 1 commit
  23. 28 Oct, 2010 1 commit
  24. 12 Aug, 2010 1 commit
  25. 11 Aug, 2010 1 commit
  26. 03 Aug, 2010 1 commit