Commit 027b424b authored by Keir Fraser's avatar Keir Fraser

x86: fix next->vcpu_dirty_cpumask checking in context_switch()

There was a timing window where flush_tlb_mask() could be called with
an empty mask (triggering a WARN_ON() in send_IPI_mask_flat() along
with APIC errors) because rather than using the already taken snapshot
of next's vcpu_dirty_cpumask struct vcpu's field was used directly,
which can get its only bit cleared by remote CPUs.

Replacing the structure field's use by the local variable then made
the inner cpus_empty() check completely redundant with the one in the
surrounding if()'s condition.
Signed-off-by: default avatarJan Beulich <jbeulich@novell.com>
parent c62a4ad7
......@@ -1308,8 +1308,7 @@ void context_switch(struct vcpu *prev, struct vcpu *next)
if ( unlikely(!cpu_isset(cpu, dirty_mask) && !cpus_empty(dirty_mask)) )
{
/* Other cpus call __sync_lazy_execstate from flush ipi handler. */
if ( !cpus_empty(next->vcpu_dirty_cpumask) )
flush_tlb_mask(next->vcpu_dirty_cpumask);
flush_tlb_mask(dirty_mask);
}
if ( is_hvm_vcpu(prev) && !list_empty(&prev->arch.hvm_vcpu.tm_list) )
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment