1. 26 Feb, 2018 1 commit
    • Mark Michelson's avatar
      Refer to database manpages in *ctl manpages · 8519ea87
      Mark Michelson authored
      The ovn-nbctl, ovn-sbctl, and ovs-vsctl manpages are inconsistent in
      their "Database Commands" section when it comes to referring to what
      database tables exist. This commit amends this by making each *ctl
      manpage reference the corresponding database manpage instead.
      
      To aid in having a more handy list, the --help text of ovn-nbctl,
      ovn-sbctl, and ovs-vsctl have been modified to list the available
      tables. This is also referenced in the manpages for those applications.
      Signed-off-by: default avatarMark Michelson <mmichels@redhat.com>
      Signed-off-by: default avatarBen Pfaff <blp@ovn.org>
      8519ea87
  2. 16 Feb, 2018 1 commit
  3. 13 Feb, 2018 1 commit
  4. 06 Feb, 2018 1 commit
  5. 01 Feb, 2018 1 commit
    • Ben Pfaff's avatar
      Support accepting and displaying table names in OVS tools. · 4bc938cc
      Ben Pfaff authored
      OpenFlow has little-known support for naming tables.  Open vSwitch has
      supported table names for ages, but it has never used or displayed them
      outside of commands dedicated to table manipulation.  This commit adds
      support for table names in ovs-ofctl.  When a table has a name, it displays
      that name in flows and actions, so that, for example, the following:
          table=1, arp, actions=resubmit(,2)
      might become:
          table=ingress_acl, arp, actions=resubmit(,mac_learning)
      given appropriately named tables.
      
      For backward compatibility, only interactive ovs-ofctl commands by default
      display table names; to display them in scripts, use the new --names
      option.
      
      This feature was inspired by a talk that Kei Nohguchi presented at Open
      vSwitch 2017 Fall Conference.
      
      CC: Kei Nohguchi <kei@nohguchi.com>
      Signed-off-by: default avatarBen Pfaff <blp@ovn.org>
      Acked-by: default avatarMark Michelson <mmichels@redhat.com>
      Reviewed-by: default avatarYifeng Sun <pkusunyifeng@gmail.com>
      4bc938cc
  6. 31 Jan, 2018 2 commits
  7. 27 Jan, 2018 2 commits
  8. 26 Jan, 2018 3 commits
  9. 25 Jan, 2018 1 commit
  10. 12 Jan, 2018 1 commit
  11. 11 Jan, 2018 1 commit
  12. 10 Jan, 2018 4 commits
  13. 08 Jan, 2018 1 commit
  14. 24 Dec, 2017 1 commit
  15. 22 Dec, 2017 1 commit
  16. 14 Dec, 2017 1 commit
  17. 07 Dec, 2017 1 commit
    • Yi-Hung Wei's avatar
      dpctl: Support flush conntrack by conntrack 5-tuple · c43a1331
      Yi-Hung Wei authored
      With this patch, "flush-conntrack" in ovs-dpctl and ovs-appctl accept
      a conntrack 5-tuple to delete the conntrack entry specified by the 5-tuple.
      For example, user can use the following command to flush a conntrack entry
      in zone 5.
      
      $ ovs-dpctl flush-conntrack zone=5 \
        'ct_nw_src=10.1.1.2,ct_nw_dst=10.1.1.1,ct_nw_proto=17,ct_tp_src=2,ct_tp_dst=1'
      
      $ ovs-appctl dpctl/flush-conntrack zone=5 \
        'ct_nw_src=10.1.1.2,ct_nw_dst=10.1.1.1,ct_nw_proto=17,ct_tp_src=2,ct_tp_dst=1'
      
      VMWare-BZ: #1983178
      Signed-off-by: default avatarYi-Hung Wei <yihung.wei@gmail.com>
      Signed-off-by: default avatarJustin Pettit <jpettit@ovn.org>
      c43a1331
  18. 13 Nov, 2017 2 commits
    • Aaron Conole's avatar
      ovs-tcpdump: handle large interface names on linux · b4027b17
      Aaron Conole authored
      Linux has a fixed size interface name, which will not change.  This means
      that attempts to dump interfaces whose names are larger than the max size
      will result in an error making the tap device.
      
      This commit brings a new function.  When the generated name would be too
      large, use a random number prefixed by 'ovsmi' instead.
      Reported-by: default avatarBhanuprakash Bodireddy <bhanuprakash.bodireddy@intel.com>
      Signed-off-by: default avatarAaron Conole <aconole@redhat.com>
      Signed-off-by: default avatarBen Pfaff <blp@ovn.org>
      b4027b17
    • Gurucharan Shetty's avatar
      ovs-ctl: Don't remember vport-* kernel modules · a3c5fca1
      Gurucharan Shetty authored
      From OVS 2.8, ovs-vswitchd, when it starts, will
      load the kernel modules for tunnels. It has logic
      inside it to choose either upstream kernel module
      or vport-* kernel module.
      
      So, when we run 'force-reload-kmod' to upgrade to
      OVS 2.8 from a previous version,  we do not need to
      remember the vport-* kernel module that was previously
      loaded.  It is not really harmful to load vport-* kernel
      module though.
      
      On RHEL7.x and OVS 2.8, we use the upstream "geneve" kernel
      module for tunnels.
      
      But, on RHEL 7.x we have hit a bug caused by iptables
      startup script which tries to remove all kernel modules
      related to linux conntrack. It fails to unload openvswitch
      kernel module because it has a reference count on it. But it
      succeeds in unloading vport-geneve and in turn the upstream
      "geneve" kernel module.  This causes the tunnels to go down.
      
      With this patch, we avoid the above situation, by not loading
      vport-geneve kernel module.  ovs-vswitchd when it starts will
      load upstream geneve. And when "iptables stop" runs, since
      "geneve" has nothing to do with conntrack, it spares it.
      Ideally, we should fix this by incrementing the refcount
      on the kernel modules.
      Signed-off-by: default avatarGurucharan Shetty <guru@ovn.org>
      Acked-by: default avatarWilliam Tu <u9012063@gmail.com>
      a3c5fca1
  19. 03 Nov, 2017 2 commits
  20. 31 Oct, 2017 1 commit
  21. 27 Oct, 2017 4 commits
  22. 20 Oct, 2017 1 commit
    • Gurucharan Shetty's avatar
      ovs-save: Handle different 'ip addr show' output. · a6480fc6
      Gurucharan Shetty authored
      On RHEL 7.4 (with iproute-3.10.0-87), a DHCP provided
      ipv4 address has the "dynamic" keyword set. For e.g
      "ip addr show breth0 | grep inet" shows:
      
          inet 10.116.248.91/20 brd 10.116.255.255 scope global dynamic breth0
          inet6 fe80::250:56ff:fea8:fdf0/64 scope link
      
      The keyword "dynamic" (according to 'man ip-address') is only
      used for ipv6, but in this case this is not true. Our current
      code will skip the ipv4 address restoration because of this.
      
      With this commit, we special case "dynamic" keyword to be valid
      in case of ipv4.
      
      VMware-BZ: #1982196
      Signed-off-by: default avatarGurucharan Shetty <guru@ovn.org>
      Acked-by: default avatarYi-Hung Wei <yihung.wei@gmail.com>
      a6480fc6
  23. 10 Oct, 2017 1 commit
  24. 06 Oct, 2017 1 commit
  25. 21 Aug, 2017 2 commits
    • Justin Pettit's avatar
      ofproto-dpif: Mark packets as "untracked" after call to ct(). · f6fabcc6
      Justin Pettit authored
      Packet and Connection state is only available to the processing path
      that follows the "recirc_table" argument of the ct() action.  The
      previous behavior made these states available until the end of the
      pipeline.  This commit changes the behavior so that the Packet and
      Connection state are cleared for the current processing path whenever
      ct() is called (in addition to reaching the end of the pipeline.)
      
      A future commit will remove the behavior that a "send to controller"
      action causes all packets for that flow to be handled via the slow-path.
      The current behavior of connection tracking state makes that difficult
      due to datapath actions containing multiple OpenFlow rules that may
      contain different connection tracking states.  This change will make
      that future commit possible.
      Signed-off-by: default avatarJustin Pettit <jpettit@ovn.org>
      Acked-by: default avatarJoe Stringer <joe@ovn.org>
      f6fabcc6
    • Joe Stringer's avatar
      checkpatch: Enforce bracing around conditionals. · 3f9e248f
      Joe Stringer authored
      The coding style states that BSD-style brace placement should be used,
      and even single statements should be enclosed. Add checks to checkpatch
      for this, particularly for 'else' statements.
      Signed-off-by: default avatarJoe Stringer <joe@ovn.org>
      Acked-by: default avatarAaron Conole <aconole@redhat.com>
      3f9e248f
  26. 09 Aug, 2017 2 commits