1. 19 Mar, 2016 1 commit
  2. 27 Jun, 2015 1 commit
  3. 16 Mar, 2015 1 commit
    • Russell Bryant's avatar
      command-line: add ovs_cmdl_ prefix · 5f383751
      Russell Bryant authored
      The coding style guidelines include the following:
        - Pick a unique name prefix (ending with an underscore) for each
          module, and apply that prefix to all of that module's externally
          visible names.  Names of macro parameters, struct and union members,
          and parameters in function prototypes are not considered externally
          visible for this purpose.
      This patch adds the new prefix to the externally visible names.  This
      makes it a bit more obvious what code is coming from common command
      line handling code.
      Signed-off-by: default avatarRussell Bryant <rbryant@redhat.com>
      Signed-off-by: default avatarBen Pfaff <blp@nicira.com>
  4. 08 Jan, 2015 1 commit
  5. 15 Dec, 2014 1 commit
  6. 28 Oct, 2014 2 commits
  7. 04 Aug, 2014 1 commit
    • Ben Pfaff's avatar
      ovs-appctl: Add logging options. · 9664732f
      Ben Pfaff authored
      Normally I would also add documentation for the logging options to the
      ovs-appctl manpage, but I am concerned that in this case it would actually
      make the manpage confusing, because one of the main purposes of ovs-appctl
      is to modify the log levels of *other* programs, and these options only
      modify the log level of ovs-appctl itself, which is rarely useful.
      The following commit will start using these logging options in a test.
      Signed-off-by: default avatarBen Pfaff <blp@nicira.com>
      Acked-by: default avatarAnsis Atteka <aatteka@nicira.com>
  8. 28 Mar, 2014 2 commits
  9. 17 Dec, 2013 1 commit
  10. 02 May, 2012 1 commit
  11. 07 Mar, 2012 1 commit
  12. 21 Feb, 2012 1 commit
    • Ethan Jackson's avatar
      unixctl: New JSON RPC back-end. · bde9f75d
      Ethan Jackson authored
      The unixctl library had used the vde2 management protocol since the
      early days of Open vSwitch.  As Open vSwitch has matured, several
      Python daemons have been added to the code base which would benefit
      from a unixctl implementations.  Instead of implementing the old
      unixctl protocol in Python, this patch changes unixctl to use JSON
      RPC for which we already have an implementation in both Python and
      C.  Future patches will need to implement a unixctl library in
      Python on top of JSON RPC.
      Signed-off-by: default avatarEthan Jackson <ethan@nicira.com>
  13. 27 Feb, 2012 1 commit
  14. 19 Dec, 2011 1 commit
    • Ben Pfaff's avatar
      unixctl: Implement quoting. · 0e15264f
      Ben Pfaff authored
      The protocol used by ovs-appctl has a long-standing bug that there
      is no way to distinguish "ovs-appctl a b c" from "ovs-appctl 'a b c'".
      This isn't a big deal because none of the current commands really
      want to accept arguments that include spaces, but it's kind of a silly
      At the same time, the internal API is awkward because every user is
      stuck doing its own argument parsing, which is no fun.
      This commit fixes both problems, by adding shell-like quoting to the
      protocol and modifying the internal API from one that passes a string
      to one that passes in an array of pre-parsed strings.  Command
      implementations may now specify how many arguments they expect.  This
      simplifies some command implementations significantly.
      Signed-off-by: default avatarBen Pfaff <blp@nicira.com>
  15. 04 Aug, 2011 2 commits
  16. 01 Aug, 2011 1 commit
    • Ben Pfaff's avatar
      vlog: Add a new log level "off". · c1a543a8
      Ben Pfaff authored
      Until now, "emer" has effectively been "off" because no messages were ever
      logged at "emer" level.  Justin points out that it is useful to use "emer"
      for messages that indicate a fatal error.  This commit makes that change
      and adds a new "off" level to really turn off all logging to a facility.
  17. 16 Jun, 2011 1 commit
  18. 16 May, 2011 1 commit
  19. 08 Dec, 2010 1 commit
  20. 29 Nov, 2010 1 commit
    • Ben Pfaff's avatar
      Make installation directories overridable at runtime. · b43c6fe2
      Ben Pfaff authored
      This makes it possible to run tests that need access to installation
      directories, such as the rundir, without having access to the actual
      installation directories (/var/run is generally not world-writable), by
      setting environment variables.  This is not a good way to do things in
      general--usually it would be better to choose the correct directories
      at configure time--so for now this is undocumented.
  21. 21 Jul, 2010 1 commit
  22. 02 Feb, 2010 1 commit
  23. 16 Nov, 2009 1 commit
    • Justin Pettit's avatar
      ovs-appctl: Fix shadow variable that could cause segfault · fb344b86
      Justin Pettit authored
      The variable "socket_name" contains the name of the unix domain socket
      to be used for communicating with the OVS process.  If the target does
      not begin with a "/", the socket name is determined based on a pidfile.
      A shadow copy of "socket_name" was kept in the block that looks at the
      pidfile, which would cause the function-level one to not be set.  This
      removes that shadow copy.
  24. 09 Nov, 2009 1 commit
    • Ben Pfaff's avatar
      Make ovs-appctl easier to use and synchronize its interface with ovs-vsctl. · 3fbe1d30
      Ben Pfaff authored
      It is inconvenient to type the whole path to the Unix daemon socket when
      using ovs-appctl.  Allow the name of the daemon to be used instead when
      a pidfile exists in the default location, and contact ovs-vswitchd by
      Also, the various options for manipulating vlog were invented before the
      general-purpose command mechanism existed.  Get rid of all of the action
      options in favor of just specifying the command to be executed as
      non-option arguments.
      Finally, there simply wasn't much value in allowing multiple targets or
      options to be specified; these variations were never used in practice.  So
      simplify the interface by making it one target, one action per invocation.
      Also, make ovs-vsctl use the same syntax for its --target option.
      Based on work by Justin Pettit.
  25. 15 Jun, 2009 1 commit
  26. 08 Jul, 2009 1 commit