Commit d50b88bf authored by Sorin Vinturis's avatar Sorin Vinturis Committed by Ben Pfaff

datapath-windows: Solved BSOD when adding OVS ports

This BSOD occurred in the context of a packet (NBL) with multiple
NET_BUFFER(s) (NBs). The reason for the BSOD is due to the marking
of NBLs created by OVS as being external and wrongly completing them.
Signed-off-by: default avatarSorin Vinturis <svinturis@cloudbasesolutions.com>
Reported-by: default avatarSorin Vinturis <svinturis@cloudbasesolutions.com>
Reported-at: https://github.com/openvswitch/ovs-issues/issues/82Acked-by: default avatarAlin Gabriel Serdean <aserdean@cloudbasesolutions.com>
Signed-off-by: default avatarBen Pfaff <blp@nicira.com>
parent c499a7e9
......@@ -560,7 +560,8 @@ OvsInitExternalNBLContext(PVOID ovsContext,
poolHandle = NdisGetPoolFromNetBufferList(nbl);
if (poolHandle == context->ovsPool.ndisHandle) {
if (poolHandle == context->ovsPool.ndisHandle ||
nbl->SourceHandle == context->ovsPool.ndisHandle) {
return (POVS_BUFFER_CONTEXT)NET_BUFFER_LIST_CONTEXT_DATA_START(nbl);
}
status = NdisAllocateNetBufferListContext(nbl, sizeof (OVS_BUFFER_CONTEXT),
......@@ -801,6 +802,7 @@ OvsPartialCopyNBL(PVOID ovsContext,
OVS_DEFAULT_PORT_NO);
InterlockedIncrement((LONG volatile *)&srcCtx->refCount);
#ifdef DBG
OvsDumpNetBufferList(nbl);
OvsDumpForwardingDetails(nbl);
......@@ -808,6 +810,7 @@ OvsPartialCopyNBL(PVOID ovsContext,
OvsDumpNetBufferList(newNbl);
OvsDumpForwardingDetails(newNbl);
#endif
OVS_LOG_LOUD("Partial Copy new NBL: %p", newNbl);
return newNbl;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment