Commit 4fbe77d8 authored by Alin Gabriel Serdean's avatar Alin Gabriel Serdean

daemon-windows: Set default error mode for services

Microsoft allows default process memory dumps via WER (Windows Error
Reporting).
WER can be set to collect dumps using in general using:
https://msdn.microsoft.com/en-us/library/windows/desktop/bb787181(v=vs.85).aspx
If a normal application crashes, the user will receive a pop-up dialog,
in which he will be asked of his consent on what will be the steps
after the dump was created (debug, close or send the dump to MSFT).
We disable the dump creation via WER in:
https://github.com/openvswitch/ovs/blob/master/lib/util.c#L492
because the idea is we don't want a pop-up if a OVS process (eg. ovs-vsctl)
has crashed.
(more information on the subject:
https://blogs.msdn.microsoft.com/oldnewthing/20040727-00/?p=38323)

Until we implement our own dump collection mechanism, we can set the default
error mode for services because there are no pop-ups allowed in that case.
Signed-off-by: default avatarAlin Gabriel Serdean <aserdean@ovn.org>
Requested-by: default avatarAnand Kumar <kumaranand@vmware.com>
Acked-by: default avatarAnand Kumar <kumaranand@vmware.com>
parent 42206c5f
......@@ -138,6 +138,12 @@ service_start(int *argcp, char **argvp[])
*argcp = sargc;
*argvp = *sargvp;
/* Enable default error mode so we can take advantage of WER
* (Windows Error Reporting) crash dumps.
* Being a service it does not allow for WER window pop-up.
* XXX implement our on crash dump collection mechanism. */
SetErrorMode(0);
return;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment