GitLab

Also turn on experiment name.

aggregate in the DDC.

Remove obsolete stitching rspecs.

I appear to have broken it while doing moonshot support...

from directory to filename when IMAGEDIRECTORIES is turned off, or
not admin|feature enabled.

Perl realpath returns undef or '' (take your pick) if the path does not
exist, rendering it pretty much useless for our check. So we run realpath
on the directory part of the path (which should exist) and then do some
other paranoid checks on the filename part (no funky chars, cannot be a
symlink).

Also, clean up some nits.

types in the images/default_typelist sitevar.

In the case the upstream server was not responding, this would slowly eat
away FDs and ephemeral ports.

The hard-coded per-model offsets aren't always correct.  Need to deal
with this in a different way, but this is a quick hack to move things along
with the Utah stitcher aggregate.

Soon, we will have images with both full images and deltas, for the same
image version. To make this possible, the image path will now be a
directory instead of a file, and all of the versions (ndz,sig,sha1,delta)
files will reside in the directory.

A new config variable IMAGEDIRECTORIES turns this on, there is also a check
for the ImageDiretories feature. This is applied only when a brand new
image is created; a clone version of the image inherits the path it started
with. Yes, you can have a mix of directory based and file based image
descriptors.

When it is time to convert all images over, there is a script called
imagetodir that will go through all image descriptors, create the
directory, move/rename all the files, and update the descriptors.
Ultimately, we will not support file based image paths.

I also added versioning to the image metadata descriptors so that going
forward, old clients can handle a descriptor from a new server.