1. 28 Nov, 2018 1 commit
  2. 08 Nov, 2018 1 commit
  3. 29 Aug, 2018 1 commit
  4. 26 Apr, 2018 1 commit
  5. 13 Dec, 2017 1 commit
    • Leigh Stoller's avatar
      This started out as a simple change ... · 1d526637
      Leigh Stoller authored
      I noticed that group_root could not delete users from projects. Seems
      like we should allow that, but with the restriction that a group_root
      cannot delete another group_root. Simple enough, right? Well thats not
      how the permission system works; permission to do stuff to users is
      based on who you are in the project, not who you are doing it to.
      
      And then there are the subtle differences in permission handling between
      the Classic interface and the Portal interface. And I am fully
      unmotivated to fix anything in the Classic interface, hard to believe?
      
      Anyway, most people are not going to notice anything since the bulk of
      the changes affect sub groups. Sigh.
      1d526637
  6. 04 Oct, 2017 1 commit
  7. 05 Jan, 2017 1 commit
  8. 24 Jun, 2016 1 commit
    • Leigh Stoller's avatar
      Change "genesis" to "portal" what the hell was I thinking when I · 040ea3be
      Leigh Stoller authored
      picked genesis. But this change actually has content; we need to
      distinguish between classic projects and emulab portal projects
      (new projects created via the portal, and used via the portal).  For now
      these are distinct until we decide to bring everyone up to the new
      interface.
      040ea3be
  9. 25 May, 2016 1 commit
  10. 08 Dec, 2015 1 commit
    • Kirk Webb's avatar
      Batch of changes that creates a PhantomNet portal branding. · ba49a457
      Kirk Webb authored
      Also includes some PhantomNet-specific restrictions (e.g. only
      allows use of the main Utah Emulab testbed  aggregate).
      
      This excercise stretched the limits of what we can reasonably do
      before introducing real per-testbed branding/policy mechanisms to
      the php/web front-end.  My changes ain't exactly pretty...
      
      Please take care when adding any testbed-specific changes to the
      code.  There are three flavors now to consider in the logic.
      ba49a457
  11. 10 Nov, 2015 1 commit
  12. 26 Oct, 2015 1 commit
  13. 27 Jan, 2015 1 commit
  14. 12 Sep, 2014 1 commit
  15. 26 Aug, 2014 1 commit
  16. 17 Jan, 2014 1 commit
  17. 06 Nov, 2013 1 commit
  18. 24 Sep, 2012 1 commit
    • Eric Eide's avatar
      Replace license symbols with {{{ }}}-enclosed license blocks. · 6df609a9
      Eric Eide authored
      This commit is intended to makes the license status of Emulab and
      ProtoGENI source files more clear.  It replaces license symbols like
      "EMULAB-COPYRIGHT" and "GENIPUBLIC-COPYRIGHT" with {{{ }}}-delimited
      blocks that contain actual license statements.
      
      This change was driven by the fact that today, most people acquire and
      track Emulab and ProtoGENI sources via git.
      
      Before the Emulab source code was kept in git, the Flux Research Group
      at the University of Utah would roll distributions by making tar
      files.  As part of that process, the Flux Group would replace the
      license symbols in the source files with actual license statements.
      
      When the Flux Group moved to git, people outside of the group started
      to see the source files with the "unexpanded" symbols.  This meant
      that people acquired source files without actual license statements in
      them.  All the relevant files had Utah *copyright* statements in them,
      but without the expanded *license* statements, the licensing status of
      the source files was unclear.
      
      This commit is intended to clear up that confusion.
      
      Most Utah-copyrighted files in the Emulab source tree are distributed
      under the terms of the Affero GNU General Public License, version 3
      (AGPLv3).
      
      Most Utah-copyrighted files related to ProtoGENI are distributed under
      the terms of the GENI Public License, which is a BSD-like open-source
      license.
      
      Some Utah-copyrighted files in the Emulab source tree are distributed
      under the terms of the GNU Lesser General Public License, version 2.1
      (LGPL).
      6df609a9
  19. 25 Jun, 2010 1 commit
  20. 22 Mar, 2010 1 commit
    • Leigh Stoller's avatar
      Finish up user deletion. The big visible change is that when a user is · 2965922b
      Leigh Stoller authored
      deleted, they still remain in the user table with a status of
      "archived", but since all the queries in the system now use uid_idx
      instead of uid, it is safe to reuse a uid since they are no longer
      ambiguous. 
      
      The reason for not deleting users from the users table is so that the
      stats records can refer to the original record (who was that person
      named "mike"). This is very handy and worth the additional effort it
      has taken.
      
      There is no way to ressurect a user, but it would not be hard to add.
      2965922b
  21. 30 Nov, 2009 1 commit
  22. 28 Nov, 2009 1 commit
  23. 26 Feb, 2009 1 commit
  24. 01 May, 2008 1 commit
    • Kevin Atkinson's avatar
      Implemt FS#187 -- Show admin history of projects: · 8054f5f8
      Kevin Atkinson authored
        When a project is initially created a new mailing list is created,
        PROJ-admin@emulab.net.
      
        testbed-approval is subscribed to the list
      
        Several emails that originally went to testbed-approval now go to the
        mailing list instead.  The From, To, fields are basically the same
        with testbed-approval becoming PROJ-admin.  This means some mail
        is sent with a From PROJ-admin and Bcc the mailing list.  Note that
        some mail still goes to testbed-approval directly, in particular
        ones where there is no clear project involved, and when a project is
        denied.
      
        In addition notifications of approval status of new members is also
        sent to the list.  These emails use to only go to testbed-audit@.
      
        Currently All mail sent to PROJ-admin is also sent to testbed-audit
        (via a Bcc).  This means that some mail that didn't use to go to
        testbed-audit now does.
      
        The mailing list is deleted when a project is deleted with out first
        being approved.  Becuase of this notified that a project is denied
        is sent to testbed-approval instead of PROJ-admin.
      
        Admins can access the mailing list from the Project Profile page.
      
        The mailing list is open in order to allow users to reply to the
        mailing list, in addition the check that PROJ-admin is in the To or
        CC field is disabled.  There is currently no spam control on the
        mailing lists.  However, since the mailing list address is not posted
        anywhere it should't pick up to much spam.  If it does we can deal
        with it then.
      
        Finally, a new script is created to create the per-project admin
        mailing list.  See doc/UPDATING.
      
      Also add DBQuerySingleFatal to libdb, which is like DBQueryFatal but
      also fails if the query didn't return any results.  Basically
      identical to he version in libtblog.  Eventually libtblog should be
      modified to use this version.
      8054f5f8
  25. 10 Apr, 2008 1 commit
  26. 27 Feb, 2008 1 commit
  27. 02 Nov, 2007 1 commit
  28. 01 Nov, 2007 2 commits
  29. 30 Oct, 2007 1 commit
    • Russ Fish's avatar
      Avoid a problem in newproject.php3. When the DB is locked for daily backup, · 2f373d5b
      Russ Fish authored
      NewNewUser()/newuser would block and then unblock and get done; meanwhile the PHP
      thread went away so we never returned to call NewNewProject/mkproj.  Move the call
      on the newuser script from PHP into the back-end Perl newproj script for atomicity.
      
          www/newproject.php3 - When the project leader is a new user, pass two xml
              files to the newproj backend script, one describing the project and the
              second one (an optional) file describing the newuser.
      
          www/user_defs.php - Factor the xml-making part of NewNewUser into NewNewUserXML.
      
          www/project_defs.php - Remove the required $leader arg of NewNewProject.
              newproj may call newuser, which may generate the leader uid.
      
          backend/newproj.in - Call newuser with an optional 'newuser_xml' XML file.
      
          sql/database-fill.sql - Add 'projects','newuser_xml'.
      2f373d5b
  30. 24 Oct, 2007 1 commit
  31. 12 Jun, 2007 1 commit
  32. 16 May, 2007 1 commit
  33. 25 Apr, 2007 1 commit
  34. 17 Apr, 2007 1 commit
  35. 30 Mar, 2007 1 commit
  36. 14 Feb, 2007 1 commit
  37. 13 Feb, 2007 1 commit
  38. 12 Feb, 2007 1 commit
    • Leigh Stoller's avatar
      * Replace the argument processing code in all pages. Currently we rely on · 48acc8e3
      Leigh Stoller authored
        register_globals=1 to turn POST/GET/COOKIES arguments in local variables.
        This is known to be a terrible security risk, and we keep saying we are
        going to fix it, and now I am. In order to accomplish this on a
        transitional basis (since I don't want the entire web interface to stop
        working while I debug it), and because the code just needs the cleanup, I
        am doing it like this: Each page will sport new declarations at the top:
      
      	RequiredPageArguments("experiment", PAGEARG_EXPERIMENT,
                                    "template",   PAGEARG_TEMPLATE,
                                    "instance",   PAGEARG_INSTANCE,
                                    "metadata",   PAGEARG_METADATA,
                                    "osinfo",     PAGEARG_OSINFO,
                                    "image",      PAGEARG_IMAGE,
                                    "project",    PAGEARG_PROJECT,
                                    "group",      PAGEARG_GROUP,
                                    "user",       PAGEARG_USER,
      			      "node",       PAGEARG_NODE,
      			      "yesno",      PAGEARG_BOOLEAN,
      			      "message",    PAGEARG_STRING,
      			      "age",        PAGEARG_INTEGER,
                                    "cost",       PAGEARG_NUMERIC,
                                    "formfields", PAGEARG_ARRAY,
                                    "unknown",    PAGEARG_ANYTHING);
      
      	OptionalPageArguments("canceled", PAGEARG_BOOLEAN);
      
        The first token in each pair is the name of the global variable to
        set, and the second token is the type. So, for "experiment" we look at
        the URL for a pid/eid or exptidx, etc, sanity check them (safe for a
        DB query), and then try to find that experiment in the DB. If it maps
        to an experiment, set global variable $experiment to the object. Since
        its a required argument, produce an error if not supplied. Similar
        treatment for optional arguments, with the obvious difference.
      
        The goal is to have ALL argument processing in one place, consistent,
        and correct. I've found numerous places where we leak unchecked
        arguments into queries. It also cuts out a lot of duplicated code.
      
      * To make the above easier to deal with, I've been replacing lots of
        hardcoded URLS in the code of the form:
      
      	foo.php3?pid=$pid&eid=$eid ...
      
        with
      
              CreateURL("foo", $experiment)
      
        which creates and returns the neccessary url string, by looking at
        the type of its arguments (experiment, template, instance, etc.)
      
        Eventually plan to replace them all so that URL handling throughout
        the code is all defined in one place (all the new URL code is in
        url_defs.php).
      
      * I have cranked up error reporting to tell me anytime a variable is
        used before it is initialized, plus a bunch of other stuff that PHP
        deems improper. Think of it like -Wall ... and boy we get a lot of
        warnings.  A very large percentage of the diffs are to fix all these
        warnings.
      
        The warnings are currently going to /usr/testbed/log/php-errors.log,
        and I'll be adding a script to capture them each night and mail them
        to tbops. This file also gets errors (this will be a change for
        developers; rather then seeing errors and warnings dumped in the
        middle of web pages, they will go to this file instead).
      
      * Major refactoring of the code. More objects (nodes, images, osids).
        Moving tons of queries into the objects in the hopes of someday
        getting to a point where we can split the web interface onto a
        different server.  Lots of general cleanup.
      48acc8e3
  39. 23 Jan, 2007 1 commit