1. 06 May, 2016 1 commit
  2. 24 Sep, 2012 1 commit
    • Eric Eide's avatar
      Replace license symbols with {{{ }}}-enclosed license blocks. · 6df609a9
      Eric Eide authored
      This commit is intended to makes the license status of Emulab and
      ProtoGENI source files more clear.  It replaces license symbols like
      "EMULAB-COPYRIGHT" and "GENIPUBLIC-COPYRIGHT" with {{{ }}}-delimited
      blocks that contain actual license statements.
      
      This change was driven by the fact that today, most people acquire and
      track Emulab and ProtoGENI sources via git.
      
      Before the Emulab source code was kept in git, the Flux Research Group
      at the University of Utah would roll distributions by making tar
      files.  As part of that process, the Flux Group would replace the
      license symbols in the source files with actual license statements.
      
      When the Flux Group moved to git, people outside of the group started
      to see the source files with the "unexpanded" symbols.  This meant
      that people acquired source files without actual license statements in
      them.  All the relevant files had Utah *copyright* statements in them,
      but without the expanded *license* statements, the licensing status of
      the source files was unclear.
      
      This commit is intended to clear up that confusion.
      
      Most Utah-copyrighted files in the Emulab source tree are distributed
      under the terms of the Affero GNU General Public License, version 3
      (AGPLv3).
      
      Most Utah-copyrighted files related to ProtoGENI are distributed under
      the terms of the GENI Public License, which is a BSD-like open-source
      license.
      
      Some Utah-copyrighted files in the Emulab source tree are distributed
      under the terms of the GNU Lesser General Public License, version 2.1
      (LGPL).
      6df609a9
  3. 30 Aug, 2011 1 commit
  4. 03 Dec, 2009 1 commit
  5. 12 Feb, 2007 2 commits
    • Leigh Stoller's avatar
      Minor bug fix. · 6d2eab56
      Leigh Stoller authored
      6d2eab56
    • Leigh Stoller's avatar
      * Replace the argument processing code in all pages. Currently we rely on · 48acc8e3
      Leigh Stoller authored
        register_globals=1 to turn POST/GET/COOKIES arguments in local variables.
        This is known to be a terrible security risk, and we keep saying we are
        going to fix it, and now I am. In order to accomplish this on a
        transitional basis (since I don't want the entire web interface to stop
        working while I debug it), and because the code just needs the cleanup, I
        am doing it like this: Each page will sport new declarations at the top:
      
      	RequiredPageArguments("experiment", PAGEARG_EXPERIMENT,
                                    "template",   PAGEARG_TEMPLATE,
                                    "instance",   PAGEARG_INSTANCE,
                                    "metadata",   PAGEARG_METADATA,
                                    "osinfo",     PAGEARG_OSINFO,
                                    "image",      PAGEARG_IMAGE,
                                    "project",    PAGEARG_PROJECT,
                                    "group",      PAGEARG_GROUP,
                                    "user",       PAGEARG_USER,
      			      "node",       PAGEARG_NODE,
      			      "yesno",      PAGEARG_BOOLEAN,
      			      "message",    PAGEARG_STRING,
      			      "age",        PAGEARG_INTEGER,
                                    "cost",       PAGEARG_NUMERIC,
                                    "formfields", PAGEARG_ARRAY,
                                    "unknown",    PAGEARG_ANYTHING);
      
      	OptionalPageArguments("canceled", PAGEARG_BOOLEAN);
      
        The first token in each pair is the name of the global variable to
        set, and the second token is the type. So, for "experiment" we look at
        the URL for a pid/eid or exptidx, etc, sanity check them (safe for a
        DB query), and then try to find that experiment in the DB. If it maps
        to an experiment, set global variable $experiment to the object. Since
        its a required argument, produce an error if not supplied. Similar
        treatment for optional arguments, with the obvious difference.
      
        The goal is to have ALL argument processing in one place, consistent,
        and correct. I've found numerous places where we leak unchecked
        arguments into queries. It also cuts out a lot of duplicated code.
      
      * To make the above easier to deal with, I've been replacing lots of
        hardcoded URLS in the code of the form:
      
      	foo.php3?pid=$pid&eid=$eid ...
      
        with
      
              CreateURL("foo", $experiment)
      
        which creates and returns the neccessary url string, by looking at
        the type of its arguments (experiment, template, instance, etc.)
      
        Eventually plan to replace them all so that URL handling throughout
        the code is all defined in one place (all the new URL code is in
        url_defs.php).
      
      * I have cranked up error reporting to tell me anytime a variable is
        used before it is initialized, plus a bunch of other stuff that PHP
        deems improper. Think of it like -Wall ... and boy we get a lot of
        warnings.  A very large percentage of the diffs are to fix all these
        warnings.
      
        The warnings are currently going to /usr/testbed/log/php-errors.log,
        and I'll be adding a script to capture them each night and mail them
        to tbops. This file also gets errors (this will be a change for
        developers; rather then seeing errors and warnings dumped in the
        middle of web pages, they will go to this file instead).
      
      * Major refactoring of the code. More objects (nodes, images, osids).
        Moving tons of queries into the objects in the hopes of someday
        getting to a point where we can split the web interface onto a
        different server.  Lots of general cleanup.
      48acc8e3
  6. 20 Dec, 2006 1 commit
  7. 04 Jan, 2006 2 commits
  8. 02 Jan, 2006 2 commits
  9. 30 Dec, 2005 2 commits
  10. 31 Oct, 2005 1 commit
  11. 26 May, 2005 1 commit
    • Leigh Stoller's avatar
      In addition to the giant commit log file (which is really getting big), · 5afef257
      Leigh Stoller authored
      generate month by month files, and then a little index to include into the
      php script.
      
      I know, this is really important stuff! But, I was reminded to do this by a
      message that Christopher Johnson (the young one) sent on April 29th about
      his project. His code was quaint, but I did not think we needed a new
      python script when it was much easier just to roll it into the existing
      perl script that imports the commitlog.
      5afef257
  12. 05 May, 2005 1 commit
  13. 09 Nov, 2004 1 commit
  14. 22 Apr, 2004 1 commit
  15. 04 Apr, 2003 2 commits
    • Chad Barb's avatar
      · aaba6d77
      Chad Barb authored
      Fixed a few minor things:
      
        - Fixed so editing a message doesn't set its author as you.
      
        - Moved buttons above message body, to enable editing of
          message if it is messed up (since the message can contain
          arbitrary HTML which is served verbatim, and might be
          so bad as to render the edit button useless.)
      
        - Added quote sentinel  ("<!-- ' \" > message >")
          between messages so attributes without
          closing quotes don't screw up the page as bad;
          when rendered, message is shown which indicates
          an endquote is missing.
      aaba6d77
    • Leigh Stoller's avatar
      Install doc/ChangeLog into www dir as ChangeLog.txt for inclusion into · 268f9fde
      Leigh Stoller authored
      the news page. Better than trying to keep Changelog.html in sync.
      Change docwrapper.php3 to treat .txt files as special so that they are
      readable.
      268f9fde
  16. 03 Apr, 2003 1 commit
    • Chad Barb's avatar
      · fbf11432
      Chad Barb authored
      New 'blog-like news system.
      Should make it easier to keep up with news updates!
      Since:
        1. Doesn't require editing news.html in the CVS tree and
           recopying it/reinstalling just to add a news item.
        2. Doesn't involve editing menu.php3,
           since the modified date and "new" icon is automatic now.
        3. Looks nicer.
      
      Also, it is based off the db, so other sites can have other news,
      which they can maintain independently.
      
      There are of course, neat features that have been suggested that
      could go with this, such as message updates and automatic
      mailing list mailings of news, but those don't exist yet...
      fbf11432