1. 06 Nov, 2013 1 commit
  2. 24 Sep, 2012 1 commit
    • Eric Eide's avatar
      Replace license symbols with {{{ }}}-enclosed license blocks. · 6df609a9
      Eric Eide authored
      This commit is intended to makes the license status of Emulab and
      ProtoGENI source files more clear.  It replaces license symbols like
      "EMULAB-COPYRIGHT" and "GENIPUBLIC-COPYRIGHT" with {{{ }}}-delimited
      blocks that contain actual license statements.
      
      This change was driven by the fact that today, most people acquire and
      track Emulab and ProtoGENI sources via git.
      
      Before the Emulab source code was kept in git, the Flux Research Group
      at the University of Utah would roll distributions by making tar
      files.  As part of that process, the Flux Group would replace the
      license symbols in the source files with actual license statements.
      
      When the Flux Group moved to git, people outside of the group started
      to see the source files with the "unexpanded" symbols.  This meant
      that people acquired source files without actual license statements in
      them.  All the relevant files had Utah *copyright* statements in them,
      but without the expanded *license* statements, the licensing status of
      the source files was unclear.
      
      This commit is intended to clear up that confusion.
      
      Most Utah-copyrighted files in the Emulab source tree are distributed
      under the terms of the Affero GNU General Public License, version 3
      (AGPLv3).
      
      Most Utah-copyrighted files related to ProtoGENI are distributed under
      the terms of the GENI Public License, which is a BSD-like open-source
      license.
      
      Some Utah-copyrighted files in the Emulab source tree are distributed
      under the terms of the GNU Lesser General Public License, version 2.1
      (LGPL).
      6df609a9
  3. 10 Aug, 2012 1 commit
  4. 22 Jun, 2010 1 commit
  5. 21 Oct, 2008 1 commit
    • Kevin Atkinson's avatar
      If a known user (based on stored cookies) is not logged in than · 846a98d6
      Kevin Atkinson authored
      redirect to the login page rather than printing a message with a link
      to the page.  Otherwise send a "403 Forbidden" to keep robots from
      indexing the page.  Also send appreciate HTTP responses on other
      precheck errors to keep a robot from indexing the page.  In order to
      do this the PAGEHEADER call needed to be moved to after
      CheckLoginOrDie and Required/OptionalPageArguments on many pages.  A
      warning will be printed if either CheckLoginOrDie or
      Required/OptionalPageArguments detects that PAGEHEADER was already
      called.
      
      Also change the redirect in kb-show to be a permanent redirect (301)
      rather than a temporary one (302) which is the default unless a status
      code is given.
      846a98d6
  6. 18 Jul, 2008 1 commit
  7. 12 Feb, 2007 1 commit
    • Leigh Stoller's avatar
      * Replace the argument processing code in all pages. Currently we rely on · 48acc8e3
      Leigh Stoller authored
        register_globals=1 to turn POST/GET/COOKIES arguments in local variables.
        This is known to be a terrible security risk, and we keep saying we are
        going to fix it, and now I am. In order to accomplish this on a
        transitional basis (since I don't want the entire web interface to stop
        working while I debug it), and because the code just needs the cleanup, I
        am doing it like this: Each page will sport new declarations at the top:
      
      	RequiredPageArguments("experiment", PAGEARG_EXPERIMENT,
                                    "template",   PAGEARG_TEMPLATE,
                                    "instance",   PAGEARG_INSTANCE,
                                    "metadata",   PAGEARG_METADATA,
                                    "osinfo",     PAGEARG_OSINFO,
                                    "image",      PAGEARG_IMAGE,
                                    "project",    PAGEARG_PROJECT,
                                    "group",      PAGEARG_GROUP,
                                    "user",       PAGEARG_USER,
      			      "node",       PAGEARG_NODE,
      			      "yesno",      PAGEARG_BOOLEAN,
      			      "message",    PAGEARG_STRING,
      			      "age",        PAGEARG_INTEGER,
                                    "cost",       PAGEARG_NUMERIC,
                                    "formfields", PAGEARG_ARRAY,
                                    "unknown",    PAGEARG_ANYTHING);
      
      	OptionalPageArguments("canceled", PAGEARG_BOOLEAN);
      
        The first token in each pair is the name of the global variable to
        set, and the second token is the type. So, for "experiment" we look at
        the URL for a pid/eid or exptidx, etc, sanity check them (safe for a
        DB query), and then try to find that experiment in the DB. If it maps
        to an experiment, set global variable $experiment to the object. Since
        its a required argument, produce an error if not supplied. Similar
        treatment for optional arguments, with the obvious difference.
      
        The goal is to have ALL argument processing in one place, consistent,
        and correct. I've found numerous places where we leak unchecked
        arguments into queries. It also cuts out a lot of duplicated code.
      
      * To make the above easier to deal with, I've been replacing lots of
        hardcoded URLS in the code of the form:
      
      	foo.php3?pid=$pid&eid=$eid ...
      
        with
      
              CreateURL("foo", $experiment)
      
        which creates and returns the neccessary url string, by looking at
        the type of its arguments (experiment, template, instance, etc.)
      
        Eventually plan to replace them all so that URL handling throughout
        the code is all defined in one place (all the new URL code is in
        url_defs.php).
      
      * I have cranked up error reporting to tell me anytime a variable is
        used before it is initialized, plus a bunch of other stuff that PHP
        deems improper. Think of it like -Wall ... and boy we get a lot of
        warnings.  A very large percentage of the diffs are to fix all these
        warnings.
      
        The warnings are currently going to /usr/testbed/log/php-errors.log,
        and I'll be adding a script to capture them each night and mail them
        to tbops. This file also gets errors (this will be a change for
        developers; rather then seeing errors and warnings dumped in the
        middle of web pages, they will go to this file instead).
      
      * Major refactoring of the code. More objects (nodes, images, osids).
        Moving tons of queries into the objects in the hopes of someday
        getting to a point where we can split the web interface onto a
        different server.  Lots of general cleanup.
      48acc8e3
  8. 20 Dec, 2006 1 commit
  9. 01 Dec, 2006 1 commit
  10. 12 Feb, 2004 1 commit
    • Leigh Stoller's avatar
      Make the new version of beginexp_xml live now that its been through · f014e8b0
      Leigh Stoller authored
      the paper effort for everyone. I've redirected everything to
      beginexp_html.php3 (the front end to the XML version), including the
      plab and bui pages.
      
      I've stuck a redirect in the old beginexp.php3, to make it easy to
      bring back the old version in case something goes wrong. Just comment
      out the lines at the top and reinstall, along with changing the other
      links to it.
      f014e8b0
  11. 17 Sep, 2003 2 commits
  12. 06 Jun, 2003 1 commit
    • Chad Barb's avatar
      · 2fad09a4
      Chad Barb authored
      NetBuild modify. Woot.
      
      Available only to admins for now.
      
      Link is available off "modify experiment page" in admin mode.
      2fad09a4
  13. 17 Mar, 2003 1 commit
    • Chad Barb's avatar
      · 38f0bb77
      Chad Barb authored
      "Version 1.02";
      Fixed selection box drawing (was leaving 1 pixel of white on
      bottomright side.)
      
      Added ability to put '.' in all special-character-allowed places
      (e.g., OSID, for Tim.)
      
      Changed LAN Link behavior; now bw/delay/loss settings default to <auto>,
      which means "inherit from LAN".
      lan-node params are only spit out if any of those differ from the LAN.
      38f0bb77
  14. 19 Sep, 2002 1 commit
  15. 13 Sep, 2002 1 commit
  16. 12 Sep, 2002 2 commits
    • Chad Barb's avatar
      · 97b65788
      Chad Barb authored
      Minor bugfix to make sure guids are always positive
      (so regexp in php doesn't reject it.)
      97b65788
    • Chad Barb's avatar
      · acbd1169
      Chad Barb authored
      Changed /tmp file saving to be based on a randomly generated number,
      not UID. This way, POSTing NSFiles from netbuild doesnt require being logged
      in (since Macs dont seem to want to send the appropriate login cookies
      along for the Java POST.) This should fix the Mac OS X problem.
      
      Maintained backward compatability with old methods.
      acbd1169
  17. 21 Aug, 2002 1 commit
  18. 16 Aug, 2002 1 commit
    • Chad Barb's avatar
      · 60529980
      Chad Barb authored
      The big one.
      
      New look;
      most of the changes are in menu.php3.
      
      A lot of the changes in other files are s/<TD>/<TH>/
      for table headers.
      
      Also closed some tags, tweaked some table styles, etc..
      
      No actual functionality should have changed.
      
      Will be installing soon...
      60529980
  19. 13 Aug, 2002 1 commit
  20. 08 Aug, 2002 1 commit
    • Chad Barb's avatar
      · fe0cbef7
      Chad Barb authored
      Fixed "double image" problem in Mozilla.
      (this was due to a difference in behavior between Moz and IE/NS47 render
       behavior.)
      
      Back to porting.. Err, uhmm.. not porting Java..
      fe0cbef7
  21. 15 Jul, 2002 1 commit
  22. 11 Jul, 2002 1 commit
  23. 07 Jul, 2002 1 commit
  24. 13 Jun, 2002 1 commit
    • Chad Barb's avatar
      · d3ef76bc
      Chad Barb authored
      Changed netbuild to use POST, rather than GET.
      This should alleviate some of the truncation problems we've been having, and
      also is a bit cleaner looking to the client.
      
      The applet posts to nssave.php3, which writes the ns file to /tmp/$uid-$hash.nsfile
      The applet then launches beginexp/php3 in a new browser window, passing it the $hash.
      It can then pass that $hash to spitnsdata.php3, or build "/tmp/$uid-$hash.nsfile"
      as $nsfile (the NS file to use in expt creation.)
      
      There are, as of yet, no file size restrictions, nor is there a mechanism to clean up
      old nsfiles (which really only need to stick around for a short while, <<1hr.)
      d3ef76bc
  25. 10 Jun, 2002 2 commits
  26. 22 May, 2002 1 commit
    • Chad Barb's avatar
      · fb8a2fce
      Chad Barb authored
      Now, due to changes in the parser, lans must have $'s before the name of each node.
      (shashi says this is the proper ns syntax) Changed java code to do this.
      fb8a2fce
  27. 08 Mar, 2002 1 commit
  28. 06 Mar, 2002 2 commits
    • Chad Barb's avatar
      08224586
    • Chad Barb's avatar
      · 3ad6a28a
      Chad Barb authored
       A couple of UI fixups:
      
       - Added "you're over the trashcan" visual clue when dragging thingees into the can.
       - Clicking a node to drag it from the panel now visually selects it
         (this is subtle, but more correct.)
      3ad6a28a
  29. 04 Mar, 2002 2 commits
  30. 22 Feb, 2002 1 commit
  31. 21 Feb, 2002 1 commit
  32. 19 Feb, 2002 1 commit
  33. 14 Feb, 2002 1 commit
  34. 13 Feb, 2002 2 commits