1. 04 Apr, 2003 1 commit
    • Leigh Stoller's avatar
      Add "Address Line 2", City, State, and Zip as independent entities, · 5e38412f
      Leigh Stoller authored
      finally! These have been in the DB for a long time, but never used.
      As Eric pointed out, its easier to get realistic address info from
      people if we provide the right forms. The downside is that all current
      users will have to adjust their info the next time they edit their
      info. Thats okay. I thought about forcing all users to do it the next
      time they log in, but I figured people would scream.
      5e38412f
  2. 25 Mar, 2003 1 commit
    • Chad Barb's avatar
      · f3d05157
      Chad Barb authored
         - Performing an approval action (postpone/approve/deny/nuke) on a
           user in a subgroup results in an implicit version of that same
           approval action on the user in the
           default group (for approve, $trust='user'.)
      
         - Tidied up a table in approveuser_form.php3,
           but form is otherwise unchanged.
      f3d05157
  3. 13 Mar, 2003 1 commit
    • Chad Barb's avatar
      · c6129ad7
      Chad Barb authored
      More rework on the groups system.
      
      * BESTOWGROUPROOT permission added to dbdefs.
      
      * Permissions criteria for group operations changed in dbdefs
        (consult code for full explanation.)
      
      * Approveuser and Editgroup now check for BESTOWGROUPROOT
        permissions before allowing changes to group_root.
      
      * approveuser_form and editgroup_form do not show "Group Root"
        as an option unless you are allowed to set it (or it is already set.)
      
      * editgroup does not UPDATE rows where trust has not been changed.
      
      * showgroup does a correct check to see whether to show the
        "group options" subpage.
      c6129ad7
  4. 12 Mar, 2003 1 commit
    • Chad Barb's avatar
      · 24940013
      Chad Barb authored
      * Altered consistency checks to treat any root as equivalent
        (so, if you're project_root in the default group, but group_root in
         a group, that won't be a problem)
      
      * Moved consistency checks, which were done in two different places into
        dbdefs TBCheckGroupTrustConsistency()
      
      * Added preemptive checks, so if 'user' or '*_root' are not valid
        trusts, they aren't displayed as options in editgroup_form and
        approveuser_form (using above function)
      
      * In approveuser, a new approval may now be sent to group_root.
      24940013
  5. 06 Feb, 2003 1 commit
  6. 23 Dec, 2002 1 commit
  7. 16 Aug, 2002 1 commit
    • Chad Barb's avatar
      · 60529980
      Chad Barb authored
      The big one.
      
      New look;
      most of the changes are in menu.php3.
      
      A lot of the changes in other files are s/<TD>/<TH>/
      for table headers.
      
      Also closed some tags, tweaked some table styles, etc..
      
      No actual functionality should have changed.
      
      Will be installing soon...
      60529980
  8. 07 Jul, 2002 1 commit
  9. 01 Jul, 2002 1 commit
  10. 22 May, 2002 1 commit
    • Leigh Stoller's avatar
      A large set of authorization changes. · d2360b6d
      Leigh Stoller authored
      * Cleanup! A lot of the structure derived from the early frame days,
        which had a noticable (and bad) effect on how I wrote the stuff.  I
        cleaned up most of that yuckyness.
      
      * In process, optimize a little bit on the queries. The old code did
        about 9 queries just to write out the menu options, and then
        repeated most of those queries again in the page guts. I've
        consolidated the queries as much as possible (to 3) and cache all
        the results.
      
      * Fix up problem with users who forget their passwords before
        verification. Basically, I fixed the more general problem of not
        being able to update your user info before verification/approval;
        users now get that menu option no matter their status.
      
      * Fix up problem of users being able to access pages before
        verification (but after approval) by going around the menu options.
        The page level check (after the menu is drawn) now checks all
        conditions (password expired, unverified, unapproved, timedout, and
        also nologins()).
      
      * Minor change in approveuser; do not show the new account to the
        project leader until the new user has verified his account.
      
      * Change verification method, as reqwuested by Dave.  In addition to
        providing the key, also provide a web link to take the user straight
        to verification. I actually take them direct to the login page, and
        pass the key in as an argument. If the user is already logged in,
        bypass and go directly to the verify page (not the form page of
        course).  If the user is not logged in, let him log in, and then
        forward the key onward to the verify page. Basically, bypass the
        form all the time, and just do the verification.
      
      * Minor change in showuser; Do not show pid/groups not approved in,
        and if the count is zero, do not draw the table headings.
      d2360b6d
  11. 13 Apr, 2002 1 commit
  12. 20 Dec, 2001 1 commit
    • Leigh Stoller's avatar
      And finally, all those groups changes I've been whining and yammering · c13d27c3
      Leigh Stoller authored
      and complaining about this week.
      
      1. editgroup: You can now edit the trust levels for existing group
         members (default group too), and you can specify trust levels when
         adding users to subgroups.
      
      2. approveusers: When approving users in the approval page, you can
         specify different levels of trust. Before, I invisibly set all the
         trust values the same. I also added some ordering to the DB query
         to group users together.
      
      3. I added a great deal of error checking to the processing pages for
         both forms. I split things up into a pre/post pass. The prepass
         goes through all of the form args and checks them for consistency
         and correctness. Nothing is changed in the DB unless all checks
         pass for all args. Then I do a second pass and make the changes.
         Both scripts set the ignore_user_abort() flag to prevent the user
         from stopping the script and causing a DB inconsistency.
      
      4. Added trust consistency checks as well. Rather than allow the
         project or group leader to set inconsistent trust levels, I look
         for those and just plain disallow them. You may not give different
         trust levels in different subgroups of the *same* project, and you
         may not give a user a higher trust level in the default group than
         in the subgroups. Both edit and approve make these checks, and the
         code is absolutely awful.
      c13d27c3
  13. 16 Oct, 2001 1 commit
  14. 05 Sep, 2001 1 commit
  15. 19 Jul, 2001 1 commit
    • Leigh Stoller's avatar
      Address Pats comments in email to testbed-ops: · 1728fe2b
      Leigh Stoller authored
          From: "Patrick Tullmann 'tullmann'" <tullmann@cs.utah.edu>
          Subject: Re: TESTBED: aclement janos Project Join Request
      
          First the reply-to: address for approval mails should be
          testbed-ops@fast (right?).
      
          Second, Austin isn't listed on my testbed user approval page.  I
          assume Mike or a testbed person approved him (which is good because
          who knows when I'd get around to it. :)
      
          An option like "remove" or "ignore" or something like that for just
          nuking requests without a reply would be useful (I've got some guy
          from yahoo.com who wants to join Janos).
      
          Also, the date of the join request would be nice to know (e.g., for
          the above, I think he tried joining 4 or 5 months ago).
      
          he documentation above the table is out of synch with the pull-down
          boxes.
      1728fe2b
  16. 08 Dec, 2000 1 commit
  17. 15 Nov, 2000 1 commit
  18. 06 Nov, 2000 2 commits