GitLab

For now I'm adding this as a separate file, wherein I have renamed the
base procurve module as "snmpit_hpupd" until we have more time to test the
integration.  I did a fairly quick-and-dirty port of this code to work
with modern Emulab snmpit.

The comware module will be used for switches with "comware" in their
'type' string.

Perl's SNMP library returns no error, but sets the return value to
"NOSUCHOBJECT" when an invalid OID is queried.  That must have changed
at some point after the test in snmpit_hp was written. So, compensate.

If the snmpit_use_jumbo boolean attribute is set to '1' then the module
will enable jumbo frames for all created vlans.  The value in
'node_attributes', if it exists, overrides the value in
'node_type_attributes' (if it exists).  The default if neither exists
is '0', or 'disabled'.

This commit pushes the changes located in the temporary snmpit_portfix
subdirectory into the mainline snmpit_test directory, and updates
db/Ports.pm with the 'portfix' changes.  These changes ensure better
consistency with port lookup/resolution.  In particular, interswitch
trunk lookup will return the switch-local side of the link.

This commit also adds an installer script to cleanup the temporary files
introduced for burning in the snmpit_portfix changes.

In order to test the portfix changes to snmpit, a new version of
the tool and its modules has been split off here.  This new version
will be selected via a site variable / emulab feature.  This also
reverts changes to the mainline Ports module and snmpit modules
in the snmpit_test subdirectory.  The modified Port module will
go by the name of Ports_portfix.pm, and will ultimately disappear
once these changes have been vetted at the Utah Emulab site.

The lookup functions now look at the wire type and which location the
requested node is in (node_id1 or node_id2) to decide which side of the
link the port represents (switch vs. endpoint).  We don't (yet) query the
nodes table for the role since we consistently use the node_id1 (and
related) columns to hold the endpoint (node) information for wires of
type "Node".

For inter-switch
trunks, we always mark the port object as being the "switch" side.  Both
sides are the switch side...  Functions like getPCPort() and getSwitchPort()
are ambiguous when invoked on a switch port object, and will always return
a reference to the object the method was invoked on.

Also update the HP snmpit module to explicitly check the wire type for a port
before deciding whether or not to get the port at the other end in the
listVlans() function.

Run as follows:

boss> wap perl snmpit_test --prunestalevlans --impotent

which will tell you about them. Remove the --impotent option to
actually remove them.

Only numbered lans are considered; ones that derive from entries in
the lans table. Named vlans are skipped since those are generally
created by hand (often via the switch CLI).

Caveat; vlans left on trunk links are still a bit of problem since
listvlans returns the other side of the trunk. Needs to be fixed.

I was there, I changed the callers of convertPortFormat to actually
look at the return value, and stop if it gets back no results!

pool with -X (sync). This is a case where the last vlan is removed
from a port, but not allowed to do that on a procurve. It has to be
added to vlan 1 first, and then the other removed. But the port is in
"dual" mode tagging, and because of the way that is implemented in
snmpit_hp, it was failing. The port has to be converted to equal
tagging first, then vlan 1 added, and then finally the actual vlan
removed.

Caveat; once we do this the port is in equal mode, and if were to add
a tagged vlan back to it, we would not be operating as before. But
this is not a use case we currently have.

This commit is intended to makes the license status of Emulab and
ProtoGENI source files more clear.  It replaces license symbols like
"EMULAB-COPYRIGHT" and "GENIPUBLIC-COPYRIGHT" with {{{ }}}-delimited
blocks that contain actual license statements.

This change was driven by the fact that today, most people acquire and
track Emulab and ProtoGENI sources via git.

Before the Emulab source code was kept in git, the Flux Research Group
at the University of Utah would roll distributions by making tar
files.  As part of that process, the Flux Group would replace the
license symbols in the source files with actual license statements.

When the Flux Group moved to git, people outside of the group started
to see the source files with the "unexpanded" symbols.  This meant
that people acquired source files without actual license statements in
them.  All the relevant files had Utah *copyright* statements in them,
but without the expanded *license* state...

last vlan since on a procurve, a port has to be in *some* vlan.
So, when down to the last one, add it to the default vlan and
then do the removal. This comes up in syncVlansFromTables only.

addresses on HP switches, including ones which have both control and
Experiment ports.

If the change to a dual-mode trunk port involves the "native vlan",
make sure we don't make it a tagged vlan like we do any other VLANs.

attempting the Port merge again. There is no git "fork" so we end up
losing history, but so be it.

Sorry, not the git way, but the git way is baffling, considering I
wanted to undo all of the merges from my portmerge branch, and apply
them on a branch.

Mail follows:

From: Keith Sklower <sklower@vangogh.CS.Berkeley.EDU>
To: ricci@flux.utah.edu
Subject: bug in snmpit_hp.pm
Date: Sat, 6 Nov 2010 13:15:46 -0700 (PDT)

There are two extra characters in snmpit_hp.pm that shouldn't be there.

For some reason, it doesn't seem to matter to older firmware running
on our 5412s that I wanted to do something with a non-existant port,
but a lowly 1U 2810 that we were testing out as a control switch
threw a hissy-fit.

These *should* be fixed versions of the modules committed earlier
in commit efdf34a0

This reverts commit efdf34a0.

Attempt to solve some problems with trunk creation by reverting
this change. It's not *certain* that this change is at fault, but
I want to factor out some possible causes

These are mostly code cleanup, in preparation for some larger frontend
changes that will come soon. Also gives an option for the Nortel
to be configured through the CLI rather than SNMP, which Keith says
is much, much faster on it.

output is flushed to the terminal.

fix-bug: in snmpit_hp.pm:getUsedOpenflowListenerPorts the port may be uninitialized if the listener string is empty. fix-bug: in snmpit.in:doEnableOpenflowListener Openflow listener output is printed out no matter whether the stacks support Openflow or not.

to keep in mind the possible change of the OF listener OID.

getUsedOpenflowListenerPorts in snmpit stack modules and devices are changed to return the ports rather than accept a hash reference. Add the empty OF functions to snmpit_nortel.pm. Print the OF listener string on each involved device. Fix a bug that snmpit.in doesnot print Done when OF operations are finished. The lengths of OF usage lines are reduced to fit the 80-ch width window.

fix bug: in snmpit_hp module, the SNMP session with MIB returns the OID as strings not numbers even for Openflow entry, however, the meaningful string OID cannot be used to get the next entry in MIB table! So getUsedOpenflowListenerPorts has to modify the OID of the current entry to be the numbered format.

Use a var instead of magic string in snmpit_hp to test OF listener var name. Add Openflow to OF related functions in snmpit HP module.

Add getUsedListenerPorts in HP snmpit module, it gives the used ports of existing listeners. This function is for automatic listener port assigning.

Openflow OIDs can be used in snmpit_hp now, so the functions can act correctly. Command line options configuration is changed to use only one vlanname for each OF command. The order of OF support checking and finding VLan is changed so that stack module will find vlan first, then check OF support. Thus there will not be an error msg for OF unsupported even if the vlan is not on the switch.

Openflow command line options are modified to have pid and eid so that stacks can be found according to experiment. snmpit.in has been modified to support multiple stacks.