From d5aa312979be3244712ab6b14830fbd2db8d3f97 Mon Sep 17 00:00:00 2001
From: "Leigh B. Stoller" <stoller@flux.utah.edu>
Date: Wed, 10 Apr 2002 21:53:43 +0000
Subject: [PATCH] log (more informative) error when authentication fails for
 mysterious reasons, as happens when Dave's autostatus daemon connects and
 closes right away.

---
 tmcd/ssl.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/tmcd/ssl.c b/tmcd/ssl.c
index 3c72e14fa..616c0c711 100644
--- a/tmcd/ssl.c
+++ b/tmcd/ssl.c
@@ -207,7 +207,7 @@ tmcd_sslaccept(int sock, struct sockaddr *addr, socklen_t *addrlen)
 		error("sslaccept: reading request");
 		if (cc == 0)
 			errno = EIO;
-		return -1;
+		goto badauth;
 	}
 	if (strncmp(nosslbuf, SPEAKSSL, strlen(SPEAKSSL))) {
 		/*
@@ -225,20 +225,25 @@ tmcd_sslaccept(int sock, struct sockaddr *addr, socklen_t *addrlen)
 	if (! (ssl = SSL_new(ctx))) {
 		tmcd_sslerror();
 		errno = EIO;
-		return -1;
+		goto badauth;
 	}
 	if (! SSL_set_fd(ssl, newsock)) {
 		tmcd_sslerror();
 		errno = EIO;
-		return -1;
+		goto badauth;
 	}
 	if (SSL_accept(ssl) <= 0) {
 		tmcd_sslerror();
 		errno = EAUTH;
-		return -1;
+		goto badauth;
 	}
 	
 	return newsock;
+ badauth:
+	error("sslaccept: error speaking to %s\n",
+	      inet_ntoa(((struct sockaddr_in *)addr)->sin_addr));
+	tmcd_sslclose(newsock);
+	return -1;
 }
 
 /*
-- 
GitLab