Commit c9c5c049 authored by Leigh B. Stoller's avatar Leigh B. Stoller
Browse files

Dup fd 1 to 2 cause php does not capture stderr output, which is where

all the scripts send output.
Remove test for group writable directory (where program exists). Too
paranoid and too inconvenient for all of us since it would require root
installs all the time.
parent 642fb80d
......@@ -273,6 +273,14 @@ int main(int argc, char *argv[])
struct stat dir_info; /* directory info holder */
struct stat prg_info; /* program info holder */
#ifdef TESTBED
* For the Testbed, we run this from php3, and it loses all
* outout sent to stderr, so make sure it all goes to stdout.
dup2(1, 2);
* If there are a proper number of arguments, set
* all of them to variables. Otherwise, error out.
......@@ -507,7 +515,11 @@ int main(int argc, char *argv[])
* Error out if cwd is writable by others.
#ifdef TESTBED
if (dir_info.st_mode & S_IWOTH) {
if ((dir_info.st_mode & S_IWOTH) || (dir_info.st_mode & S_IWGRP)) {
log_err("error: directory is writable by others: (%s)\n", cwd);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment