Commit b5341514 authored by Robert Ricci's avatar Robert Ricci
Browse files

Fix TBExptSetThumbNail() so that it fails more gracefully if the

experiment no longer exists.
parent 3b61d244
...@@ -2792,7 +2792,8 @@ sub TBExptSetSwapUID($$$) ...@@ -2792,7 +2792,8 @@ sub TBExptSetSwapUID($$$)
# #
# Set the thumbnail for an experiment. Comes in as a binary string, which # Set the thumbnail for an experiment. Comes in as a binary string, which
# must be quoted before DB insertion. # must be quoted before DB insertion. Returns 1 if the thumbnail was
# succesfully updated, 0 if it was not.
# #
sub TBExptSetThumbNail($$$) sub TBExptSetThumbNail($$$)
{ {
...@@ -2805,12 +2806,18 @@ sub TBExptSetThumbNail($$$) ...@@ -2805,12 +2806,18 @@ sub TBExptSetThumbNail($$$)
DBQueryFatal("select rsrcidx from experiments as e ". DBQueryFatal("select rsrcidx from experiments as e ".
"left join experiment_stats as s on e.idx=s.exptidx ". "left join experiment_stats as s on e.idx=s.exptidx ".
"where e.pid='$pid' and e.eid='$eid'"); "where e.pid='$pid' and e.eid='$eid'");
if ($query_result->num_rows() != 1) {
return 0;
}
my ($rsrcidx) = $query_result->fetchrow_array(); my ($rsrcidx) = $query_result->fetchrow_array();
# Now do the insert. # Now do the insert.
return DBQueryFatal("update experiment_resources set thumbnail=$bindata ".
DBQueryFatal("update experiment_resources set thumbnail=$bindata ". "where idx=$rsrcidx");
"where idx=$rsrcidx"); #
# Since the above is a QueryFatal, if it failed, we won't even get here
#
return 1;
} }
# #
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment