diff --git a/tbsetup/eventsys_control.in b/tbsetup/eventsys_control.in index a5cd8311b7d07faf82fb06f7eb7f29eec5b801bf..5176abd246c2b299777a5219b2db6246e4c4dc33 100755 --- a/tbsetup/eventsys_control.in +++ b/tbsetup/eventsys_control.in @@ -150,7 +150,7 @@ if ($expstate ne EXPTSTATE_ACTIVE && $expstate ne EXPTSTATE_ACTIVATING && $expstate ne EXPTSTATE_MODIFY_RESWAP && $expstate ne EXPTSTATE_SWAPPING) { - tbdie("$experiment must be active (or swapping)!"); + tbdie("$experiment must be active (or swapping), not $expstate!"); } # diff --git a/tbsetup/node_update.in b/tbsetup/node_update.in index ae5075b2bfee997dcc76bffa36cf774d4758109f..6fa40e0cff747c04cc4d9226a6d4a339e8e0a1d8 100644 --- a/tbsetup/node_update.in +++ b/tbsetup/node_update.in @@ -117,7 +117,7 @@ if (! defined($experiment)) { # Check state. Only ACTIVE experiments. # if ($experiment->state() ne EXPTSTATE_ACTIVE) { - print STDERR "Experiment $pid/$eid is not ACTIVE!\n"; + print STDERR "Experiment $pid/$eid is in state $estate, not ACTIVE!\n"; # For web page. exit(1); } diff --git a/www/linktest.php3 b/www/linktest.php3 index 33d9d849e17c68e438e38d78f5b7d743011232d6..bd5900e8c1d8de8992f881b259e5ea01865d7241 100644 --- a/www/linktest.php3 +++ b/www/linktest.php3 @@ -61,10 +61,12 @@ function CHECKPAGEARGS() { USERERROR("You do not have permission to start/stop linktest ". "on $pid/$eid!", 1); } - if ($experiment->state() != $TB_EXPTSTATE_ACTIVE && - $experiment->state() != $TB_EXPTSTATE_ACTIVATING && - $experiment->state() != $TB_EXPTSTATE_MODIFY_RESWAP) { - USERERROR("Experiment $eid must be active to start/stop linktest!", 1); + $expstate = $experiment->state(); + if ($expstate != $TB_EXPTSTATE_ACTIVE && + $expstate != $TB_EXPTSTATE_ACTIVATING && + $expstate != $TB_EXPTSTATE_MODIFY_RESWAP) { + USERERROR("Experiment $eid must be active to start/stop linktest," . + " not $expstate!", 1); } $pid = $experiment->pid(); $eid = $experiment->eid(); diff --git a/www/replayexp.php3 b/www/replayexp.php3 index 58930491a12ffe47e30d4e973d396ed2a1a6b048..5f4864793be6b41d6211e5348619d1eed969b8c6 100644 --- a/www/replayexp.php3 +++ b/www/replayexp.php3 @@ -80,8 +80,20 @@ set_time_limit(0); STARTBUSY("Starting event replay"); $retval = SUEXEC($uid, "$pid,$unix_gid", "webeventsys_control replay $pid,$eid", - SUEXEC_ACTION_DIE); -STOPBUSY(); + SUEXEC_ACTION_IGNORE); +CLEARBUSY(); + +# +# Fatal Error. Report to the user, even though there is not much he can +# do with the error. Also reports to tbops. +# +if ($retval < 0) { + SUEXECERROR(SUEXEC_ACTION_DIE); + # + # Never returns ... + # + die(""); +} echo "Events for your experiment are now being replayed.\n";