From 12471e533a6cdf7f01bec0d0989cfb17829a21d1 Mon Sep 17 00:00:00 2001
From: David Johnson <johnsond@flux.utah.edu>
Date: Wed, 1 Aug 2007 14:17:06 +0000
Subject: [PATCH] Return proper error.

---
 www/plabmetrics.php3 | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/www/plabmetrics.php3 b/www/plabmetrics.php3
index cdaa6e9d9..383e0bee9 100644
--- a/www/plabmetrics.php3
+++ b/www/plabmetrics.php3
@@ -2111,6 +2111,11 @@ function pm_parseuserquery($q,$debug = false) {
     foreach ($toka as $i) {
         # echo "needs = " . implode(',',$needs) . "; ";
 	$sneed = whichsat($i,$needs);
+	if ($sneed == '') {
+	    $errstr = "Parser error at token '$i'!";
+	    break;
+	}
+	
 	$needs = $trans[$sneed];
 	if (!isset($needs)) {
 	    $needs = array();
@@ -2118,11 +2123,6 @@ function pm_parseuserquery($q,$debug = false) {
 
         # echo "sneed = $sneed; newneeds = " . implode(',',$needs) . "<br>\n";
 
-	if ($sneed == '') {
-	    $errstr = "Malformed expression at token '$i'!";
-	    break;
-	}
-	
 	if ($sneed == 'ocont') {
 	    ++$oc;
 	    $retq .= '(';
-- 
GitLab