1. 12 Oct, 2010 2 commits
  2. 11 Oct, 2010 1 commit
    • Leigh B Stoller's avatar
      Work on an optimization to the perl code. Maybe you have noticed, but · 92f83e48
      Leigh B Stoller authored
      starting any one of our scripts can take a second or two. That time is
      spent including and compiling 10000s of thousands of lines of perl
      code, both from our libraries and from the perl libraries.
      
      Mostly this is just a maintenance thing; we just never thought about
      it much and we have a lot more code these days.
      
      So I have done two things.
      
      1) I have used SelfLoader() on some of our biggest perl modules.
         SelfLoader delays compilation until code is used. This is not as
         good as AutoLoader() though, and so I did it with just a few 
         modules (the biggest ones).
      
      2) Mostly I reorganized things:
      
        a) Split libdb into an EmulabConstants module and all the rest of
           the code, which is slowly getting phased out.
      
        b) Move little things around to avoid including libdb or Experiment
           (the biggest files).
      
        c) Change "use foo" in many places to a "require foo" in the
           function that actually uses that module. This was really a big
           win cause we have dozens of cases where we would include a
           module, but use it in only one place and typically not all.
      
      Most things are now starting up in 1/3 the time. I am hoping this will
      help to reduce the load spiking we see on boss, and also help with the
      upcoming Geni tutorial (which kill boss last time).
      92f83e48
  3. 22 Mar, 2010 1 commit
    • Leigh B Stoller's avatar
      Finish up user deletion. The big visible change is that when a user is · 2965922b
      Leigh B Stoller authored
      deleted, they still remain in the user table with a status of
      "archived", but since all the queries in the system now use uid_idx
      instead of uid, it is safe to reuse a uid since they are no longer
      ambiguous. 
      
      The reason for not deleting users from the users table is so that the
      stats records can refer to the original record (who was that person
      named "mike"). This is very handy and worth the additional effort it
      has taken.
      
      There is no way to ressurect a user, but it would not be hard to add.
      2965922b
  4. 07 Dec, 2009 1 commit
    • Leigh B. Stoller's avatar
      No longer use the ssh keys in the Emulab database when the protogeni · d60b9acd
      Leigh B. Stoller authored
      user is a local user. Instead, all users have to send along their keys
      in the RedeemTicket() call, and those keys land in the new Emulab
      table called nonlocal_user_pubkeys, and tmcd will use that table when
      sending keys over local nodes.
      
      This change removes the inconsistency in key handling between slivers
      created locally and slivers created at a foreign CM.
      d60b9acd
  5. 24 Jun, 2009 1 commit
  6. 11 Jun, 2009 1 commit
  7. 27 Feb, 2009 1 commit
  8. 17 Nov, 2008 1 commit
  9. 04 Nov, 2008 1 commit
  10. 25 Sep, 2008 1 commit
  11. 03 Jun, 2008 1 commit
  12. 30 May, 2008 1 commit
  13. 13 May, 2008 1 commit
  14. 07 May, 2008 1 commit
  15. 05 May, 2008 1 commit
  16. 24 Apr, 2008 1 commit
  17. 05 Dec, 2007 1 commit
  18. 08 Nov, 2007 1 commit
    • Russ Fish's avatar
      Fix whitespace and null string handling problems. · fea90641
      Russ Fish authored
               www/beginexp_form.php3 - No initial whitespace in plab Slice Description textarea.
               sql/database-fill.sql - Use default:fulltext for 'experiments','expt_name'
                   to allow multi-line Slice Description in plab_ez->beginexp->batchexp.
               www/moduserinfo.php3 - Pass null string for optional usr_addr2 and notes fields.
               backend/moduserinfo.in - Null string attr comes from XML as an undef value.
               db/User.pm.in - Distinguish between undef and null string in ModUserInfo.
      fea90641
  19. 16 Oct, 2007 1 commit
    • Russ Fish's avatar
      Move editgroup page form logic to a backend Perl script. · 8fffc2f3
      Russ Fish authored
           www/editgroup.php3 - The reworked PHP page.
           www/editgroup_form.php3 - Removed, form merged into editgroup.php3 .
           www/showgroup.php3 - Link to editgroup.php3, rather than editgroup_form.php3 .
           www/group_defs.php - Add an Image::EditGroup class method
                                  bridging to the script via XML.
           backend/{editgroup,GNUmakefile}.in configure configure.in - New backend script.
           db/Group.pm.in - Add an EditGroup worker class method for script arg checking.
                            Also the missing NonMemberList and CheckTrustConsistency methods,
                            and a GETTRUST flag to MemberList, as in the PHP version.
           db/User.pm.in - Add the missing but tiny {Set,Get}TempData methods.
           sql/database-fill.sql - Add gid_idx to the table_regex 'groups' checking patterns.
      8fffc2f3
  20. 29 Sep, 2007 1 commit
  21. 19 Sep, 2007 1 commit
    • Russ Fish's avatar
      Move moduserinfo page form logic to a backend Perl script and methods. · 8965aad8
      Russ Fish authored
       GNUmakefile.in configure configure.in  - Add the testbed/backend directory.
       www/moduserinfo.php3 - The reworked PHP page.
       www/user_defs.php - Add a ModUserInfo method bridging to the script via XML,
           and remove the ChangeProfile method that is being replaced.
       backend/{moduserinfo,GNUmakefile}.in - Add the Perl script.
       db/User.pm.in - Add a ModUserInfo worker class method for script arg checking.
           Also SetUserInterface, SetWindowsPassword, and AccessCheck methods,
           and a copy of the escapeshellarg fn.
       sql/database-fill.sql - Add some to the table_regex 'users' checking patterns.
      
      Support stuff:
       account/tbacct.in - Update the UpdateWindowsPassword() function.
       db/libdb.pm.in - Add TBDB_USER_INTERFACE_EMULAB and TBDB_USER_INTERFACE_PLAB().
       tbsetup/libtestbed.pm.in - Add TB*EMAIL, TBMAIL_* vars (OPS, WWW, AUDIT).
      8965aad8
  22. 13 Sep, 2007 1 commit
  23. 02 Aug, 2007 1 commit
  24. 19 Jun, 2007 1 commit
    • Leigh B. Stoller's avatar
      Big update to the stats gathering code ... · 495f6803
      Leigh B. Stoller authored
      This change attempts to make the stats gathering code more reliable by
      not relying on the testbed_stats records to reconstruct usage
      statistics.  The main source of errors and total confusion in the
      current stats code is that testbed_stats includes all the errors and
      transitions, from which I have to reconstruct what happened in order
      to determine usage by a project or user.
      
      The new stats code still generates the testbed_stats code, but actual
      usage is recorded as it happens, in the experiment_resources table, as
      swapins, swapouts, and swapmods occur. Its also much faster to compute
      the data for the tables in the web interface, not having to scan a
      zillion testbed_stats records in php.
      
      There is a time consuming update to the records that takes place with
      a lot of tables locked.
      495f6803
  25. 26 Apr, 2007 1 commit
  26. 17 Apr, 2007 1 commit
  27. 20 Mar, 2007 1 commit
  28. 06 Mar, 2007 1 commit
  29. 16 Jan, 2007 2 commits
    • Leigh B. Stoller's avatar
      Move the bulk (or guts) of newuser and newproject from the web · 16aaa101
      Leigh B. Stoller authored
      interface to the backend. There are new scripts that can be called
      from the command line:
      
      	newuser xmlfile
      	newproj xmlfile
      
      They both run from small xmlfiles that are generated by the web
      interface from the form data. I also moved user verification to the
      backend so that we do not have duplicated email functions, but that
      was a small change.
      
      Upon error, the xmlfile is saved and sent to tbops so that we can
      rerun the command by hand, rather then force user to fill out form
      again. I also do a better job of putting the form back up intact when
      there are internal errors.
      
      If the user provides an initial public key, that is put into the xml
      file as well and addpubkey is called from newuser instead of the web
      interface. A more general change to addpukey is that it is now
      *always* called as "nobody". This script was a morass of confusion
      cause of having to call it as nobody before the user actually
      exists. In fact, another of my ongoing projects is to reduce the
      number of scripts called as a particular user, but thats a story for
      another day. Anyway, the script is always called as nobody, but we
      pass along the implied user in the environment so that it can do
      permission checks.
      16aaa101
    • Leigh B. Stoller's avatar
      35193718
  30. 10 Jan, 2007 1 commit
  31. 09 Jan, 2007 1 commit
  32. 05 Jan, 2007 1 commit
  33. 03 Jan, 2007 1 commit
    • Leigh B. Stoller's avatar
      Move most of the password changing code to the backend, as I just did · 32983db4
      Leigh B. Stoller authored
      for email changes. Currently, the hash is passed in on the command
      line from the web interface, and there is no method for invoking it on
      the command line and providing a text password, but that is an easy
      change now that the bulk of the code is in the backend instead of the
      web interface.
      
      Note that this change took longer cause we allow inactive,frozen, and
      wikionly users to change their password, but since they do not have
      accounts (yet) the operation is invoked as user "nobody" and tbacct
      about to me made aware of that possibility.
      
      Also add equivalent auditing email message that goes to the user when
      password is changed.
      
      Also more cleanup and conversion to objects.
      32983db4
  34. 03 Nov, 2006 1 commit
    • Leigh B. Stoller's avatar
      Big set of changes intended to solve a couple of problems with long · ff9061d4
      Leigh B. Stoller authored
      term archiving of firstclass objects like users, projects, and of
      course templates.
      
      * Projects, Users, and Groups are now uniquely identified inside the
        DB by a index value that will not be reused. If necessary, this
        could easily be a globally unique identifier, but without federation
        there is no reason to do that yet.
      
      * Currently, pid, gid, and uid still need to be locally unique until
        all of the changes are in place (which is going to take a fairly
        long time since the entire system operates in terms of those, except
        for the few places that I had to change to get the ball rolling).
      
      * We currently archive deleted users to the deleted_users table (their
        user_stats are kept forever since they are indexed by the new index
        column). Eventually do the same with projects (not sure about
        groups) but since we rarely if ever delete a project, there is no
        rush on this one.
      
      * At the same time, I have started a large reorg of the code, to move
        all of the user, group, project code into modules, both in php and
        perl, turning them into first class "objects" (as far as that goes
        in php and perl). Eventually, the number of query statements
        scattered around the code will be manageable, or so I hope.
      
      * Another related part of this reorg is to make it easier to move the
        new user/project/group code in the perl backend so that it can be
        made available via the xmlrpc interface (without duplication of the
        code).
      ff9061d4
  35. 26 Oct, 2006 1 commit