1. 06 Nov, 2013 1 commit
  2. 24 Sep, 2012 1 commit
    • Eric Eide's avatar
      Replace license symbols with {{{ }}}-enclosed license blocks. · 6df609a9
      Eric Eide authored
      This commit is intended to makes the license status of Emulab and
      ProtoGENI source files more clear.  It replaces license symbols like
      "EMULAB-COPYRIGHT" and "GENIPUBLIC-COPYRIGHT" with {{{ }}}-delimited
      blocks that contain actual license statements.
      
      This change was driven by the fact that today, most people acquire and
      track Emulab and ProtoGENI sources via git.
      
      Before the Emulab source code was kept in git, the Flux Research Group
      at the University of Utah would roll distributions by making tar
      files.  As part of that process, the Flux Group would replace the
      license symbols in the source files with actual license statements.
      
      When the Flux Group moved to git, people outside of the group started
      to see the source files with the "unexpanded" symbols.  This meant
      that people acquired source files without actual license statements in
      them.  All the relevant files had Utah *copyright* statements in them,
      but without the expanded *license* statements, the licensing status of
      the source files was unclear.
      
      This commit is intended to clear up that confusion.
      
      Most Utah-copyrighted files in the Emulab source tree are distributed
      under the terms of the Affero GNU General Public License, version 3
      (AGPLv3).
      
      Most Utah-copyrighted files related to ProtoGENI are distributed under
      the terms of the GENI Public License, which is a BSD-like open-source
      license.
      
      Some Utah-copyrighted files in the Emulab source tree are distributed
      under the terms of the GNU Lesser General Public License, version 2.1
      (LGPL).
      6df609a9
  3. 02 Sep, 2011 1 commit
  4. 30 Aug, 2011 1 commit
  5. 21 Oct, 2008 1 commit
  6. 18 Jul, 2008 1 commit
  7. 03 Aug, 2007 1 commit
  8. 19 Mar, 2007 1 commit
  9. 09 Mar, 2007 1 commit
  10. 28 Feb, 2007 1 commit
  11. 12 Feb, 2007 1 commit
    • Leigh Stoller's avatar
      * Replace the argument processing code in all pages. Currently we rely on · 48acc8e3
      Leigh Stoller authored
        register_globals=1 to turn POST/GET/COOKIES arguments in local variables.
        This is known to be a terrible security risk, and we keep saying we are
        going to fix it, and now I am. In order to accomplish this on a
        transitional basis (since I don't want the entire web interface to stop
        working while I debug it), and because the code just needs the cleanup, I
        am doing it like this: Each page will sport new declarations at the top:
      
      	RequiredPageArguments("experiment", PAGEARG_EXPERIMENT,
                                    "template",   PAGEARG_TEMPLATE,
                                    "instance",   PAGEARG_INSTANCE,
                                    "metadata",   PAGEARG_METADATA,
                                    "osinfo",     PAGEARG_OSINFO,
                                    "image",      PAGEARG_IMAGE,
                                    "project",    PAGEARG_PROJECT,
                                    "group",      PAGEARG_GROUP,
                                    "user",       PAGEARG_USER,
      			      "node",       PAGEARG_NODE,
      			      "yesno",      PAGEARG_BOOLEAN,
      			      "message",    PAGEARG_STRING,
      			      "age",        PAGEARG_INTEGER,
                                    "cost",       PAGEARG_NUMERIC,
                                    "formfields", PAGEARG_ARRAY,
                                    "unknown",    PAGEARG_ANYTHING);
      
      	OptionalPageArguments("canceled", PAGEARG_BOOLEAN);
      
        The first token in each pair is the name of the global variable to
        set, and the second token is the type. So, for "experiment" we look at
        the URL for a pid/eid or exptidx, etc, sanity check them (safe for a
        DB query), and then try to find that experiment in the DB. If it maps
        to an experiment, set global variable $experiment to the object. Since
        its a required argument, produce an error if not supplied. Similar
        treatment for optional arguments, with the obvious difference.
      
        The goal is to have ALL argument processing in one place, consistent,
        and correct. I've found numerous places where we leak unchecked
        arguments into queries. It also cuts out a lot of duplicated code.
      
      * To make the above easier to deal with, I've been replacing lots of
        hardcoded URLS in the code of the form:
      
      	foo.php3?pid=$pid&eid=$eid ...
      
        with
      
              CreateURL("foo", $experiment)
      
        which creates and returns the neccessary url string, by looking at
        the type of its arguments (experiment, template, instance, etc.)
      
        Eventually plan to replace them all so that URL handling throughout
        the code is all defined in one place (all the new URL code is in
        url_defs.php).
      
      * I have cranked up error reporting to tell me anytime a variable is
        used before it is initialized, plus a bunch of other stuff that PHP
        deems improper. Think of it like -Wall ... and boy we get a lot of
        warnings.  A very large percentage of the diffs are to fix all these
        warnings.
      
        The warnings are currently going to /usr/testbed/log/php-errors.log,
        and I'll be adding a script to capture them each night and mail them
        to tbops. This file also gets errors (this will be a change for
        developers; rather then seeing errors and warnings dumped in the
        middle of web pages, they will go to this file instead).
      
      * Major refactoring of the code. More objects (nodes, images, osids).
        Moving tons of queries into the objects in the hopes of someday
        getting to a point where we can split the web interface onto a
        different server.  Lots of general cleanup.
      48acc8e3
  12. 20 Dec, 2006 1 commit
  13. 08 Mar, 2006 1 commit
    • Timothy Stack's avatar
      · 74bc1920
      Timothy Stack authored
      Convert to a CSS layout, hopefully it should make some workbenchy
      things easier.
      
      	* www/beginexp_form.php3: Widen the nscheck window a bit so it
      	looks nice.
      
      	* www/common-style.css: Clean out some dead definitions.
      
      	* www/GNUmakefile.in, www/csshover.htc: Some magic that makes IE
      	support the :hover CSS pseudo-class.
      
      	* www/currentusage.php3: Tweak the header on the usage table.
      
      	* www/linktest.php3: Drop an extraneous </div>.
      
      	* www/menu.php3, www/tutorial/mobilewireless.php3: Use CSS and
      	semantic markup instead of tables.
      
      	* www/nscheck.php3: Hide some of the extra stuff.
      
      	* www/style-doc.css: Some styling specific to documentation.
      
      	* www/style.css, www/style-nonmain.css: Update for changes to
      	menu.php3 and try to clean out some old stuff.
      74bc1920
  14. 06 Dec, 2005 1 commit
  15. 14 Nov, 2005 1 commit
  16. 09 Nov, 2005 1 commit
  17. 31 Oct, 2005 1 commit
  18. 28 Oct, 2005 1 commit
    • Leigh Stoller's avatar
      Rework to use an iframe for most of the work, rather then sajax. Still · 3805c04e
      Leigh Stoller authored
      using a sajax call for cancelation, but the main invocation uses a
      plain iframe. This has the added benefit of scrolling more nicely
      instead of jumping back to the top with each write.
      
      Looks like xmlhttprequest or its impl in at least firefox is
      moderately broken, so that mulitple simultaneous requests get very
      confused with each other, and things break.
      3805c04e
  19. 18 Oct, 2005 1 commit
  20. 10 Sep, 2004 1 commit
    • Leigh Stoller's avatar
      Small change to suexec code. This change has the potential for creating · 7e731fba
      Leigh Stoller authored
      unanticipated breakage. If that happens, just need to back out the
      changes under the "suexec-stuff" tag. However, the better solution will
      probably be to fix the PHP scripts that break by adding the proper
      groups in the call to suexec (in the web page, see below) or by fixing
      the backend Perl script that breaks.
      
      This fix is primarily to address the problem of some users being in more
      groups (cause of subgroups) then the max number of groups allowed
      (NGROUPS).  The groups that really mattered (say, for creating an
      experiment in a subgroup) could be left out cause they were at the end
      of the list.
      
      * suexec.c: Change how groups are handled. Instead of taking a single
        gid argument (the gid to setgid as), now takes a comma separated list
        of groups. Further, instead of doing a setgroups to the user's entire
        group list as specified in the groups file (getgroups), setgroups to
        just the groups listed on the command line, plus the user's primary
        group from the password file (this is to prevent potential breakage
        with accessing files from the users homedir, although might not really
        be necessary).
      
        This change is somewhat rational in the sense that in our case, suexec
        is not being used to run arbitrary user code (CGIs), but only to run
        specific scripts that we say should be run. The environment for
        running those scripts can be more tightly controlled then it would
        otherwise need to be if running some random CGI the user has in his
        public html directory.
      
      * www: Change the gid argument to SUEXEC() in a number of scripts so
        that the project and subgroup are explicitly given to suexec, as
        described above. For example, in beginexp:
      
      	SUEXEC(gid, "$pid,$unix_gid", ....);
      
        Aside: note that project names (pid) are always one to one with their
        unix group name, but subgroup names are not, and *always* have to be
        looked up in the DB, hence the "unix_gid" argument.
      
        Script breakage should require nothing more then adding the proper
        group to the list as above.
      7e731fba
  21. 12 Jul, 2004 1 commit
  22. 30 Jun, 2004 1 commit
  23. 29 Jun, 2004 3 commits
    • Leigh Stoller's avatar
      Spit out a bunch of blanks (1024 of them) to get past the browser · 39a67a54
      Leigh Stoller authored
      buffering so that it will start to display output line by line.
      1024 for Firefox, probably the same for Netscape. I hear that IE is
      256 bytes.
      39a67a54
    • Leigh Stoller's avatar
      Ack, this comment refers to previous revision. · f1c5ee39
      Leigh Stoller authored
      * Changed the linktest web page to allow for killing a running
        linktest when called from the showexp page. Puts up a simple Click
        form, whose action is to call "linktest_control -k" which does the
        dirty work.
      
      * Implement a simple frameset when running linktest. I did this cause
        it was something new and besides, it was more fun then trying to
        reverse engineer the modelnet model file. Anyway, when linktest is
        started, put up a new window that has a two window frameset. The
        right hand window is just the spew output from linktest as it runs
        (although with buffering not much turns up at first). The left side
        window has a single click box to stop the running linktest, whose
        action is to call linktest_control -k as above. By the magic of
        javascript, when the linktest finishes, the stop button is removed
        and replaced with a "Linktest Finished" message. So exciting.
      f1c5ee39
    • Leigh Stoller's avatar
      Minor change to "Run Linktest" menu option; when the is a non-zero pid · e0a72dc6
      Leigh Stoller authored
      in the DB, change that to Stop Linktest instead.
      e0a72dc6
  24. 29 Apr, 2004 1 commit
    • Leigh Stoller's avatar
      Add prelim support for using linktest. Because of problems, this is · 6cdccbd2
      Leigh Stoller authored
      currently available to only people with stud=1 status in the DB.
      
      * www/tbauth.php3: Add a STUDLY() function to check that bit.
      
      * www/linktest.php3: New page to run linktest on the fly. The level
        defaults to the current level in the experiments table, but you can
        override that via the form on the page.
      
      * www/showexp.php3: Add link to aforementioned page. STUDLY() only.
      
      * www/beginexp_form.php3: Add an option (selection) to set the linktest
        level for create/swapin. Defaults to 0 (no linktest). STUDLY() only.
      
      * www/editexp.php3: Add an option to edit the default linktest level
        for an experiment. STUDLY() only.
      
      * tbsetup/batchexp.in and tbsetup/swapexp.in: Add code to optionally run
        the linktest, sending email if it fails (exists with non-zero status).
        Failure does not affect the swapin.
      6cdccbd2