1. 22 Oct, 2008 1 commit
  2. 26 Nov, 2007 1 commit
  3. 12 Feb, 2007 1 commit
    • Leigh B. Stoller's avatar
      * Replace the argument processing code in all pages. Currently we rely on · 48acc8e3
      Leigh B. Stoller authored
        register_globals=1 to turn POST/GET/COOKIES arguments in local variables.
        This is known to be a terrible security risk, and we keep saying we are
        going to fix it, and now I am. In order to accomplish this on a
        transitional basis (since I don't want the entire web interface to stop
        working while I debug it), and because the code just needs the cleanup, I
        am doing it like this: Each page will sport new declarations at the top:
      
      	RequiredPageArguments("experiment", PAGEARG_EXPERIMENT,
                                    "template",   PAGEARG_TEMPLATE,
                                    "instance",   PAGEARG_INSTANCE,
                                    "metadata",   PAGEARG_METADATA,
                                    "osinfo",     PAGEARG_OSINFO,
                                    "image",      PAGEARG_IMAGE,
                                    "project",    PAGEARG_PROJECT,
                                    "group",      PAGEARG_GROUP,
                                    "user",       PAGEARG_USER,
      			      "node",       PAGEARG_NODE,
      			      "yesno",      PAGEARG_BOOLEAN,
      			      "message",    PAGEARG_STRING,
      			      "age",        PAGEARG_INTEGER,
                                    "cost",       PAGEARG_NUMERIC,
                                    "formfields", PAGEARG_ARRAY,
                                    "unknown",    PAGEARG_ANYTHING);
      
      	OptionalPageArguments("canceled", PAGEARG_BOOLEAN);
      
        The first token in each pair is the name of the global variable to
        set, and the second token is the type. So, for "experiment" we look at
        the URL for a pid/eid or exptidx, etc, sanity check them (safe for a
        DB query), and then try to find that experiment in the DB. If it maps
        to an experiment, set global variable $experiment to the object. Since
        its a required argument, produce an error if not supplied. Similar
        treatment for optional arguments, with the obvious difference.
      
        The goal is to have ALL argument processing in one place, consistent,
        and correct. I've found numerous places where we leak unchecked
        arguments into queries. It also cuts out a lot of duplicated code.
      
      * To make the above easier to deal with, I've been replacing lots of
        hardcoded URLS in the code of the form:
      
      	foo.php3?pid=$pid&eid=$eid ...
      
        with
      
              CreateURL("foo", $experiment)
      
        which creates and returns the neccessary url string, by looking at
        the type of its arguments (experiment, template, instance, etc.)
      
        Eventually plan to replace them all so that URL handling throughout
        the code is all defined in one place (all the new URL code is in
        url_defs.php).
      
      * I have cranked up error reporting to tell me anytime a variable is
        used before it is initialized, plus a bunch of other stuff that PHP
        deems improper. Think of it like -Wall ... and boy we get a lot of
        warnings.  A very large percentage of the diffs are to fix all these
        warnings.
      
        The warnings are currently going to /usr/testbed/log/php-errors.log,
        and I'll be adding a script to capture them each night and mail them
        to tbops. This file also gets errors (this will be a change for
        developers; rather then seeing errors and warnings dumped in the
        middle of web pages, they will go to this file instead).
      
      * Major refactoring of the code. More objects (nodes, images, osids).
        Moving tons of queries into the objects in the hopes of someday
        getting to a point where we can split the web interface onto a
        different server.  Lots of general cleanup.
      48acc8e3
  4. 20 Dec, 2006 1 commit
  5. 18 Dec, 2005 1 commit
    • Leigh B. Stoller's avatar
      Move the bulk of what was in showlogfile, into showlogfile_sup, so · 41f4d6a5
      Leigh B. Stoller authored
      that it can be "included" into other scripts; showlogfile, beginexp,
      swapexp, modifyexp, endexp.
      
      Each of these scripts now appends the showlog directly to the page,
      instead of providing a link to a different page.
      
      Also changed the showlog code to place the output into an inner iframe
      so that it can be sized to fit in the window, without the outer stuff
      (like the menus) getting scrolled away.
      41f4d6a5
  6. 04 Nov, 2005 1 commit
    • Timothy Stack's avatar
      · d034c0fb
      Timothy Stack authored
      Automatically scroll and highlight the activity log file:
      
      	* www/Sajax.php: Remove automatic include of json.js, it didn't
      	always work, need to do it manually now.  Use the fvlogger stuff
      	when debugging is turned on.
      
      	* www/mungelog.js: Javascript functions for dealing with log
      	output.
      
      	* www/showlogfile.php3: Automatically scroll the window when new
      	output comes in and do some light highlighting.
      d034c0fb
  7. 26 Oct, 2005 1 commit
  8. 31 Dec, 2002 1 commit
  9. 20 Dec, 2002 1 commit
  10. 19 Dec, 2002 1 commit
  11. 18 Dec, 2002 1 commit
  12. 11 Jul, 2002 1 commit
    • Leigh B. Stoller's avatar
      A bunch of logfile changes. Logs are now saved in the experiment · 51bc0de4
      Leigh B. Stoller authored
      directory so that they can be viewed later after the operation is
      complete. I've also cleaned up the mechanism for determining when
      a log file is active (for the web spew) by using another slot in the
      experiments table, and added some libdb routines to manage that slot.
      At present just the last (or latest) log can be viewed after the fact,
      but we can change that later if think its really necessary. At the
      same time, make it possible for admin types to view the log files for
      other peoples expierments; spew is setuid, but flips back after
      opening the file (does usual checks too). I've also incorporated the
      log changes into the batch daemon, so you can view the last batch log
      too, although I have not tested that yet!
      51bc0de4
  13. 07 Jul, 2002 1 commit
  14. 21 Jun, 2002 1 commit
  15. 16 Jun, 2002 1 commit
    • Leigh B. Stoller's avatar
      Some fixes to the spewlogfile stuff so that you do not get the · d9c3dd68
      Leigh B. Stoller authored
      transition error when you click too fast after creating it. Instead of
      looking at experiment state, use the logile slot of the experiments
      table, and make sure its cleared/set properly in start/swap experiment
      scripts.
      
      Also added a spew option to the swap page so you can watch experiments
      swap in/out.
      d9c3dd68
  16. 02 Apr, 2002 1 commit
    • Leigh B. Stoller's avatar
      Ah, the things I do. Added web page and backend script to scroll the · 07323144
      Leigh B. Stoller authored
      experiment log file to the user as it gets generated. The web page
      does not redraw, it just never exits until the backend sees that the
      experiement transition is done, and then it exists, which terminates
      the script. I added a DB field to hold the logfile name and some
      routines in libdb, with the idea that this might be more generally
      useful at some point. Next time you create an experiment, look for the
      last sentence, and click on "realtime".
      07323144