1. 06 Mar, 2018 1 commit
  2. 02 Mar, 2018 1 commit
  3. 16 Feb, 2018 2 commits
    • Leigh Stoller's avatar
    • Leigh Stoller's avatar
      A lot of work on the RPC code, among other things. · 56f6d601
      Leigh Stoller authored
      I spent a fair amount of improving error handling along the RPC path,
      as well making the code more consistent across the various files. Also
      be more consistent in how the web interface invokes the backend and gets
      errors back, specifically for errors that are generated when taking to a
      remote cluster.
      
      Add checks before every RPC to make sure the cluster is not disabled in
      the database. Also check that we can actually reach the cluster, and
      that the cluster is not offline (NoLogins()) before we try to do
      anything. I might have to relax this a bit, but in general it takes a
      couple of seconds to check, which is a small fraction of what most RPCs
      take. Return precise errors for clusters that are not available, to the
      web interface and show them to user.
      
      Use webtasks more consistently between the web interface and backend
      scripts. Watch specifically for scripts that exit abnormally (exit
      before setting the exitcode in the webtask) which always means an
      internal failure, do not show those to users.
      
      Show just those RPC errors that would make sense users, stop spewing
      script output to the user, send it just to tbops via the email that is
      already generated when a backend script fails fatally.
      
      But do not spew email for clusters that are not reachable or are
      offline. Ditto for several other cases that were generating mail to
      tbops instead of just showing the user a meaningful error message.
      
      Stop using ParRun for single site experiments; 99% of experiments.
      
      For create_instance, a new "async" mode that tells CreateSliver() to
      return before the first mapper run, which is typically very quickly.
      Then watch for errors or for the manifest with Resolve or for the slice
      to disappear. I expect this to be bounded and so we do not need to worry
      so much about timing this wait out (which is a problem on very big
      topologies). When we see the manifest, the RedeemTicket() part of the
      CreateSliver is done and now we are into the StartSliver() phase.
      
      For the StartSliver phase, watch for errors and show them to users,
      previously we mostly lost those errors and just sent the experiment into
      the failed state. I am still working on this.
      56f6d601
  4. 25 Jan, 2018 1 commit
  5. 22 Jan, 2018 1 commit
    • Leigh Stoller's avatar
      A set of changes to deal with really big topologies; The initial · 4861de85
      Leigh Stoller authored
      CreateSliver() RPC is going to take a really long time as is going to
      time out. This would cause the experiment to fail at the Portal. Now we
      continue on to WaitForSlivers(), and wait for the manifest to appear,
      which signals the CreateSliver() has finally finished, and then we go
      into normal waitmode.
      4861de85
  6. 04 Jan, 2018 1 commit
  7. 02 Jan, 2018 1 commit
  8. 23 Dec, 2017 1 commit
  9. 14 Dec, 2017 1 commit
  10. 11 Dec, 2017 4 commits
    • Leigh Stoller's avatar
      Minor wording tweaks. · 754069d2
      Leigh Stoller authored
      754069d2
    • Leigh Stoller's avatar
      Add extension limiting to manage_extensions and request extension paths. · f71d7d95
      Leigh Stoller authored
      The limit is the number of hours since the experiment is created, so a
      limit of 10 days really just means that experiments can not live past 10
      days. I think this makes more sense then anything else. There is an
      associated flag with extension limiting that controls whether the user
      can even request another extension after the limit. The normal case is
      that the user cannot request any more extensions, but when set, the user
      is granted no free time and goes through need admin approval path.
      
      Some changes to the email, so that both the user and admin email days
      how many days/hours were both requested and granted.
      
      Also UI change; explicitly tell the user when extensions are disabled,
      and also when no time is granted (so that the users is more clearly
      aware).
      f71d7d95
    • Leigh Stoller's avatar
      8b9192ca
    • Leigh Stoller's avatar
      Kill off more obsolete extension code. · 92baeadd
      Leigh Stoller authored
      92baeadd
  11. 05 Dec, 2017 1 commit
  12. 04 Dec, 2017 2 commits
    • Leigh Stoller's avatar
      Extension policy changes: · bd7d9d05
      Leigh Stoller authored
      * New tables to store policies for users and projects/groups. At the
        moment, there is only one policy (with associated reason); disabled.
        This allows us to mark projects/groups/users with enable/disable
        flags. Note that policies are applied consecutively, so you can
        disable extensions for a project, but enable them for a user in that
        project.
      
      * Apply extensions when experiments are created, send mail to the audit
        log when policies cause extensions to be disabled.
      
      * New driver script (manage_extensions) to change the policy tables.
      bd7d9d05
    • Leigh Stoller's avatar
      Changes related to extensions: · e1b6076f
      Leigh Stoller authored
      * Change the units of extension from days to hours along the extension
        path. The user does not see this directly, but it allows us to extend
        experiments to the hour before they are needed by a different
        reservation, both on the user extend modal and the admin extend modal.
      
        On the admin extend page, the input box still defaults to days, but
        you can also use xDyH to specify days and hours. Or just yH for just
        hours.
      
        But to make things easier, there is also a new "max" checkbox to
        extend an experiment out to the maximum allowed by the reservation
        system.
      
      * Changes to "lockout" (disabling extensions). Add a reason field to the
        database, clicking the lockout checkbox will prompt for an optional
        reason.
      
        The user no longer sees the extension modal when extensions are
        disabled, we show an alert instead telling them extensions are
        disabled, and the reason.
      
        On the admin extend page there is a new checkbox to disable extensions
        when denying an extension or scheduling termination.
      
        Log extension disable/enable to the audit log.
      
      * Clear out a bunch of old extension code that is no longer used (since
        the extension code was moved from php to perl).
      e1b6076f
  13. 20 Nov, 2017 1 commit
  14. 14 Nov, 2017 1 commit
  15. 13 Nov, 2017 1 commit
  16. 06 Nov, 2017 1 commit
  17. 03 Nov, 2017 1 commit
    • Leigh Stoller's avatar
      Fixes/Changes for reservations: · 79d99fa8
      Leigh Stoller authored
      1. Fix the user extend modal to show the proper number of days they can
         extend.
      
      2. Fix the admin extend modal warning when the extension would violate
         max extension, it was not showing. Add new alerts when we cannot get
         max extension from the cluster or no extension at all allowed.
      
      3. Reduce number of days in the box to max allowed. Warn loudly if you
         type a different number and its greater then max extension.
      
      4. Add "force" box to override. Use with caution. Added the plumbing
         through to the back end as new force option to RenewSliver().
      
      5. Add check in RenewSliver() to ask the reservation system if extension
         allowed before doing it. This was missing, should solve some of the
         over book problems.
      79d99fa8
  18. 13 Oct, 2017 2 commits
    • Leigh Stoller's avatar
      78dc9fea
    • Leigh Stoller's avatar
      Changes for automatic lockdown of experiments: · 8f4e3191
      Leigh Stoller authored
      1. First off, we no longer do automatic lockdown of experiments when
         granting an extension longer then 10 days.
      
      2. Instead, we will lockdown experiments on case by case basis.
      
      3. Changes to the lockdown path that ask the reservation system at the
         target cluster if locking down would throw the reservation system
         into chaos. If so, return a refused error and give admin the choice
         to override. When we do override, send email to local tbops informing
         that the reservation system is in chaos state.
      8f4e3191
  19. 10 Oct, 2017 1 commit
  20. 04 Oct, 2017 2 commits
  21. 08 Aug, 2017 2 commits
  22. 26 Jun, 2017 2 commits
  23. 07 Jun, 2017 1 commit
    • Leigh Stoller's avatar
      Implement issue #284 (admin notes). · 8ab4519f
      Leigh Stoller authored
      You can find and change the admin notes on the admin extension page,
      since is the page where we show lots of admin only stuff. Might need
      to rename this page at some point.
      8ab4519f
  24. 06 Jun, 2017 1 commit
  25. 05 Jun, 2017 1 commit
  26. 02 Jun, 2017 1 commit
  27. 30 May, 2017 1 commit
    • Leigh Stoller's avatar
      Rework how we store the sliver/slice status from the clusters: · e5d36e0d
      Leigh Stoller authored
      In the beginning, the number and size of experiments was small, and so
      storing the entire slice/sliver status blob as json in the web task was
      fine, even though we had to lock tables to prevent races between the
      event updates and the local polling.
      
      But lately the size of those json blobs is getting huge and the lock is
      bogging things down, including not being able to keep up with the number
      of events coming from all the clusters, we get really far behind.
      
      So I have moved the status blobs out of the per-instance web task and
      into new tables, once per slice and one per node (sliver). This keeps
      the blobs very small and thus the lock time very small. So now we can
      keep up with the event stream.
      
      If we grow big enough that this problem comes big enough, we can switch
      to innodb for the per-sliver table and do row locking instead of table
      locking, but I do not think that will happen
      e5d36e0d
  28. 25 Apr, 2017 1 commit
    • Leigh Stoller's avatar
      Changes to checkquota and create_image: · 028d4164
      Leigh Stoller authored
      1. Add option (-m) to checkquota that says to look for a minimum amount
         of space. This is an additional check, on the file system in
         question.  So when -p option is give, we want that amount of space in
         the project directory. Add new -g option for checking quota in the
         group directory.
      
      2. Change create_image to supply -p or -g option as needed, and check
         for at 3GB of space (-m 3GB). I will make this a sitevar if it works
         out.
      
      3. manage_instance returns the space error to the web ui.
      028d4164
  29. 24 Apr, 2017 1 commit
    • Leigh Stoller's avatar
      Several changes: · 195fa852
      Leigh Stoller authored
      1. Encapsulate rspec2genilib in a library function.
      
      2. Add a "check" option UpdateDiskImage() to see if any changes are
         actually going to be made so that we do not create a new version of a
         profile that is identical to the previous version.
      
      3. Do not ever create a new version of a script based profile since we
         can never change the script (after a disk snapshot). Unless it is a
         portal converted script, we can do that by changing the rspec and
         then generating a new script.
      195fa852
  30. 17 Apr, 2017 1 commit
    • Leigh Stoller's avatar
      Separate user vs admin lockdown, previously they were intertwined. · 8e88917e
      Leigh Stoller authored
      User lockdown is as before, user can override that on the terminate
      page. Admin lockdown is like Classic lockdown; the flag must be cleared
      before the experiment can be terminated, there is no override on the
      termination page.
      
      UI changes on the status and admin extend page for the additional
      flag (instead of a single lockdown, there are now two).
      8e88917e
  31. 24 Mar, 2017 1 commit