1. 25 Aug, 2006 2 commits
  2. 24 Aug, 2006 1 commit
    • Jonathon Duerig's avatar
      Fixed the traffic model so that it is now in line with what Rob and I... · c6fa578a
      Jonathon Duerig authored
      Fixed the traffic model so that it is now in line with what Rob and I discussed. Delays are before the write with the write size cached. Writes expire based on an expiration date.
      
      Miscellaneous fixes. Open problem: PacketSensor does not deal correctly with zero-sized packets. I changed KernelTcp to pass such packets because otherwise there is no way to do state changes based on SYN/FIN/other packets. SYN is handled ok for now because of a change noted below. FIN is not.
      
      Added a StateSensor. As I discovered, using the kernel tcp_info data structure isn't useful when dealing with fields that change on a packet by packet basis because the kernel information is retrieved at processing time and not capture time. For instance, it is useless when trying to determine whether a connection was established by the time a particular packet was sent (to determine whether it is part of the three-way-handshake). The StateSensor keeps track of the state machine and correlates it to the packet involved. This allows the other sensors to rely on it to distinguish between connection setup and the rest of the connection traffic. Added references to it in the PacketSensor, the DelaySensor and the ThroughputSensor.
      
      Changed the way packet information was transmitted to the sensors to make it easier to add new packet types (as will be necessary when accept()s are handled).
      
      Fixed all outstanding flaws in the basic feedback mechanism. In short, "Its alive!". Currently the only data being transmitted is the base rtt (MinDelay). Now that the feedback is working in a basic form, it will be easier to get the other characteristics online.
      c6fa578a
  3. 22 Aug, 2006 1 commit
  4. 21 Aug, 2006 7 commits
    • Robert Ricci's avatar
      Fix a bug noticed by Jon - make sure to not iterate off the end of the · 4b247a8d
      Robert Ricci authored
      list, which could happen if we somehow saw an ack for a packet whose
      send() we missed (ie. the kernel dropped it on the way in to pcap).
      4b247a8d
    • Robert Ricci's avatar
      Bug fixes: · fbda5f5d
      Robert Ricci authored
      Fix range check - this was necessary because of my change to the
      ackFor calculation.
      
      Tricky detail about STL list.erase() - it does *not* erase the end iterator,
      which meant that we were failing to remove the packet being acked (we were
      removing all packets up to that one). So, we have it increment the iterator
      in localAck() even if we find the one we're looking for.
      
      Tested well for lossless connections - still needs testing for lossy
      connections and SACK (see below). Hopefully, it works for the former,
      but I know it doesn't work for the latter.
      
      Added more debugging output to localAck()
      
      Added a check which should warn us if we see any SACKS, though I
      can't be sure it works, because I haven't seen any yet (that I know
      of! :)
      fbda5f5d
    • Robert Ricci's avatar
      Major re-work of the handleTcp() function, which had a fundamentally · e93ed0f4
      Robert Ricci authored
      wrong interpretation of how part of TCP works.
      
      Being an ACK and being a data packet are *not* mutually exclusive,
      though the old code assumed that they were.
      
      There are basically four things we might need to do:
      If outgoing
          (a) Handle an outgoing ACK
          (b) Handle an outgoing data packet
      If incoming
          (c) Handle an incoming ACK
          (d) Handle an incoming data packet
      
      Note that a and b can be done on the same packet, as well as c and d. Right
      now, however, our code only handles b and c. We will need to support a and
      d before we can model real applications, I think!
      
      Also, make handleTcp() more robust.
      e93ed0f4
    • Robert Ricci's avatar
    • Robert Ricci's avatar
      Bug fix for my last commit - still open pcap socket if we're saving · 01acaff8
      Robert Ricci authored
      replay information.
      01acaff8
    • Robert Ricci's avatar
      Don't open the pcap device if doing replay · e0866db5
      Robert Ricci authored
      e0866db5
    • Robert Ricci's avatar
      Typo police · df01a7e9
      Robert Ricci authored
      df01a7e9
  5. 18 Aug, 2006 8 commits
  6. 17 Aug, 2006 3 commits
  7. 11 Aug, 2006 5 commits
  8. 10 Aug, 2006 2 commits
  9. 09 Aug, 2006 6 commits
  10. 08 Aug, 2006 1 commit
  11. 10 Jul, 2006 1 commit
  12. 07 Jul, 2006 1 commit