1. 13 May, 2008 1 commit
  2. 24 Mar, 2008 1 commit
  3. 06 Feb, 2008 1 commit
  4. 15 Jan, 2008 1 commit
  5. 14 Jan, 2008 1 commit
  6. 20 Dec, 2007 1 commit
  7. 27 Nov, 2007 1 commit
  8. 18 Nov, 2007 1 commit
  9. 13 Nov, 2007 2 commits
  10. 09 Nov, 2007 1 commit
  11. 08 Nov, 2007 1 commit
    • Russ Fish's avatar
      Fix whitespace and null string handling problems. · fea90641
      Russ Fish authored
               www/beginexp_form.php3 - No initial whitespace in plab Slice Description textarea.
               sql/database-fill.sql - Use default:fulltext for 'experiments','expt_name'
                   to allow multi-line Slice Description in plab_ez->beginexp->batchexp.
               www/moduserinfo.php3 - Pass null string for optional usr_addr2 and notes fields.
               backend/moduserinfo.in - Null string attr comes from XML as an undef value.
               db/User.pm.in - Distinguish between undef and null string in ModUserInfo.
      fea90641
  12. 07 Nov, 2007 1 commit
  13. 30 Oct, 2007 1 commit
    • Russ Fish's avatar
      Avoid a problem in newproject.php3. When the DB is locked for daily backup, · 2f373d5b
      Russ Fish authored
      NewNewUser()/newuser would block and then unblock and get done; meanwhile the PHP
      thread went away so we never returned to call NewNewProject/mkproj.  Move the call
      on the newuser script from PHP into the back-end Perl newproj script for atomicity.
      
          www/newproject.php3 - When the project leader is a new user, pass two xml
              files to the newproj backend script, one describing the project and the
              second one (an optional) file describing the newuser.
      
          www/user_defs.php - Factor the xml-making part of NewNewUser into NewNewUserXML.
      
          www/project_defs.php - Remove the required $leader arg of NewNewProject.
              newproj may call newuser, which may generate the leader uid.
      
          backend/newproj.in - Call newuser with an optional 'newuser_xml' XML file.
      
          sql/database-fill.sql - Add 'projects','newuser_xml'.
      2f373d5b
  14. 23 Oct, 2007 1 commit
    • Russ Fish's avatar
      Change the delaycontrol page to call delay_config via XML. · 25855415
      Russ Fish authored
            www/delaycontrol.php3 - Convert the form into SPITFORM/submit/formfields.
                      Add a ChangeDelayConfig function to spit out XML to delay_config.
            account/delay_config.in - Add -X <xmlfile> in place of other command-line args.
            sql/database-fill.sql - Add a couple of 'virt_lans' entries for delay_config's use.
      25855415
  15. 19 Oct, 2007 2 commits
    • Russ Fish's avatar
      Change the showpubkeys page to call addpubkey via XML. · 3afc584e
      Russ Fish authored
            www/showpubkeys.php3 - Add a NewPubKey function to spit out XML to addpubkey.
            account/addpubkey.in - Add -X <xmlfile> in place of other command-line args.
            sql/database-fill.sql - Add 'user_pubkeys' entries for addpubkey's use.
      3afc584e
    • Russ Fish's avatar
      Move newimageid_ez page form logic to a backend Perl script. · 9a586d0b
      Russ Fish authored
           www/newimageid_ez.php3 - The reworked PHP page.  Calls Image::NewImageId with ez=1.
           www/newimageid.php3 - Call Image::NewImageId with ez=0.
           www/imageid_defs.php - Re-use the Image::NewImageId class method, adding an 'ez' arg.
           backend/{newimageid_ez,GNUmakefile}.in configure configure.in - New backend script.
               After checks, calls OSinfo->Create and Image->Create with the same XML args array.
           db/Image.pm.in - Re-use the Image->Create method, adding an imageid over-ride arg.
           db/OSinfo.pm.in - Filter out extraneous db slot args from XML in the Create method.
           db/libdb.pm.in - Add TB_{OS,IMAGE}ID_* constants from dbdefs.php3 .
           sql/database-fill.sql - Add OS entries to the table_regex 'images' pattern set.
      9a586d0b
  16. 17 Oct, 2007 1 commit
  17. 16 Oct, 2007 1 commit
    • Russ Fish's avatar
      Move editgroup page form logic to a backend Perl script. · 8fffc2f3
      Russ Fish authored
           www/editgroup.php3 - The reworked PHP page.
           www/editgroup_form.php3 - Removed, form merged into editgroup.php3 .
           www/showgroup.php3 - Link to editgroup.php3, rather than editgroup_form.php3 .
           www/group_defs.php - Add an Image::EditGroup class method
                                  bridging to the script via XML.
           backend/{editgroup,GNUmakefile}.in configure configure.in - New backend script.
           db/Group.pm.in - Add an EditGroup worker class method for script arg checking.
                            Also the missing NonMemberList and CheckTrustConsistency methods,
                            and a GETTRUST flag to MemberList, as in the PHP version.
           db/User.pm.in - Add the missing but tiny {Set,Get}TempData methods.
           sql/database-fill.sql - Add gid_idx to the table_regex 'groups' checking patterns.
      8fffc2f3
  18. 12 Oct, 2007 1 commit
    • Russ Fish's avatar
      Move newimageid page form logic to a backend Perl script. · 3f5e4ef8
      Russ Fish authored
           www/newimageid.php3 - The reworked PHP page.
           www/imageid_defs.php - Add an Image::NewImageId class method
                                  bridging to the script via XML.
           backend/{newimageid,GNUmakefile}.in configure configure.in - New backend script.
           db/Image.pm.in - Add a Create class method for script arg checking.
           sql/database-fill.sql - Add to the table_regex 'images' checking patterns.
      3f5e4ef8
  19. 10 Oct, 2007 1 commit
    • Russ Fish's avatar
      Move editsitevars page form logic to a backend Perl script. · bee74343
      Russ Fish authored
           www/editsitevars.php3 - The reworked PHP page, including
             a SetSiteVar function bridging to the script via XML.
           backend/{editsitevars,GNUmakefile}.in configure configure.in - New backend script.
           sql/database-fill.sql - Add table_regex 'sitevariables' checking patterns.
      bee74343
  20. 09 Oct, 2007 1 commit
  21. 08 Oct, 2007 1 commit
    • Russ Fish's avatar
      Move editnodetype page form logic to a backend Perl script. · 45d79d63
      Russ Fish authored
             Note: new_node attributes have not yet been converted from
             names for osid's and imageid's to new-style integer indices.
           www/editnodetype.php3 - The reworked PHP page, including
             an EditNodeType function bridging to the script via XML.
           backend/{editnodetype,GNUmakefile}.in configure configure.in - New backend script,
             including wildcarding on %xmlfields table entries to handle dynamic attributes.
           sql/database-fill.sql - Add table_regex 'node_types' checking patterns.
      45d79d63
  22. 03 Oct, 2007 1 commit
    • Russ Fish's avatar
      Move editimageid page form logic to a backend Perl script. · 9dcf6297
      Russ Fish authored
           www/editimageid.php3 - The reworked PHP page.
           www/imageid_defs.php - Add an Experiment::EditImageid class method
                                  bridging to the script via XML.
           backend/{editimageid,GNUmakefile}.in configure configure.in - New backend script.
           db/Image.pm.in - Add an EditImageid worker class method for script arg checking.
           sql/database-fill.sql - Add to the table_regex 'images' checking patterns.
      9dcf6297
  23. 29 Sep, 2007 1 commit
    • Russ Fish's avatar
      Move editexp page form logic to a backend Perl script. · 187ec0f9
      Russ Fish authored
           www/editexp.php3 - The reworked PHP page.
           backend/{editexp,GNUmakefile}.in configure configure.in - New backend script.
           www/experiment_defs.php - Add an Experiment::EditExp class method
                                     bridging to the script via XML.
           db/Experiment.pm.in - Add an EditExp worker class method for script arg checking,
                                 And a missing description method.
           sql/database-fill.sql - Add to the table_regex 'experiments' checking patterns.
      187ec0f9
  24. 27 Sep, 2007 1 commit
  25. 26 Sep, 2007 1 commit
    • Russ Fish's avatar
      Move newgroup page form logic to a backend Perl script and methods. · 3164ca14
      Russ Fish authored
           www/newgroup.php3 - The reworked PHP page.
           www/newgroup_form.php3 - Removed, form merged into newgroup.php3 .
           www/group_defs.php - Add a Group::Create method bridging to the script via XML.
           www/showproject.php3 - Link to newgroup.php3, rather than newgroup_form.php3 .
           configure configure.in  - Add the newgroup backend script.
           backend/{newgroup,GNUmakefile}.in - Add the Perl script.
           db/Group.pm.in - Update the AccessCheck method to allow TB_PROJECT_LEADGROUP.
           sql/database-fill.sql - Add table_regex 'groups' checking patterns.
      3164ca14
  26. 19 Sep, 2007 1 commit
    • Russ Fish's avatar
      Move moduserinfo page form logic to a backend Perl script and methods. · 8965aad8
      Russ Fish authored
       GNUmakefile.in configure configure.in  - Add the testbed/backend directory.
       www/moduserinfo.php3 - The reworked PHP page.
       www/user_defs.php - Add a ModUserInfo method bridging to the script via XML,
           and remove the ChangeProfile method that is being replaced.
       backend/{moduserinfo,GNUmakefile}.in - Add the Perl script.
       db/User.pm.in - Add a ModUserInfo worker class method for script arg checking.
           Also SetUserInterface, SetWindowsPassword, and AccessCheck methods,
           and a copy of the escapeshellarg fn.
       sql/database-fill.sql - Add some to the table_regex 'users' checking patterns.
      
      Support stuff:
       account/tbacct.in - Update the UpdateWindowsPassword() function.
       db/libdb.pm.in - Add TBDB_USER_INTERFACE_EMULAB and TBDB_USER_INTERFACE_PLAB().
       tbsetup/libtestbed.pm.in - Add TB*EMAIL, TBMAIL_* vars (OPS, WWW, AUDIT).
      8965aad8
  27. 10 Sep, 2007 1 commit
    • Leigh Stoller's avatar
      Rework the newosid web page as an example of how I want all of our current · 77540494
      Leigh Stoller authored
      form processing to be done.
      
      The gist is that I have moved all of the data checking and DB work to
      the backend into a new script called utils/newosid. This script does
      all the field checking that used to be done in php. It takes a simple
      XML file as input and returns a set of strings to format as errors (if
      there are any).
      
      The overall goal to make a big push to move this code out of PHP and
      perl.  A nice side effect is that many operations that are current
      only available via the web interface will also become available
      command line (and also XMLRPC with a little moew work).
      77540494
  28. 26 Jul, 2007 1 commit
  29. 24 Apr, 2007 1 commit
  30. 16 Feb, 2007 1 commit
  31. 16 Jan, 2007 1 commit
    • Leigh Stoller's avatar
      Move the bulk (or guts) of newuser and newproject from the web · 16aaa101
      Leigh Stoller authored
      interface to the backend. There are new scripts that can be called
      from the command line:
      
      	newuser xmlfile
      	newproj xmlfile
      
      They both run from small xmlfiles that are generated by the web
      interface from the form data. I also moved user verification to the
      backend so that we do not have duplicated email functions, but that
      was a small change.
      
      Upon error, the xmlfile is saved and sent to tbops so that we can
      rerun the command by hand, rather then force user to fill out form
      again. I also do a better job of putting the form back up intact when
      there are internal errors.
      
      If the user provides an initial public key, that is put into the xml
      file as well and addpubkey is called from newuser instead of the web
      interface. A more general change to addpukey is that it is now
      *always* called as "nobody". This script was a morass of confusion
      cause of having to call it as nobody before the user actually
      exists. In fact, another of my ongoing projects is to reduce the
      number of scripts called as a particular user, but thats a story for
      another day. Anyway, the script is always called as nobody, but we
      pass along the implied user in the environment so that it can do
      permission checks.
      16aaa101
  32. 09 Jan, 2007 1 commit
  33. 29 Nov, 2006 1 commit
    • Leigh Stoller's avatar
      Keith Sklower's changes to support a single control network model for · 08737f67
      Leigh Stoller authored
      ElabInElab experiments, so as not to consume an interface.
      
      I actually modified Keith's changes so that we can dynmaically choose
      the single or dual model in the NS file (Keith's changes hardwired the
      system to only single control network) since the single network model
      has the disadvantage of not allowing new nodes to be added to an inner
      elab, which would make it impossible to test some things (like the
      newnode path!).
      
      To choose the single control network model, place this in your NS file:
      
      	tb-elabinelab-singlenet
      
      other it defaults to the older dual network model.
      08737f67
  34. 27 Nov, 2006 1 commit
  35. 18 Oct, 2006 1 commit
  36. 08 Oct, 2006 1 commit
  37. 12 Sep, 2006 1 commit
    • Leigh Stoller's avatar
      This started out as a simple little hack to add a StopRun "ns" event, but · cbdc4178
      Leigh Stoller authored
      it got more complicated as it progressed.
      
      The bulk of the change was changing template_exprun so that it can take a
      pid/eid as an alternative to eid/guid. This is a big convenience since its
      easy to find the template from a running experiment, and it makes it
      possible to invoke from the event scheduler, which has never heard of a
      template before (and its not something I wanted to teach it about).  Its
      also easier on users.
      
      Anyway, back to the stoprun event. You can now do this:
      
      	$ns at 100 "$ns stoprun"
      or
      	tevc -e pid/eid now ns stoprun
      
      You can add the -w option to wait for the completion event that is sent,
      but this brings me to the glaring problems with this whole thing.
      
      * First, the scheduler has to fire off the stoprun in the background,
        since if it waits, we get deadlock. Why? Cause the implementation of
        stoprun uses the event system (SNAPSHOT event, other things), and if
        the scheduler is sitting and waiting, nothing happens.
      
        Okay, the solution to this was to generate a COMPLETION event from
        template_exprun once the stop operation is complete. This brings me
        to the second problem ...
      
      * Worse, is that the "ns" events that are sent to implement stoprun (like
        snapshot) send their own completion events, and that confuses anyone
        waiting on the original stoprun event (it returns early).
      
        So what to do about this? There is a "token" field in the completion
        event structure, which I presume is to allow you to match things up.  But
        there is no way to set this token using tevc (and then wait for it), and
        besides, the event scheduler makes them up anyway and sticks them into
        the event. So, the seed of a fix are already germinating in my mind, but
        I wanted to get this commit in so that Mike would have fun reading this
        commit log.
      cbdc4178
  38. 05 Sep, 2006 1 commit
    • Leigh Stoller's avatar
      A bunch of template changes resulting from meetings last week. · 087dbfff
      Leigh Stoller authored
      * Add XMLRPC interface for template swapin,stoprun,startrun,swapout and
        add the appropriate wrappers to the script_wrapper on ops.
      
      * Allow parameter descriptions in NS files. This is probably not in its
        final form since its a bit confusing as to what has priority; something
        in the NS file or a metadata item. Anyway, you can do this in your NS
        file:
      
      	$ns define-template-parameter GUID "0/0" "The GUID to be analyzed"
      
        The rules are currently that the NS file description has priority and
        is copied to child templates, unless the user has modified a description
        via the web interface, in which case the NS file description is ignored.
        I know, sounds awful, but for the most part people are going to use the
        NS file anyway.
      
      * Add "clear" option when starting a new experiment run; the per
        experiment DB at the logholes are cleared. Note that this is *not* the
        default behaviour; you have to either check the checkbox on the web form
        or use the -c option to the script wrapper, or clear=yes if talking
        directly to the XMLRPC server.
      
      * Fix up how email is generated for template_swapin and template_create,
        so that Kevin can debug tblog/tbreport stuff, but also so that we maintain
        mail logs as before. I have made some improvements to libaudit so as to
        centralize the mail goo, and avoid duplicating all that stuff.
      
      * Minor fixes to the program agent so that the new environment strings are
        sent before the program agent exits and reloads them!
      
      * Other minor little things.
      087dbfff