xmlrpcbag.in 4.51 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13
#!/usr/bin/perl -wT
# paperbag - Limited shell for use on ops.emulab.net
# Allows execution of commands found in a permitted list
# Also checks arguments for potentially dangerous characters (semicolons,
# pipes, redirects, etc)
# Robert Ricci, <ricci@cs.utah.edu>
# Novemeber 17, 2000

# TODO:
# Turn off coredumps in ourself, and our children
# Check to make sure only files/directories under user's $HOME can be
#  passed as arguments, CD'ed to, etc

14 15 16 17 18
#
# Configure variables
#
my $TB		= "@prefix@";

19 20
# List of allowed commands - Mapping is from command entered by the user
# to the actual binary to run
21
%allowed = (	"nalloc"	=> "$TB/bin/nalloc",
22
		"nfree"		=> "$TB/bin/nfree",
23
		"node_reboot"	=> "$TB/bin/node_reboot",
24
		"node_update"	=> "$TB/bin/node_update",
25
		"os_load"	=> "$TB/bin/os_load",
26
		"create_image"	=> "$TB/bin/create_image",
27
		"node_admin"	=> "$TB/bin/node_admin",
28
		"delay_config"	=> "$TB/bin/delay_config",
29
		"savelogs"	=> "$TB/bin/savelogs",
Leigh Stoller's avatar
Leigh Stoller committed
30
		"portstats"	=> "$TB/bin/portstats",
31
		"eventsys_control" => "$TB/sbin/eventsys_control"
32
	   );
33

34
# Need to provide a simple path, because some scripts we call need one
35
$ENV{PATH} = "$TB/bin:/bin:/usr/bin:/usr/local/bin";
36 37 38 39 40 41 42 43 44 45
# Clean the environment of potentially nasty variables
delete @ENV{qw(IFS CDPATH ENV BASH_ENV)};

$prompt = "paperbag> "; # Prompt for interactive commands

# Following message gets displayed to interactive users
$message = "This is a restricted shell, and will only allow you to run
a limited set of commands. For an unrestrictive shell, log into
ops.emulab.net\n";

46
$debug = 0;
47
$| = 1; # No line buffering, so that we can see the prompt
48
$interactive = 1;
49

50
if (@ARGV && ($ARGV[0] eq "-c")) { # We were called by sshd - transform args into a useful form
51 52 53 54 55 56 57
	my $bigarg = pop @ARGV;
	push(@ARGV,split(/\s+/,$bigarg));
	shift @ARGV; # Dispose of -c
	$interactive = 0;
	&debug("New args are: " . join(",",@ARGV) . "\n");
}
	
58 59 60 61
# Check for a leading dir= option, which tells us which directory to start from
if (@ARGV && ($ARGV[0] =~ /dir=(.*)/)) {
	shift @ARGV;
	&cd($1); # Change to given directory
62
} elsif(@ARGV && ($ARGV[0] eq "cd")) { # also understand 'cd dir &&' or 'cd dir ;' syntax to be a little more compatible
63 64 65 66 67 68 69 70 71 72 73 74
	  # with other shells
	# Discard the cd
	shift @ARGV;
	my $dir = shift @ARGV;
	my $trash = shift @ARGV;
	if (($trash ne "&&") && ($trash ne ";")) {
		die "Syntax error: expected && or ; after cd <dir>\n";
	}
	# Untaint directory name - changing directories isn't a security risk in our situation
	if ($dir =~ /^(.*)$/) {
		&cd($1);
	}
75 76 77 78 79
}

if (@ARGV) { # We were given command line arguments
	$interactive = 0;
	$command = $ARGV[0];
80
	&debug("NON-INTERACTIVE: command is $command\n");
81
	@args = @ARGV[1 .. $#ARGV];
82
	&debug("NON-INTERACTIVE: args are " . join(",",@args) ."\n");
83 84 85 86 87 88 89 90 91 92 93 94
}

if ($interactive) {
	print $message;
}

do {{
	if ($interactive) {
		print $prompt;
		($command, @args) = split /\s+/,<>;
	}
	
95
	next unless $command; # Don't complain if they leave a blank command
96 97
	# Don't allow any naughty characters - kick the user off if they try
	foreach $string ($command, @args) {
98
		if ($string !~ m|^([A-Za-z0-9._\-/=\+,\,]*)$|) {
99 100
			print "Sorry, you used a forbidden character in your command line\n";
			print "Please contact testbed-ops\@emulab.net if you believe this message is in error\n";
101
			&debug("String was $string\n");
102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145
			exit(-1);
		} else {
			$string = $1; # Untaint
			&debug("No forbidden characters\n");
		}
	}

	# Strip off all path information from the command
	$command =~ /([^\/]+)$/; $command = $1;
	next unless $command; # Don't complain if they leave a blank command
	&debug("Command = $command, @args = " . join ",",@args . "\n");

	# 'builtin' commands
	if ($command eq "exit") { $interactive = 0; last; } # Quit loop
	if ($command eq "cd") {
		if (@args > 1) {
			print "cd: Too many arguments\n";
		} else {
			&cd($args[0]);
		}
		next;
	}

	if (!$allowed{$command}) {
		print "$command is not in the allowed list, sorry\n";
	} else {
		# Exec ourselves to be SURE that a shell doesn't get called
		# and do something insecure
		my $pid = fork();
		if ($pid == -1) { # fork failed
			print "Unable to fork process - Error number $?\n";
		} elsif ($pid) { # parent - wait for child to exit
			wait;
		} else { # child process
			exec ($allowed{$command},@args) or
				die "Unable to execute $command: $?\n";
		}
	}
}} while ($interactive);

# Change directory to the given directory, (TODO) checking whether
# it is appropriate to do so or not
sub cd {
	my $dirname = shift;
146
	chdir $dirname or warn "Unable to change directories to $dirname\n";
147 148 149 150 151 152

}

sub debug {
	if ($debug) { print @_; }
}