GitLab

Was returning a structure with a pointer to a stack-allocated string in
it. Use knowledge about where that string came from to avoid having to
make a copy of it, instead.

There is still a minor memory leak, but left behind a note rather than
fixing it (which would be quite involved).

Because it's operating on char*s, the STL list remove() function
doesn't work; it needs to do a strcmp, not a simple comparison. So, hand-write
the loop to do this.

Also add a santity check to produce a fatal error rather than allowing this
function to go into an infinite loop.

We had a special hack to make sure general/testbed_shutdown sitevar exists,
however we were trying to initialize the ns_include column that doesn't
exist til DB update 191.  Now we just explicitly set known-to-exist columns.

SA of the caller. This means we call out to the Emulab newgroup script
to create a group if it does not exist. We also have to reset the
groups of the GeniUser once we know the SA. 

Other small changes:

* Minor module shuffling.
* Use GetSiteVar() from emutil instead of libdb
* Get rid of obsolete code referring to the old reservation holding
  experiment.
* Cleanup logfiles in the workdir.
* Capture output from the mapper and reformat error logging to make it
  more apparent to the caller what went wrong.
* Change call to GeniSliver::Node->Create(); pass in the node object.

the of the virtual nodes on the vhost are gone. We were hanging onto
vhosts for longer then necessary.

look for an existing credential in the table.

Clean up GeniSliver::Node::Create(); remove duplicate code and unify
the virtnode vs pnode cases. Also change the arguments; instead of a
uuid for the node, just pass in the actual node object from the CM.

for logging errors.

CM to capture the output of varuous commands so that the logs can be
sent to the user, with formatting.

Add subgroup handing in FlipToGeniUser(), and also add ResetGroups()
to change the user's group membership, since the slice experiments are
now created in a subgroup of GeniSlices (named by the user's SA).

toString() that says how to indent the string. Very useful for
printing debugging output. Defaults to 0 (no formating).

an email message. 2) On real errors, stick the libaudit output into
the "output" slot of the GeniResponse structure.

subgroups of GeniSlices, so need to return that extra group
and group membership for users bound to the slice.

want it in the repo.

might not be able to write the output file. Better to us syslog anyway
since its a low usage command.

Mail follows:

From: Keith Sklower <sklower@vangogh.CS.Berkeley.EDU>
To: ricci@flux.utah.edu
Subject: bug in snmpit_hp.pm
Date: Sat, 6 Nov 2010 13:15:46 -0700 (PDT)

There are two extra characters in snmpit_hp.pm that shouldn't be there.

For some reason, it doesn't seem to matter to older firmware running
on our 5412s that I wanted to do something with a non-existant port,
but a lowly 1U 2810 that we were testing out as a control switch
threw a hissy-fit.

operational and may never be so. Just want to get it into the
repo.

records, with a null URL. Needs more thought, see comment in the code.

Added DoD Distribution Statement A, which pertains to DARPA's support for
certain portions of the Emulab software.  The statement says that these
portions of Emulab are "approved for public release; distribution is
unlimited."

Also performed other various cleanups: put two blank lines before headings;
indent displayed URLs and email addresses consistently; fixed a typo in the
emulab-users list URL; and fixed punctuation around quotes.

Remove Kentucky instructions, just leaving the URL: the ones in
the handout appeared to be out of date, and the online page
contains the full set of instructions

Add a link to the flash client

Add a few URLs for more information

In two formats: a square-ish one and a wide banner. SVG source
and PNG renderings included.