GitLab

and complaining about this week.

1. editgroup: You can now edit the trust levels for existing group
   members (default group too), and you can specify trust levels when
   adding users to subgroups.

2. approveusers: When approving users in the approval page, you can
   specify different levels of trust. Before, I invisibly set all the
   trust values the same. I also added some ordering to the DB query
   to group users together.

3. I added a great deal of error checking to the processing pages for
   both forms. I split things up into a pre/post pass. The prepass
   goes through all of the form args and checks them for consistency
   and correctness. Nothing is changed in the DB unless all checks
   pass for all args. Then I do a second pass and make the changes.
   Both scripts set the ignore_user_abort() flag to prevent the user
   from stopping the script and causing a DB inconsistency.

4. Added trust consistency checks as well. Rather than allow the
   project or group leader to set inconsistent trust levels, I look
   for those and just plain disallow them. You may not give different
   trust levels in different subgroups of the *same* project, and you
   may not give a user a higher trust level in the default group than
   in the subgroups. Both edit and approve make these checks, and the
   code is absolutely awful.

    From: "Patrick Tullmann 'tullmann'" <tullmann@cs.utah.edu>
    Subject: Re: TESTBED: aclement janos Project Join Request

    First the reply-to: address for approval mails should be
    testbed-ops@fast (right?).

    Second, Austin isn't listed on my testbed user approval page.  I
    assume Mike or a testbed person approved him (which is good because
    who knows when I'd get around to it. :)

    An option like "remove" or "ignore" or something like that for just
    nuking requests without a reply would be useful (I've got some guy
    from yahoo.com who wants to join Janos).

    Also, the date of the join request would be nice to know (e.g., for
    the above, I think he tried joining 4 or 5 months ago).

    he documentation above the table is out of synch with the pull-down
    boxes.

who the user is instead of passing ?uid to every page all the way down.
Update login timeout with each useful operation (done in checklogin).
Put default user name in the login box when visiting the page.

of all that duplicated goo).
Clean up all the formerror code, calling standard FORMERROR() function.
Get rid of all the inline DB specific constants, moving them to dbdefs.php3
include file.

multiple projects.