1. 12 Feb, 2007 19 commits
    • Leigh B. Stoller's avatar
      afeb54ce
    • Leigh B. Stoller's avatar
    • Robert Ricci's avatar
      a7d7a046
    • Robert Ricci's avatar
      Horrible hack. Browsers seem to not always reload style sheets even · 2028560a
      Robert Ricci authored
      when they have changed. So, change the URL for our stylesheet in
      order to force browsers to load a new version. (I installed this
      manually on boss.)
      
      This should be removed before making a release!
      2028560a
    • Robert Ricci's avatar
      New front page text, for the first time in a few years. More clearly · b3e8a3e5
      Robert Ricci authored
      enumerates the different experimental environments we support. Most
      of the new text only gets displayed at Utah, since no one else has
      wireless nodes, etc. Other sites get some short generic text.
      
      New banner, plus other visual tweaks. The new banner is turned on via
      the new @FANCYBANNER@ autoconf variable. This is turned on for
      TBMAINSITE, but defaults to off for other sites. This is so that
      existing sites which already have their own versions of the old banner
      don't have to update them right away.
      
      Made the usage iframe a little less prominent, by darkening it, and
      making it ever so slightly transparent on browsers that support it.
      
      Some minor visual tweaks to the background and content area.
      
      Added specific IDs for the main menu subgroups so that if we want, we
      can style them differently.
      
      Man, IE is a pain in the ass.
      b3e8a3e5
    • Robert Ricci's avatar
      New front page text, for the first time in a few years. More clearly · ff45e20e
      Robert Ricci authored
      enumerates the different experimental environments we support. Most
      of the new text only gets displayed at Utah, since no one else has
      wireless nodes, etc. Other sites get some short generic text.
      ff45e20e
    • Leigh B. Stoller's avatar
      Minor bug fixs. · 80706c3f
      Leigh B. Stoller authored
      80706c3f
    • Leigh B. Stoller's avatar
      Minor bug fix; show bindings only once! · 790084f6
      Leigh B. Stoller authored
      790084f6
    • Mike Hibler's avatar
      Add global option (variable: NOCOLLAB) to disable installation of · 40960541
      Mike Hibler authored
      "collaboration tools" for testing.
      40960541
    • Leigh B. Stoller's avatar
    • Leigh B. Stoller's avatar
      Minor bug fixes · 7deb603b
      Leigh B. Stoller authored
      7deb603b
    • Leigh B. Stoller's avatar
      Fix minor bug. · 36c598fc
      Leigh B. Stoller authored
      36c598fc
    • Leigh B. Stoller's avatar
      Minor bug fix. · 6d2eab56
      Leigh B. Stoller authored
      6d2eab56
    • Leigh B. Stoller's avatar
    • Leigh B. Stoller's avatar
      3e2004e8
    • Jonathon Duerig's avatar
      Robustified and cleaned up monitor.py. Pruned dead code. Consistentified error... · c3b24be8
      Jonathon Duerig authored
      Robustified and cleaned up monitor.py. Pruned dead code. Consistentified error reporting. Added a fake-running option and a script to use it so that it can be tested on libnetmon logs without sending events etc. rather than being run in real time.
      c3b24be8
    • Leigh B. Stoller's avatar
      * Replace the argument processing code in all pages. Currently we rely on · 48acc8e3
      Leigh B. Stoller authored
        register_globals=1 to turn POST/GET/COOKIES arguments in local variables.
        This is known to be a terrible security risk, and we keep saying we are
        going to fix it, and now I am. In order to accomplish this on a
        transitional basis (since I don't want the entire web interface to stop
        working while I debug it), and because the code just needs the cleanup, I
        am doing it like this: Each page will sport new declarations at the top:
      
      	RequiredPageArguments("experiment", PAGEARG_EXPERIMENT,
                                    "template",   PAGEARG_TEMPLATE,
                                    "instance",   PAGEARG_INSTANCE,
                                    "metadata",   PAGEARG_METADATA,
                                    "osinfo",     PAGEARG_OSINFO,
                                    "image",      PAGEARG_IMAGE,
                                    "project",    PAGEARG_PROJECT,
                                    "group",      PAGEARG_GROUP,
                                    "user",       PAGEARG_USER,
      			      "node",       PAGEARG_NODE,
      			      "yesno",      PAGEARG_BOOLEAN,
      			      "message",    PAGEARG_STRING,
      			      "age",        PAGEARG_INTEGER,
                                    "cost",       PAGEARG_NUMERIC,
                                    "formfields", PAGEARG_ARRAY,
                                    "unknown",    PAGEARG_ANYTHING);
      
      	OptionalPageArguments("canceled", PAGEARG_BOOLEAN);
      
        The first token in each pair is the name of the global variable to
        set, and the second token is the type. So, for "experiment" we look at
        the URL for a pid/eid or exptidx, etc, sanity check them (safe for a
        DB query), and then try to find that experiment in the DB. If it maps
        to an experiment, set global variable $experiment to the object. Since
        its a required argument, produce an error if not supplied. Similar
        treatment for optional arguments, with the obvious difference.
      
        The goal is to have ALL argument processing in one place, consistent,
        and correct. I've found numerous places where we leak unchecked
        arguments into queries. It also cuts out a lot of duplicated code.
      
      * To make the above easier to deal with, I've been replacing lots of
        hardcoded URLS in the code of the form:
      
      	foo.php3?pid=$pid&eid=$eid ...
      
        with
      
              CreateURL("foo", $experiment)
      
        which creates and returns the neccessary url string, by looking at
        the type of its arguments (experiment, template, instance, etc.)
      
        Eventually plan to replace them all so that URL handling throughout
        the code is all defined in one place (all the new URL code is in
        url_defs.php).
      
      * I have cranked up error reporting to tell me anytime a variable is
        used before it is initialized, plus a bunch of other stuff that PHP
        deems improper. Think of it like -Wall ... and boy we get a lot of
        warnings.  A very large percentage of the diffs are to fix all these
        warnings.
      
        The warnings are currently going to /usr/testbed/log/php-errors.log,
        and I'll be adding a script to capture them each night and mail them
        to tbops. This file also gets errors (this will be a change for
        developers; rather then seeing errors and warnings dumped in the
        middle of web pages, they will go to this file instead).
      
      * Major refactoring of the code. More objects (nodes, images, osids).
        Moving tons of queries into the objects in the hopes of someday
        getting to a point where we can split the web interface onto a
        different server.  Lots of general cleanup.
      48acc8e3
    • Dan Gebhardt's avatar
      Commented out code that writes the list of possible nodes to a file. · 62d25f4f
      Dan Gebhardt authored
      This file was used for "human reference" when comparing to the nodes
      Emulab knows about.
      62d25f4f
    • Leigh B. Stoller's avatar
      9161ba53
  2. 10 Feb, 2007 1 commit
  3. 09 Feb, 2007 2 commits
  4. 08 Feb, 2007 1 commit
  5. 07 Feb, 2007 10 commits
  6. 06 Feb, 2007 2 commits
  7. 05 Feb, 2007 5 commits