GitLab

In order to test the portfix changes to snmpit, a new version of
the tool and its modules has been split off here.  This new version
will be selected via a site variable / emulab feature.  This also
reverts changes to the mainline Ports module and snmpit modules
in the snmpit_test subdirectory.  The modified Port module will
go by the name of Ports_portfix.pm, and will ultimately disappear
once these changes have been vetted at the Utah Emulab site.

The lookup functions now look at the wire type and which location the
requested node is in (node_id1 or node_id2) to decide which side of the
link the port represents (switch vs. endpoint).  We don't (yet) query the
nodes table for the role since we consistently use the node_id1 (and
related) columns to hold the endpoint (node) information for wires of
type "Node".

For inter-switch
trunks, we always mark the port object as being the "switch" side.  Both
sides are the switch side...  Functions like getPCPort() and getSwitchPort()
are ambiguous when invoked on a switch port object, and will always return
a reference to the object the method was invoked on.

Also update the HP snmpit module to explicitly check the wire type for a port
before deciding whether or not to get the port at the other end in the
listVlans() function.

Run as follows:

boss> wap perl snmpit_test --prunestalevlans --impotent

which will tell you about them. Remove the --impotent option to
actually remove them.

Only numbered lans are considered; ones that derive from entries in
the lans table. Named vlans are skipped since those are generally
created by hand (often via the switch CLI).

Caveat; vlans left on trunk links are still a bit of problem since
listvlans returns the other side of the trunk. Needs to be fixed.

This commit is intended to makes the license status of Emulab and
ProtoGENI source files more clear.  It replaces license symbols like
"EMULAB-COPYRIGHT" and "GENIPUBLIC-COPYRIGHT" with {{{ }}}-delimited
blocks that contain actual license statements.

This change was driven by the fact that today, most people acquire and
track Emulab and ProtoGENI sources via git.

Before the Emulab source code was kept in git, the Flux Research Group
at the University of Utah would roll distributions by making tar
files.  As part of that process, the Flux Group would replace the
license symbols in the source files with actual license statements.

When the Flux Group moved to git, people outside of the group started
to see the source files with the "unexpanded" symbols.  This meant
that people acquired source files without actual license statements in
them.  All the relevant files had Utah *copyright* statements in them,
but without the expanded *license* statements, the licensing status of
the source files was unclear.

This commit is intended to clear up that confusion.

Most Utah-copyrighted files in the Emulab source tree are distributed
under the terms of the Affero GNU General Public License, version 3
(AGPLv3).

Most Utah-copyrighted files related to ProtoGENI are distributed under
the terms of the GENI Public License, which is a BSD-like open-source
license.

Some Utah-copyrighted files in the Emulab source tree are distributed
under the terms of the GNU Lesser General Public License, version 2.1
(LGPL).

Add "Unused" to type enum in the wires table.
Change a few critical wires/interfaces queries to avoid logical=1.

Port refactoring for snmpit apcon/hp/cisco done, all run very well, trunking still not tested but be expected to be OK.

commit refactored code before merging old ones, the new_snmpit frontend, lib, lan, stack, hp, apcon already merged