GitLab

1. Get rid of direct queries to wires and interfaces, use library.

2. Allow node:iface on the command line for ports.

3. Add -i option to print out results in node:iface. Eventually we want
   to flush card.port output, but lets wait on that for a while.

4. Switch from card,port to iface lookups.

5. The DB change adds iface to the port_counters table, no longer using
   card,port. Eventually flush them.

no need to ever use card,port since we never actually put that into into
the ptop file.

which is always cause of perl hashes. Some cases do not matter, so just
added some sorts to those, others are conditionalized.

although need to come back to this once I figure out what the right
thing to do is.

m2crypto's default SSLServer.handle_error function was just printing to
stdout; that is an easy fix.  However, what is hard is associating the
Exception with a client_address due to the
socket/M2Crypto.SSL.Connection abstraction abuse.  Lots of stuff
happens in Connection.accept(), and if an Exception is raised in there,
no client_address is returned to the caller (i.e. handle_request()).
m2crypto does a real disservice by overlaying the socket API and thus
masking so many customization points that any real user would want to use.

Bump the SSL accept phase to 3 seconds to be a tad more gracious to
legitimately-slow clients.  Also restore the default SSL timeout to None
(i.e. whatever the underlying default timeout is).

Did this before I realized how DoneIfEdited worked, but it seems like a
useful function to have for something someday.

We were not returning the correct number of values.

Otherwise, if sitevar general/export_active had the default value of "0",
we would call exports_setup on every single xmlrpc call since "0" != 0.

1. Beef up MakeFake in Interface/Wires and use that from Port library
   instead of existing fake stuff.

2. Add a Create routine for wires, remove all the direct insertions
   scattered around the code.

3. Add some Lookup routines, so we can remove a bunch of direct queries
   to the DB scattered around the code.

4. Add a trivial wrapper Interface::Type, and give it one useful
   function for now, to map generic speed to interface object.

object lookups via Interface library.

the DB please.

instead. Also create interface for switch side of wire.

Interface::Wire->Create instead of direct DB insertion.