1. 21 Oct, 2008 1 commit
    • Kevin Atkinson's avatar
      If a known user (based on stored cookies) is not logged in than · 846a98d6
      Kevin Atkinson authored
      redirect to the login page rather than printing a message with a link
      to the page.  Otherwise send a "403 Forbidden" to keep robots from
      indexing the page.  Also send appreciate HTTP responses on other
      precheck errors to keep a robot from indexing the page.  In order to
      do this the PAGEHEADER call needed to be moved to after
      CheckLoginOrDie and Required/OptionalPageArguments on many pages.  A
      warning will be printed if either CheckLoginOrDie or
      Required/OptionalPageArguments detects that PAGEHEADER was already
      called.
      
      Also change the redirect in kb-show to be a permanent redirect (301)
      rather than a temporary one (302) which is the default unless a status
      code is given.
      846a98d6
  2. 18 Jul, 2008 1 commit
  3. 19 Sep, 2007 1 commit
  4. 10 Sep, 2007 1 commit
    • Leigh B. Stoller's avatar
      Rework the newosid web page as an example of how I want all of our current · 77540494
      Leigh B. Stoller authored
      form processing to be done.
      
      The gist is that I have moved all of the data checking and DB work to
      the backend into a new script called utils/newosid. This script does
      all the field checking that used to be done in php. It takes a simple
      XML file as input and returns a set of strings to format as errors (if
      there are any).
      
      The overall goal to make a big push to move this code out of PHP and
      perl.  A nice side effect is that many operations that are current
      only available via the web interface will also become available
      command line (and also XMLRPC with a little moew work).
      77540494
  5. 20 Jun, 2007 1 commit
    • Leigh B. Stoller's avatar
      Add summary node utilization stats. The initial values are derived by · 21890006
      Leigh B. Stoller authored
      processing the node_history table, but that is *way* too slow to do on
      the fly (say, from the web interface) cause of the number of records,
      so the summary info is stored in the new node_utilization table. I
      generate the summary info as new entries are added to node_history (in
      SetNodeHistory) but if that becomes too messy, we can just as easily
      shift to processing the table on a nightly basis.
      
      Note that I added a new "inception" date field to the nodes table,
      which will get set on new nodes, but for existing nodes I have to
      derive it from the first entry in the node_history table, or else the
      numbers will not make sense.
      21890006
  6. 16 May, 2007 1 commit
  7. 12 Feb, 2007 1 commit
    • Leigh B. Stoller's avatar
      * Replace the argument processing code in all pages. Currently we rely on · 48acc8e3
      Leigh B. Stoller authored
        register_globals=1 to turn POST/GET/COOKIES arguments in local variables.
        This is known to be a terrible security risk, and we keep saying we are
        going to fix it, and now I am. In order to accomplish this on a
        transitional basis (since I don't want the entire web interface to stop
        working while I debug it), and because the code just needs the cleanup, I
        am doing it like this: Each page will sport new declarations at the top:
      
      	RequiredPageArguments("experiment", PAGEARG_EXPERIMENT,
                                    "template",   PAGEARG_TEMPLATE,
                                    "instance",   PAGEARG_INSTANCE,
                                    "metadata",   PAGEARG_METADATA,
                                    "osinfo",     PAGEARG_OSINFO,
                                    "image",      PAGEARG_IMAGE,
                                    "project",    PAGEARG_PROJECT,
                                    "group",      PAGEARG_GROUP,
                                    "user",       PAGEARG_USER,
      			      "node",       PAGEARG_NODE,
      			      "yesno",      PAGEARG_BOOLEAN,
      			      "message",    PAGEARG_STRING,
      			      "age",        PAGEARG_INTEGER,
                                    "cost",       PAGEARG_NUMERIC,
                                    "formfields", PAGEARG_ARRAY,
                                    "unknown",    PAGEARG_ANYTHING);
      
      	OptionalPageArguments("canceled", PAGEARG_BOOLEAN);
      
        The first token in each pair is the name of the global variable to
        set, and the second token is the type. So, for "experiment" we look at
        the URL for a pid/eid or exptidx, etc, sanity check them (safe for a
        DB query), and then try to find that experiment in the DB. If it maps
        to an experiment, set global variable $experiment to the object. Since
        its a required argument, produce an error if not supplied. Similar
        treatment for optional arguments, with the obvious difference.
      
        The goal is to have ALL argument processing in one place, consistent,
        and correct. I've found numerous places where we leak unchecked
        arguments into queries. It also cuts out a lot of duplicated code.
      
      * To make the above easier to deal with, I've been replacing lots of
        hardcoded URLS in the code of the form:
      
      	foo.php3?pid=$pid&eid=$eid ...
      
        with
      
              CreateURL("foo", $experiment)
      
        which creates and returns the neccessary url string, by looking at
        the type of its arguments (experiment, template, instance, etc.)
      
        Eventually plan to replace them all so that URL handling throughout
        the code is all defined in one place (all the new URL code is in
        url_defs.php).
      
      * I have cranked up error reporting to tell me anytime a variable is
        used before it is initialized, plus a bunch of other stuff that PHP
        deems improper. Think of it like -Wall ... and boy we get a lot of
        warnings.  A very large percentage of the diffs are to fix all these
        warnings.
      
        The warnings are currently going to /usr/testbed/log/php-errors.log,
        and I'll be adding a script to capture them each night and mail them
        to tbops. This file also gets errors (this will be a change for
        developers; rather then seeing errors and warnings dumped in the
        middle of web pages, they will go to this file instead).
      
      * Major refactoring of the code. More objects (nodes, images, osids).
        Moving tons of queries into the objects in the hopes of someday
        getting to a point where we can split the web interface onto a
        different server.  Lots of general cleanup.
      48acc8e3
  8. 20 Dec, 2006 1 commit
  9. 14 Dec, 2006 1 commit
  10. 12 Apr, 2006 1 commit
  11. 16 Dec, 2005 1 commit
    • Leigh B. Stoller's avatar
      Add support for pre-reserving nodes. New link off the ShowNode page · e49e2f9a
      Leigh B. Stoller authored
      allows takes you to new (admin only) page to select a project that
      node will be reserved for.
      
      * The node is not actually *reserved*, it is *pre* reserved! The node
        stays in the free pool, and is available only for use in the project
        to which it is reserved.
      
      * The node can already be reserved to some other project when you
        pre-reserve it. It is not until the current owner releases the node
        that the pre-reservation takes effect.
      
      * The node free counts (on the web pages) count a free a node with a
        pre-reservation, as allocated. This way people do not see a free
        count that includes a node they will never be able to get.
      e49e2f9a
  12. 25 Aug, 2005 1 commit
    • Timothy Stack's avatar
      · 25ca9681
      Timothy Stack authored
      Add some checks for 'free' nodes that are not allocatable.
      
      	* db/audit.in: Include the list of nodes that are not reserved but
      	have an eventstate that makes them unallocatable.
      
      	* www/dbdefs.php3.in: Add POWEROFF and ALWAYSUP node states.
      
      	* www/nodecontrol_list.php3: Add an asterisk next to the free
      	count for type(s) that have free, but unallocatable nodes.
      
      	* www/shownodetype.php3: If a node is free, but unallocatable, put
      	a yellow ball next to its name instead of a green one.
      25ca9681
  13. 06 May, 2005 1 commit
  14. 20 Apr, 2005 1 commit
  15. 12 Apr, 2005 1 commit
  16. 08 Dec, 2004 1 commit
    • Leigh B. Stoller's avatar
      Stripped down version of the floormap code that shows the robotmap · ca9ea012
      Leigh B. Stoller authored
      with no other stuff on page. Notes:
      
      * I added a new building called MEB-ROBOTS cause otherwise it would
        show up on the wireless maps since floormap gets all the floors for
        a building. Need to add type tags someplace, but not sure where yet
      
      * I committed Russ' initial jpeg image to use in the floorimages
        table. Russ can replace that when he generates a better looking
        version.
      
      * I linked the robots map in from the node status page ...
      ca9ea012
  17. 30 Nov, 2004 2 commits
  18. 09 Jun, 2004 1 commit
    • Leigh B. Stoller's avatar
      Switch everything over to using new buildings and floorimages tables · 315c5d9c
      Leigh B. Stoller authored
      that I added to the DB. See revision 1.251 of sql/database-create.sql.
      I have removed all of the hardwired names of buildings, images, files,
      etc. I have also added MEB floors 1 and 2, but they do not show up on
      the status page unlesss there are actually nodes assigned to them.
      When you go to set a node location, you do see the little thumbs of
      all existing buildings/floors, so you can add nodes to floors that do
      not currently have any.
      
      Still needs some work to cleanly display multiple buildings, but thats
      for another day.
      315c5d9c
  19. 17 May, 2004 1 commit
    • Leigh B. Stoller's avatar
      Change the Free Node Summary page to allow showing the summary by · 0a04f07b
      Leigh B. Stoller authored
      project permission. By default you get a summary of all the free nodes
      you can use in all your project memberships, which is not too
      useful. It would be more useful to see what types you can use by
      project, since that is how permission is granted and how experiments
      are created. So, when you are a member of more than one project,
      display a list of those projects along the top so you can see the list
      on a per-project basis.
      
      More generally, if you are an admin person:
      
      	www.emulab.net/nodecontrol_list.php3?showtype=summary&bypid=tbres
      
      will show out the summary information for a particular project. At
      some point I need to make this a subroutine that we can call from
      other pages to drop in a summary table.
      0a04f07b
  20. 12 Apr, 2004 1 commit
    • Leigh B. Stoller's avatar
      Add a "wireless" link from the Node Status page. · 495e3cee
      Leigh B. Stoller authored
      Remove isadmin() restriction from floormap pages; at some point I
      assume we make the floormaps publically available.
      
      Make MEB the default argument to the floormap page until such time
      that we need something fancier.
      
      Add a link to the wireless tutorial I am currently throwing up onto
      paper.
      495e3cee
  21. 23 Mar, 2004 1 commit
  22. 26 Feb, 2004 2 commits
  23. 11 Feb, 2004 1 commit
  24. 12 Jan, 2004 1 commit
  25. 23 Oct, 2003 2 commits
  26. 01 Oct, 2003 1 commit
  27. 19 Sep, 2003 1 commit
  28. 18 Sep, 2003 1 commit
  29. 01 Sep, 2003 1 commit
  30. 04 Aug, 2003 1 commit
  31. 24 Jul, 2003 1 commit
  32. 28 Apr, 2003 1 commit
  33. 08 Apr, 2003 2 commits
  34. 07 Mar, 2003 1 commit
  35. 31 Jan, 2003 1 commit
  36. 02 Dec, 2002 1 commit