GitLab

This commit is intended to makes the license status of Emulab and
ProtoGENI source files more clear.  It replaces license symbols like
"EMULAB-COPYRIGHT" and "GENIPUBLIC-COPYRIGHT" with {{{ }}}-delimited
blocks that contain actual license statements.

This change was driven by the fact that today, most people acquire and
track Emulab and ProtoGENI sources via git.

Before the Emulab source code was kept in git, the Flux Research Group
at the University of Utah would roll distributions by making tar
files.  As part of that process, the Flux Group would replace the
license symbols in the source files with actual license statements.

When the Flux Group moved to git, people outside of the group started
to see the source files with the "unexpanded" symbols.  This meant
that people acquired source files without actual license statements in
them.  All the relevant files had Utah *copyright* statements in them,
but without the expanded *license* statements, the licensing status of
the source files was unclear.

This commit is intended to clear up that confusion.

Most Utah-copyrighted files in the Emulab source tree are distributed
under the terms of the Affero GNU General Public License, version 3
(AGPLv3).

Most Utah-copyrighted files related to ProtoGENI are distributed under
the terms of the GENI Public License, which is a BSD-like open-source
license.

Some Utah-copyrighted files in the Emulab source tree are distributed
under the terms of the GNU Lesser General Public License, version 2.1
(LGPL).

image_metadata.php will return an Emulab style image descriptor in XML
format. A remote emulab, given an image URL, will grab this XML
description and use it to create a local descriptor. Inside the
descriptor is an additional URL that is used to download ndz file.

The dumpdescriptor script is now web accessible, and takes a new -e
(export) option that adds the extra URL and other bits that are needed
to import the descriptor and the image.

On the Show Image page, show the metadata URL, which is suitable for
using in an NS file or an rspec (when that code is committed).

web interface.

Most of this commit is about making it easier to create the
descriptors (of any kind) The newimageid_ez page now takes an optional
node_id on which to base the new descriptor; most of the fields are
initialized.

You can also provide optional imageid and osinfo arguments, which
allows for slightly less info to be initialized.

Then on the ShowNode page, the link to create an image will take you
to the snapshot image page if the user has write access to the image,
otherwise to the newimageid_iz page to create and snapshot a new
image descriptor.

Hardwire the sort type for a few columns that cause guessType grief.

Remove the insertion of blank-rows-as-spacers in a table. They don't
sort well. Leigh got rid of most of these a while back.

The former ensures that we get the same behavior as when the same
sorted output is produced using "order by" in mysql. I added a
sortable_alpha_cs that we can use for a column should we discover
a case where we really want a case-sensitive sort.

The latter ensures that a user can at least manually do a multi-column
sort (e.g., the equiv of "order by state,eid" when displaying experiments
by clicking on the eid column and then on the state column).

This is needed due to the odd way in which we use sorttable.
In normal use, sorttable.init would be called via the DOMContentLoaded
event hook and this would invoke makeSortable() to do the DOM magic
necessary to ensure all tables marked sortable are make sortable.

But due to our use of AJAX-y dynamic content loading, this won't work
(or so I am told!) So we generate our own call to makeSortable(mytable)
when we produce any sortable table "mytable". But if init() has not been
called before that first call to makeSortable, the DATE_RE regex will
not be initialized and strange things happen in guessType and consequently,
in the sort functions themselves.

This allows us to more easily disable a subboss in the event of a temporary
subboss outage (e.g., hardware failure). Previously we would have to remove
the related rows from the DB and restore them later.

and provide a web interface to look at them.

For InstaGeni, need to record and be able to search for history by
control net mac address. We now record this in the node_history table,
with corresponding change to the ShowNodeHistory web page.

The backend changes required are that we 1) actually generate a mac
address for VMs and stick it into the interfaces record, 2) return
that mac from tmcd in the jailconfig, and 3) have the openvz library
create the control net interface using that mac.

On the openvz image, needed to switch to using a control network
bridge for all interfaces (not just routable ones) so that traffic
leaves the node with the correct mac.

We had a couple of different problems actually.

* We allow users to insert html into many DB fields (say, a project or
  experiment description).

* We did not sanitize that output when displaying back.

* We did not sanitize initial page arguments that were reflected in the
  output (say, in a form).

Since no one has the time to analyze every line of code, I took a couple of
shortcuts. The first is that I changed the regex table to not allow any <>
chars to go from the user into the DB. Brutal, but in fact there are only a
couple of places where a user legitimately needs them. For example, a
startup command that includes redirection. I handle those as special
cases. As more come up, we can fix them.

I did a quick pass through all of the forms, and made sure that we run
htmlspecialchars on everything including initial form args. This was not
too bad cause of the way all of the forms are structured, with a
"formfields" array.

I also removed a bunch of obsolete code and added an update script to
actually remove them from the www directory.

Lastly, I purged some XMLRPC code I did a long time ago in the Begin
Experiment path. Less complexity, easier to grok and fix.

	modified:   sql/database-fill.sql
	modified:   sql/dbfill-update.sql

Sort them by the node_id the admins assigned, rather than by the
order they were added in.

addresses on HP switches, including ones which have both control and
Experiment ports.

... we don't do it for any other error, and it's best not to inject
user input back into the HTML page; presumably totally bogus strings
could evaluate to 0, and thus look 'too small'

It's best not to echo any form input back into the page without
cleaning it first, and in this case, it's not that important to
the message.

We did not allow people to change the passphrase on an existing
key, so add a form and change the backend script to allow it.

Also fix bug that was causing old sslcert derived ssh keys
to be left around.

comments in the code.

two different domain tags. Confused Firefox 12.