1. 12 Feb, 2007 1 commit
    • Leigh B. Stoller's avatar
      * Replace the argument processing code in all pages. Currently we rely on · 48acc8e3
      Leigh B. Stoller authored
        register_globals=1 to turn POST/GET/COOKIES arguments in local variables.
        This is known to be a terrible security risk, and we keep saying we are
        going to fix it, and now I am. In order to accomplish this on a
        transitional basis (since I don't want the entire web interface to stop
        working while I debug it), and because the code just needs the cleanup, I
        am doing it like this: Each page will sport new declarations at the top:
      
      	RequiredPageArguments("experiment", PAGEARG_EXPERIMENT,
                                    "template",   PAGEARG_TEMPLATE,
                                    "instance",   PAGEARG_INSTANCE,
                                    "metadata",   PAGEARG_METADATA,
                                    "osinfo",     PAGEARG_OSINFO,
                                    "image",      PAGEARG_IMAGE,
                                    "project",    PAGEARG_PROJECT,
                                    "group",      PAGEARG_GROUP,
                                    "user",       PAGEARG_USER,
      			      "node",       PAGEARG_NODE,
      			      "yesno",      PAGEARG_BOOLEAN,
      			      "message",    PAGEARG_STRING,
      			      "age",        PAGEARG_INTEGER,
                                    "cost",       PAGEARG_NUMERIC,
                                    "formfields", PAGEARG_ARRAY,
                                    "unknown",    PAGEARG_ANYTHING);
      
      	OptionalPageArguments("canceled", PAGEARG_BOOLEAN);
      
        The first token in each pair is the name of the global variable to
        set, and the second token is the type. So, for "experiment" we look at
        the URL for a pid/eid or exptidx, etc, sanity check them (safe for a
        DB query), and then try to find that experiment in the DB. If it maps
        to an experiment, set global variable $experiment to the object. Since
        its a required argument, produce an error if not supplied. Similar
        treatment for optional arguments, with the obvious difference.
      
        The goal is to have ALL argument processing in one place, consistent,
        and correct. I've found numerous places where we leak unchecked
        arguments into queries. It also cuts out a lot of duplicated code.
      
      * To make the above easier to deal with, I've been replacing lots of
        hardcoded URLS in the code of the form:
      
      	foo.php3?pid=$pid&eid=$eid ...
      
        with
      
              CreateURL("foo", $experiment)
      
        which creates and returns the neccessary url string, by looking at
        the type of its arguments (experiment, template, instance, etc.)
      
        Eventually plan to replace them all so that URL handling throughout
        the code is all defined in one place (all the new URL code is in
        url_defs.php).
      
      * I have cranked up error reporting to tell me anytime a variable is
        used before it is initialized, plus a bunch of other stuff that PHP
        deems improper. Think of it like -Wall ... and boy we get a lot of
        warnings.  A very large percentage of the diffs are to fix all these
        warnings.
      
        The warnings are currently going to /usr/testbed/log/php-errors.log,
        and I'll be adding a script to capture them each night and mail them
        to tbops. This file also gets errors (this will be a change for
        developers; rather then seeing errors and warnings dumped in the
        middle of web pages, they will go to this file instead).
      
      * Major refactoring of the code. More objects (nodes, images, osids).
        Moving tons of queries into the objects in the hopes of someday
        getting to a point where we can split the web interface onto a
        different server.  Lots of general cleanup.
      48acc8e3
  2. 24 Jan, 2007 1 commit
  3. 09 Jan, 2007 1 commit
  4. 20 Dec, 2006 1 commit
  5. 03 Jul, 2006 1 commit
  6. 21 Dec, 2005 1 commit
  7. 09 Dec, 2003 1 commit
    • Leigh B. Stoller's avatar
      Add drop down menu to approve project form that allows admin person to · 9d882479
      Leigh B. Stoller authored
      select the default user interface for a project. The choice is current
      'emulab or 'plab', defaults to 'emulab'. New users that join emulab
      get the default user interface from the first project they join.
      
      Also generalize the plab_user bit as new "user_interface" slot of the
      users table, which is an enum of interface tokens, currently either
      'emulab' or 'plab', defaults to 'emulab'. The plab_user bit will be
      removed later.
      9d882479
  8. 12 May, 2003 1 commit
  9. 11 Apr, 2003 1 commit
  10. 21 Mar, 2003 1 commit
  11. 25 Feb, 2003 1 commit
    • Robert Ricci's avatar
      Make sure that the head uid of a project is 'active' or 'unapproved' · 1ebdf309
      Robert Ricci authored
      before allowing a project to be approved. (In approveproject_form,
      this meant removing the automatic transition from 'newuser' to
      'unverified')
      
      Since this check is done in two places, once in the form, and once in
      the page that does the work, it's possible for this to get out of
      sync.
      1ebdf309
  12. 13 Feb, 2003 1 commit
  13. 01 Oct, 2002 1 commit
    • Robert Ricci's avatar
      Add a box to change the head of a project on the project approval · 39eb481b
      Robert Ricci authored
      'action' page. This will be used when a student applies to start
      a project - we'll have the professor, PI, etc. apply to join the
      project, then change the head UID when we approve it.
      
      Changing the head uid is repected when _any_ action is taken
      (postponing, more info requests, etc.) Any mail gets sent to the
      new head, and NOT the old head.
      39eb481b
  14. 29 Jul, 2002 1 commit
    • Leigh B. Stoller's avatar
      Widearea permission changes: · d3c6f9c8
      Leigh B. Stoller authored
      * Two new fields on the new project page that ask the project leader to
        specify how many ron and pcplab nodes they need. There is a link to a
        page that should describe these nodes, but thats blank.
      
      * The project approval page will add a couple of checkboxes for ron and
        pcplab nodes. This will allow the project to be approved independent of
        the ron/pcplab usage. So, you can approve the project but decline the
        request to use those nodes types (or just one of them).
      
      * The project table in the DB has a "list" of remote node types for which
        accounts should be built. Its implemented as a set and it can contain
        just two node types (pcron, pcplab) right now. The set is created in
        the approval page, and someday we can add a page to operate on that
        set directly if we need it.
      d3c6f9c8
  15. 07 Jul, 2002 1 commit
  16. 16 Oct, 2001 1 commit
  17. 30 Aug, 2001 1 commit
  18. 18 Apr, 2001 1 commit
  19. 08 Dec, 2000 1 commit
  20. 15 Nov, 2000 1 commit
  21. 14 Nov, 2000 1 commit
  22. 07 Nov, 2000 4 commits
  23. 06 Nov, 2000 2 commits