- 05 Mar, 2007 1 commit
-
-
Leigh B. Stoller authored
-
- 12 Feb, 2007 1 commit
-
-
Leigh B. Stoller authored
register_globals=1 to turn POST/GET/COOKIES arguments in local variables. This is known to be a terrible security risk, and we keep saying we are going to fix it, and now I am. In order to accomplish this on a transitional basis (since I don't want the entire web interface to stop working while I debug it), and because the code just needs the cleanup, I am doing it like this: Each page will sport new declarations at the top: RequiredPageArguments("experiment", PAGEARG_EXPERIMENT, "template", PAGEARG_TEMPLATE, "instance", PAGEARG_INSTANCE, "metadata", PAGEARG_METADATA, "osinfo", PAGEARG_OSINFO, "image", PAGEARG_IMAGE, "project", PAGEARG_PROJECT, "group", PAGEARG_GROUP, "user", PAGEARG_USER, "node", PAGEARG_NODE, "yesno", PAGEARG_BOOLEAN, "message", PAGEARG_STRING, "age", PAGEARG_INTEGER, "cost", PAGEARG_NUMERIC, "formfields", PAGEARG_ARRAY, "unknown", PAGEARG_ANYTHING); OptionalPageArguments("canceled", PAGEARG_BOOLEAN); The first token in each pair is the name of the global variable to set, and the second token is the type. So, for "experiment" we look at the URL for a pid/eid or exptidx, etc, sanity check them (safe for a DB query), and then try to find that experiment in the DB. If it maps to an experiment, set global variable $experiment to the object. Since its a required argument, produce an error if not supplied. Similar treatment for optional arguments, with the obvious difference. The goal is to have ALL argument processing in one place, consistent, and correct. I've found numerous places where we leak unchecked arguments into queries. It also cuts out a lot of duplicated code. * To make the above easier to deal with, I've been replacing lots of hardcoded URLS in the code of the form: foo.php3?pid=$pid&eid=$eid ... with CreateURL("foo", $experiment) which creates and returns the neccessary url string, by looking at the type of its arguments (experiment, template, instance, etc.) Eventually plan to replace them all so that URL handling throughout the code is all defined in one place (all the new URL code is in url_defs.php). * I have cranked up error reporting to tell me anytime a variable is used before it is initialized, plus a bunch of other stuff that PHP deems improper. Think of it like -Wall ... and boy we get a lot of warnings. A very large percentage of the diffs are to fix all these warnings. The warnings are currently going to /usr/testbed/log/php-errors.log, and I'll be adding a script to capture them each night and mail them to tbops. This file also gets errors (this will be a change for developers; rather then seeing errors and warnings dumped in the middle of web pages, they will go to this file instead). * Major refactoring of the code. More objects (nodes, images, osids). Moving tons of queries into the objects in the hopes of someday getting to a point where we can split the web interface onto a different server. Lots of general cleanup.
-
- 21 Dec, 2006 1 commit
-
-
Leigh B. Stoller authored
queries taken care of. Also, most of them have moved into group_defs.php.
-
- 20 Dec, 2006 1 commit
-
-
Leigh B. Stoller authored
converting to locally unique ids and later globally unique ids.
-
- 26 Oct, 2006 1 commit
-
-
Kevin Atkinson authored
Make an attempt to discover what the error was before an swap-* was canceled, if any. Both the main error (canceled) and the other error are stored in the error table. To support this a new column in the error table is added "rank". The primary error has a rank 0 while the other error has a rank 1. Make an attempt to determine when an error is a "me too" error or the real cause of the problem. "Me too" errors are errors which are generally reported when the callie script determined that the caller script fails. The caller script should have reported the error, but in some cases the error didn't make it into the database. Thus if a "me too" is reported as the cause of a "swap-*" more info is needed to determine the true cause. When a "me too" error is reported it is followed by a "..." on it's own line. It is also recorded in the errors table under the new column "need_more_info". Add inferred column to the errors table. This is the same value as the inferred variable in tblog_find_error. Add revision column to errors table to make it easy to tell which algorithm was used to determine the error.
-
- 21 Mar, 2006 1 commit
-
-
Kevin Atkinson authored
Changed format of email sent to user on errors. The error will now appear instead of the generic message when I am confident it is accurate. The subject line will also change to reflect the cause of an error. Avoid sending mail to testbed-ops during failed swap related evenets in some cases. It will instead be sent to a new mailing list testbed-errors. Added a new row in the experiment info table "Last Error:" which states the cause of the error, and links to a new page displaying the error. Made some assign/assign_wrapper errors more informative. The error (as determined by tblog) is now stored in the database in a more structured fashion. This inlcudes adding a column for the session (in the log table) to testbed_stats to link eash swap event with the logs and possible the error. Other changes to the database, see sql/database-migrate.txt
-