GitLab

Strengthen logic/better code in write-cache reporting. Look for new formatting given by newer smartctl

* remove check for gather arg, use TESTINFO from tmcc hwinfo
  instead. Only call tmcc once. Let non-MFS boot collect data.
* tmcc hwinfo not return a TESTINFO line. Handle the LOGDIR, COLLECT
  and CHECK indicators
* Do to variable scoping make sure everything runs in the shell.
  Do not 'exit' from called programs. Source called programs instead
  of starting new shells.
* Nothing wrong with the which() function I put in since the
  MFS/busybox installation does not have one, but if we have a real
  which(1) program use it.
* output format changes and programming space changes
* remove check for gather arg, use TESTINFO from tmcc hwinfo
  instead. Only call tmcc once. Let non-MFS boot collect data.
* tmcc hwinfo not returning a TESTINFO line. Handle the LOGDIR, COLLECT
  and CHECK indicators
* Do to variable scoping make sure everything runs in the shell.
* Do not 'exit' from called programs. Source called programs instead of
  starting new shells.
* Nothing wrong with the which() function I put in since the MFS/busybox
  installation does not have one, but if we have a real which(1) program
  use it.
* call sub-programs by sourcing not by starting new shell.
* oops mfsmode is not set until initialize is run. also set -e -u to
  catch this type of thing.

Checknode tests once again run in standard images and can collect
data.

* All tests can now be "sourced" from gatherinv to insure everything
  runs in a single shell.
* All tests can also be called standalone.
* MFS mode and non-MFS mode honor the CHECK and COLLECT flags.
* Create, if necessary, a new project save directory.
* This will be needed once every-time checknodes is run in a new project.
  path is /proj/{pid}/nodecheck.
* If script can't run quit with a 'return 0' so the rest of the checks
  can continue.

Change filename gatherinv -> checknode

* Can't run in MFS mode if not in the emulab-ops pid

What source to read the info from and which enternal array to fill.

The compareunits function does not return a result now. Rest of the changes are in formatting output files.

Compare ether addrs in lower case, compare disk serial numbers in upper case.
Don't change the loop termination var while in the loop.
Unset exit on error when doing read operation. Returns a non-zero status.
Don't create a hwinfo file if not requested by the function arguments

Also, some cleanup.

Code cleanup.
Remove debugging code.

More removal of hardwired paths in favor of paths.sh vars.
Included script getfromtb.sh does not exist.
touch and env do not exist in MFS.
Use tmcc, not tmcc.bin.
Create /etc/emulab/ismfs as frisbee MFS doesn't have it.

Merge rc.config changes into the real script.
Reduce rc.nodecheck varients to a single shell script and get rid of rc subdir.
Add copyrights.
Add GNUmakefile install target (but not used yet).
Replace some hardwired paths with vars from paths.sh.