Commit 5fd70e57 authored by Leigh B Stoller's avatar Leigh B Stoller

Make sure we never return undef from an XMLRPC call, always return

a GeniResponse structure.
parent 01549f6d
...@@ -375,7 +375,9 @@ sub CallMethodInternal($$$$@) ...@@ -375,7 +375,9 @@ sub CallMethodInternal($$$$@)
# Sigh. # Sigh.
if (!ref($goo)) { if (!ref($goo)) {
print STDERR "Error in XMLRPC parse: $xmlgoo\n"; print STDERR "Error in XMLRPC parse: $xmlgoo\n";
return undef; $code = GENIRESPONSE_RPCERROR();
$value = undef;
$output = "Could not parse XMLRPC return value: $xmlgoo";
} }
elsif ($goo->value()->is_fault() elsif ($goo->value()->is_fault()
|| (ref($goo->value()) && UNIVERSAL::isa($goo->value(),"HASH") || (ref($goo->value()) && UNIVERSAL::isa($goo->value(),"HASH")
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment