Commit 5cd01fc6 authored by Mike Hibler's avatar Mike Hibler
Browse files

Subtle: when creating symlinks, do NOT include $(DESTDIR) as part of

the source of the link.  Otherwise when installing an MFS with something
like DESTDIR=/mnt, you wind up with links like:

lrwxr-xr-x   1 root  wheel   25 Nov  9 11:45 lib@ -> /mnt/usr/local/etc/emulab

which do not resolve when the MFS is booted.

This assumes that DESTDIR is only used for temporary mounting of filesystems
that are normally mounted elsewhere (and I believe that has always been the
intent of DESTDIR, at least in BSD).  If DESTDIR reflected the true path,
then the links will now be wrong.
parent 822723d1
......@@ -83,11 +83,11 @@ common-script-install: dir-install
symlinks: dir-install
rm -f $(TBBINDIR)/tevc
ln -s $(BINDIR)/tevc $(TBBINDIR)/tevc
ln -s $(CLIENT_BINDIR)/tevc $(TBBINDIR)/tevc
rm -f $(TBBINDIR)/emulab-sync
ln -s $(BINDIR)/emulab-sync $(TBBINDIR)/emulab-sync
ln -s $(CLIENT_BINDIR)/emulab-sync $(TBBINDIR)/emulab-sync
rm -f $(TBLIBDIR)
local-script-install: common-script-install
$(INSTALL) -m 755 $(SRCDIR)/sendevent $(BINDIR)/sendevent
......@@ -98,7 +98,7 @@ local-script-install: common-script-install
# Symlink this cause we invoke it from boss, and its too much
# of a hassle to worry about right now.
rm -f $(ETCDIR)/update
-ln -s $(BINDIR)/update $(ETCDIR)/update
-ln -s $(CLIENT_BINDIR)/update $(ETCDIR)/update
remote-script-install: common-script-install
-chown root $(BINDIR)/vnodesetup
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment